Merge branch 'feature/desktop-daemon-settings'
This commit is contained in:
@@ -48,6 +48,7 @@ import {
|
|||||||
import { SidebarCalloutProvider } from "@/contexts/sidebar-callout-context";
|
import { SidebarCalloutProvider } from "@/contexts/sidebar-callout-context";
|
||||||
import { ToastProvider } from "@/contexts/toast-context";
|
import { ToastProvider } from "@/contexts/toast-context";
|
||||||
import { VoiceProvider } from "@/contexts/voice-context";
|
import { VoiceProvider } from "@/contexts/voice-context";
|
||||||
|
import { initializeHostRuntime } from "@/app/host-runtime-bootstrap";
|
||||||
import { shouldUseDesktopDaemon } from "@/desktop/daemon/desktop-daemon";
|
import { shouldUseDesktopDaemon } from "@/desktop/daemon/desktop-daemon";
|
||||||
import { listenToDesktopEvent } from "@/desktop/electron/events";
|
import { listenToDesktopEvent } from "@/desktop/electron/events";
|
||||||
import { updateDesktopWindowControls } from "@/desktop/electron/window";
|
import { updateDesktopWindowControls } from "@/desktop/electron/window";
|
||||||
@@ -179,19 +180,18 @@ function PushNotificationRouter() {
|
|||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
const target = globalThis as unknown as EventTarget;
|
|
||||||
const openFromWebClick = (event: Event) => {
|
const openFromWebClick = (event: Event) => {
|
||||||
const customEvent = event as CustomEvent<WebNotificationClickDetail>;
|
const customEvent = event as CustomEvent<WebNotificationClickDetail>;
|
||||||
event.preventDefault();
|
event.preventDefault();
|
||||||
openNotification(customEvent.detail?.data);
|
openNotification(customEvent.detail?.data);
|
||||||
};
|
};
|
||||||
|
|
||||||
target.addEventListener(WEB_NOTIFICATION_CLICK_EVENT, openFromWebClick as EventListener);
|
window.addEventListener(WEB_NOTIFICATION_CLICK_EVENT, openFromWebClick as EventListener);
|
||||||
|
|
||||||
return () => {
|
return () => {
|
||||||
cancelled = true;
|
cancelled = true;
|
||||||
removeDesktopNotificationListener?.();
|
removeDesktopNotificationListener?.();
|
||||||
target.removeEventListener(WEB_NOTIFICATION_CLICK_EVENT, openFromWebClick as EventListener);
|
window.removeEventListener(WEB_NOTIFICATION_CLICK_EVENT, openFromWebClick as EventListener);
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -278,93 +278,45 @@ function HostRuntimeBootstrapProvider({ children }: { children: ReactNode }) {
|
|||||||
|
|
||||||
useEffect(() => {
|
useEffect(() => {
|
||||||
let cancelled = false;
|
let cancelled = false;
|
||||||
let cancelAnyOnline: (() => void) | null = null;
|
let cancelInitialization: (() => void) | null = null;
|
||||||
const shouldManageDesktop = shouldUseDesktopDaemon();
|
const shouldManageDesktop = shouldUseDesktopDaemon();
|
||||||
const store = getHostRuntimeStore();
|
const store = getHostRuntimeStore();
|
||||||
|
|
||||||
const init = async () => {
|
void initializeHostRuntime({
|
||||||
const settings = await loadSettingsFromStorage();
|
shouldManageDesktop,
|
||||||
const isDesktopManaged = shouldManageDesktop && settings.manageBuiltInDaemon;
|
loadSettings: loadSettingsFromStorage,
|
||||||
await store.loadFromStorage();
|
store,
|
||||||
if (isDesktopManaged) {
|
setPhase,
|
||||||
setPhase("starting-daemon");
|
setError,
|
||||||
setError(null);
|
isCancelled: () => cancelled,
|
||||||
|
})
|
||||||
let raceSettled = false;
|
.then((cleanup) => {
|
||||||
|
if (cancelled) {
|
||||||
const anyOnline = store.waitForAnyConnectionOnline();
|
cleanup();
|
||||||
cancelAnyOnline = anyOnline.cancel;
|
return cleanup;
|
||||||
|
|
||||||
const bootstrapPromise = (async (): Promise<
|
|
||||||
{ type: "online" } | { type: "error"; error: string }
|
|
||||||
> => {
|
|
||||||
try {
|
|
||||||
const bootstrapResult = await store.bootstrapDesktop();
|
|
||||||
if (!bootstrapResult.ok) {
|
|
||||||
return { type: "error", error: bootstrapResult.error };
|
|
||||||
}
|
|
||||||
if (!cancelled && !raceSettled) {
|
|
||||||
setPhase("connecting");
|
|
||||||
}
|
|
||||||
await store.addConnectionFromListenAndWaitForOnline({
|
|
||||||
listenAddress: bootstrapResult.listenAddress,
|
|
||||||
serverId: bootstrapResult.serverId,
|
|
||||||
hostname: bootstrapResult.hostname,
|
|
||||||
});
|
|
||||||
return { type: "online" };
|
|
||||||
} catch (err) {
|
|
||||||
return {
|
|
||||||
type: "error",
|
|
||||||
error: err instanceof Error ? err.message : String(err),
|
|
||||||
};
|
|
||||||
}
|
|
||||||
})();
|
|
||||||
|
|
||||||
const result = await Promise.race([
|
|
||||||
anyOnline.promise.then((): { type: "online" } => ({ type: "online" })),
|
|
||||||
bootstrapPromise,
|
|
||||||
]);
|
|
||||||
|
|
||||||
raceSettled = true;
|
|
||||||
anyOnline.cancel();
|
|
||||||
|
|
||||||
if (!cancelled) {
|
|
||||||
if (result.type === "online") {
|
|
||||||
setPhase("online");
|
|
||||||
setError(null);
|
|
||||||
} else {
|
|
||||||
setPhase("error");
|
|
||||||
setError(result.error);
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
} else {
|
cancelInitialization = cleanup;
|
||||||
setPhase("connecting");
|
return cleanup;
|
||||||
setError(null);
|
})
|
||||||
await store.bootstrap({ manageBuiltInDaemon: settings.manageBuiltInDaemon });
|
.catch((bootstrapError) => {
|
||||||
if (!cancelled) {
|
console.error("[HostRuntime] Failed to initialize store", bootstrapError);
|
||||||
setPhase("online");
|
if (cancelled) {
|
||||||
setError(null);
|
return;
|
||||||
}
|
}
|
||||||
}
|
if (shouldManageDesktop) {
|
||||||
};
|
setPhase("error");
|
||||||
|
setError(
|
||||||
void init().catch((bootstrapError) => {
|
bootstrapError instanceof Error ? bootstrapError.message : String(bootstrapError),
|
||||||
console.error("[HostRuntime] Failed to initialize store", bootstrapError);
|
);
|
||||||
if (cancelled) {
|
return;
|
||||||
return;
|
}
|
||||||
}
|
setPhase("online");
|
||||||
if (shouldManageDesktop) {
|
setError(null);
|
||||||
setPhase("error");
|
});
|
||||||
setError(bootstrapError instanceof Error ? bootstrapError.message : String(bootstrapError));
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
setPhase("online");
|
|
||||||
setError(null);
|
|
||||||
});
|
|
||||||
|
|
||||||
return () => {
|
return () => {
|
||||||
cancelled = true;
|
cancelled = true;
|
||||||
cancelAnyOnline?.();
|
cancelInitialization?.();
|
||||||
};
|
};
|
||||||
}, [retryToken]);
|
}, [retryToken]);
|
||||||
|
|
||||||
|
|||||||
@@ -0,0 +1,45 @@
|
|||||||
|
import { describe, expect, it, vi } from "vitest";
|
||||||
|
import { initializeHostRuntime } from "./host-runtime-bootstrap";
|
||||||
|
|
||||||
|
describe("initializeHostRuntime", () => {
|
||||||
|
it("uses effective desktop settings to skip desktop-managed bootstrap when daemon management is disabled", async () => {
|
||||||
|
const loadFromStorage = vi.fn(async () => {});
|
||||||
|
const bootstrap = vi.fn(async () => {});
|
||||||
|
const bootstrapDesktop = vi.fn(async () => ({
|
||||||
|
ok: true as const,
|
||||||
|
listenAddress: "127.0.0.1:6767",
|
||||||
|
serverId: "srv_test",
|
||||||
|
hostname: "test",
|
||||||
|
}));
|
||||||
|
const addConnectionFromListenAndWaitForOnline = vi.fn(async () => {});
|
||||||
|
const setPhase = vi.fn();
|
||||||
|
const setError = vi.fn();
|
||||||
|
|
||||||
|
await initializeHostRuntime({
|
||||||
|
shouldManageDesktop: true,
|
||||||
|
loadSettings: async () => ({
|
||||||
|
theme: "auto",
|
||||||
|
sendBehavior: "interrupt",
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
releaseChannel: "stable",
|
||||||
|
}),
|
||||||
|
store: {
|
||||||
|
loadFromStorage,
|
||||||
|
bootstrap,
|
||||||
|
bootstrapDesktop,
|
||||||
|
addConnectionFromListenAndWaitForOnline,
|
||||||
|
waitForAnyConnectionOnline: () => ({
|
||||||
|
promise: new Promise<{ type: "online" }>(() => {}),
|
||||||
|
cancel: vi.fn(),
|
||||||
|
}),
|
||||||
|
},
|
||||||
|
setPhase,
|
||||||
|
setError,
|
||||||
|
isCancelled: () => false,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(bootstrap).toHaveBeenCalledWith({ manageBuiltInDaemon: false });
|
||||||
|
expect(setPhase).toHaveBeenLastCalledWith("online");
|
||||||
|
expect(setError).toHaveBeenLastCalledWith(null);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,96 @@
|
|||||||
|
import type { HostRuntimeBootstrapResult } from "@/runtime/host-runtime";
|
||||||
|
import type { Settings } from "@/hooks/use-settings";
|
||||||
|
|
||||||
|
type HostRuntimeBootstrapPhase = "starting-daemon" | "connecting" | "online" | "error";
|
||||||
|
|
||||||
|
interface HostRuntimeBootstrapStore {
|
||||||
|
loadFromStorage: () => Promise<void>;
|
||||||
|
bootstrap: (options?: { manageBuiltInDaemon?: boolean }) => Promise<void>;
|
||||||
|
bootstrapDesktop: () => Promise<HostRuntimeBootstrapResult>;
|
||||||
|
addConnectionFromListenAndWaitForOnline: (input: {
|
||||||
|
listenAddress: string;
|
||||||
|
serverId: string;
|
||||||
|
hostname: string | null;
|
||||||
|
}) => Promise<unknown>;
|
||||||
|
waitForAnyConnectionOnline: () => {
|
||||||
|
promise: Promise<unknown>;
|
||||||
|
cancel: () => void;
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function initializeHostRuntime(args: {
|
||||||
|
shouldManageDesktop: boolean;
|
||||||
|
loadSettings: () => Promise<Settings>;
|
||||||
|
store: HostRuntimeBootstrapStore;
|
||||||
|
setPhase: (phase: HostRuntimeBootstrapPhase) => void;
|
||||||
|
setError: (error: string | null) => void;
|
||||||
|
isCancelled: () => boolean;
|
||||||
|
}): Promise<() => void> {
|
||||||
|
const { shouldManageDesktop, loadSettings, store, setPhase, setError, isCancelled } = args;
|
||||||
|
|
||||||
|
const settings = await loadSettings();
|
||||||
|
const isDesktopManaged = shouldManageDesktop && settings.manageBuiltInDaemon;
|
||||||
|
await store.loadFromStorage();
|
||||||
|
|
||||||
|
if (!isDesktopManaged) {
|
||||||
|
setPhase("connecting");
|
||||||
|
setError(null);
|
||||||
|
await store.bootstrap({ manageBuiltInDaemon: settings.manageBuiltInDaemon });
|
||||||
|
if (!isCancelled()) {
|
||||||
|
setPhase("online");
|
||||||
|
setError(null);
|
||||||
|
}
|
||||||
|
return () => {};
|
||||||
|
}
|
||||||
|
|
||||||
|
setPhase("starting-daemon");
|
||||||
|
setError(null);
|
||||||
|
|
||||||
|
const anyOnline = store.waitForAnyConnectionOnline();
|
||||||
|
|
||||||
|
const bootstrapPromise = (async (): Promise<BootstrapOutcome> => {
|
||||||
|
try {
|
||||||
|
const bootstrapResult = await store.bootstrapDesktop();
|
||||||
|
if (!bootstrapResult.ok) {
|
||||||
|
return { type: "error", error: bootstrapResult.error };
|
||||||
|
}
|
||||||
|
if (!isCancelled()) {
|
||||||
|
setPhase("connecting");
|
||||||
|
}
|
||||||
|
await store.addConnectionFromListenAndWaitForOnline({
|
||||||
|
listenAddress: bootstrapResult.listenAddress,
|
||||||
|
serverId: bootstrapResult.serverId,
|
||||||
|
hostname: bootstrapResult.hostname,
|
||||||
|
});
|
||||||
|
return { type: "online" };
|
||||||
|
} catch (error) {
|
||||||
|
return {
|
||||||
|
type: "error",
|
||||||
|
error: error instanceof Error ? error.message : String(error),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
})();
|
||||||
|
|
||||||
|
const onlineFromAny: Promise<BootstrapOutcome> = anyOnline.promise.then(() => ({
|
||||||
|
type: "online",
|
||||||
|
}));
|
||||||
|
const result = await Promise.race([onlineFromAny, bootstrapPromise]);
|
||||||
|
|
||||||
|
anyOnline.cancel();
|
||||||
|
|
||||||
|
if (!isCancelled()) {
|
||||||
|
if (result.type === "online") {
|
||||||
|
setPhase("online");
|
||||||
|
setError(null);
|
||||||
|
} else {
|
||||||
|
setPhase("error");
|
||||||
|
setError(result.error);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return () => {
|
||||||
|
anyOnline.cancel();
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
type BootstrapOutcome = { type: "online" } | { type: "error"; error: string };
|
||||||
@@ -0,0 +1,279 @@
|
|||||||
|
/**
|
||||||
|
* @vitest-environment jsdom
|
||||||
|
*/
|
||||||
|
import { cleanup, fireEvent, render, waitFor } from "@testing-library/react";
|
||||||
|
import React from "react";
|
||||||
|
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
|
||||||
|
import { LocalDaemonSection } from "./desktop-updates-section";
|
||||||
|
|
||||||
|
const { alertMock, confirmDialogMock, settingsState, daemonStatusState } = vi.hoisted(() => ({
|
||||||
|
alertMock: vi.fn(),
|
||||||
|
confirmDialogMock: vi.fn(),
|
||||||
|
settingsState: {
|
||||||
|
settings: {
|
||||||
|
releaseChannel: "stable" as const,
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: true,
|
||||||
|
keepRunningAfterQuit: true,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
updateSettings: vi.fn<
|
||||||
|
(updates: {
|
||||||
|
daemon?: {
|
||||||
|
manageBuiltInDaemon?: boolean;
|
||||||
|
keepRunningAfterQuit?: boolean;
|
||||||
|
};
|
||||||
|
}) => Promise<void>
|
||||||
|
>(),
|
||||||
|
},
|
||||||
|
daemonStatusState: {
|
||||||
|
data: {
|
||||||
|
status: {
|
||||||
|
serverId: "desktop",
|
||||||
|
status: "running" as const,
|
||||||
|
listen: null,
|
||||||
|
hostname: null,
|
||||||
|
pid: 123,
|
||||||
|
home: "/tmp/paseo",
|
||||||
|
version: "1.2.3",
|
||||||
|
desktopManaged: true,
|
||||||
|
error: null,
|
||||||
|
},
|
||||||
|
logs: {
|
||||||
|
logPath: "/tmp/paseo/daemon.log",
|
||||||
|
contents: "daemon log",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
isLoading: false,
|
||||||
|
error: null as string | null,
|
||||||
|
setStatus: vi.fn(),
|
||||||
|
refetch: vi.fn(),
|
||||||
|
},
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("react-native", () => ({
|
||||||
|
ActivityIndicator: () => React.createElement("div", { "data-testid": "loading-spinner" }),
|
||||||
|
Alert: { alert: alertMock },
|
||||||
|
Text: ({ children }: { children?: React.ReactNode }) =>
|
||||||
|
React.createElement("span", null, children),
|
||||||
|
View: ({ children }: { children?: React.ReactNode }) =>
|
||||||
|
React.createElement("div", null, children),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("react-native-unistyles", () => ({
|
||||||
|
StyleSheet: {
|
||||||
|
create: (factory: unknown) =>
|
||||||
|
typeof factory === "function"
|
||||||
|
? (factory as (theme: Record<string, unknown>) => unknown)({
|
||||||
|
spacing: { 1: 4, 2: 8, 3: 12, 6: 24 },
|
||||||
|
borderRadius: { lg: 12 },
|
||||||
|
fontSize: { xs: 12, sm: 14 },
|
||||||
|
colors: {
|
||||||
|
foreground: "#111",
|
||||||
|
foregroundMuted: "#666",
|
||||||
|
palette: { amber: { 500: "#f59e0b" } },
|
||||||
|
},
|
||||||
|
})
|
||||||
|
: factory,
|
||||||
|
},
|
||||||
|
useUnistyles: () => ({
|
||||||
|
theme: {
|
||||||
|
iconSize: { sm: 14 },
|
||||||
|
colors: {
|
||||||
|
foreground: "#111",
|
||||||
|
foregroundMuted: "#666",
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("expo-clipboard", () => ({
|
||||||
|
setStringAsync: vi.fn(() => Promise.resolve()),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("lucide-react-native", () => {
|
||||||
|
const icon = (name: string) => () => React.createElement("span", { "data-icon": name });
|
||||||
|
return {
|
||||||
|
Activity: icon("Activity"),
|
||||||
|
ArrowUpRight: icon("ArrowUpRight"),
|
||||||
|
Copy: icon("Copy"),
|
||||||
|
FileText: icon("FileText"),
|
||||||
|
Pause: icon("Pause"),
|
||||||
|
Play: icon("Play"),
|
||||||
|
RotateCw: icon("RotateCw"),
|
||||||
|
};
|
||||||
|
});
|
||||||
|
|
||||||
|
vi.mock("@/styles/settings", () => ({
|
||||||
|
settingsStyles: new Proxy(
|
||||||
|
{},
|
||||||
|
{
|
||||||
|
get: (_target, prop) => String(prop),
|
||||||
|
},
|
||||||
|
),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/screens/settings/settings-section", () => ({
|
||||||
|
SettingsSection: ({
|
||||||
|
children,
|
||||||
|
title,
|
||||||
|
trailing,
|
||||||
|
}: {
|
||||||
|
children?: React.ReactNode;
|
||||||
|
title: string;
|
||||||
|
trailing?: React.ReactNode;
|
||||||
|
}) =>
|
||||||
|
React.createElement(
|
||||||
|
"section",
|
||||||
|
null,
|
||||||
|
React.createElement("h2", null, title),
|
||||||
|
trailing,
|
||||||
|
children,
|
||||||
|
),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/components/adaptive-modal-sheet", () => ({
|
||||||
|
AdaptiveModalSheet: ({
|
||||||
|
children,
|
||||||
|
visible,
|
||||||
|
title,
|
||||||
|
}: {
|
||||||
|
children?: React.ReactNode;
|
||||||
|
visible?: boolean;
|
||||||
|
title?: string;
|
||||||
|
}) => (visible ? React.createElement("div", { "data-title": title }, children) : null),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/components/ui/button", () => ({
|
||||||
|
Button: ({
|
||||||
|
children,
|
||||||
|
onPress,
|
||||||
|
disabled,
|
||||||
|
accessibilityLabel,
|
||||||
|
}: {
|
||||||
|
children?: React.ReactNode;
|
||||||
|
onPress?: () => void;
|
||||||
|
disabled?: boolean;
|
||||||
|
accessibilityLabel?: string;
|
||||||
|
}) =>
|
||||||
|
React.createElement(
|
||||||
|
"button",
|
||||||
|
{ type: "button", onClick: onPress, disabled, "aria-label": accessibilityLabel },
|
||||||
|
children,
|
||||||
|
),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/desktop/settings/desktop-settings", () => ({
|
||||||
|
useDesktopSettings: () => ({
|
||||||
|
...settingsState,
|
||||||
|
isLoading: false,
|
||||||
|
error: null,
|
||||||
|
}),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/desktop/hooks/use-daemon-status", () => ({
|
||||||
|
useDaemonStatus: () => daemonStatusState,
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/utils/confirm-dialog", () => ({
|
||||||
|
confirmDialog: confirmDialogMock,
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/utils/open-external-url", () => ({
|
||||||
|
openExternalUrl: vi.fn(),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/desktop/updates/desktop-updates", () => ({
|
||||||
|
isVersionMismatch: vi.fn(() => false),
|
||||||
|
}));
|
||||||
|
|
||||||
|
const daemonCommandMocks = vi.hoisted(() => ({
|
||||||
|
getCliDaemonStatusMock: vi.fn(),
|
||||||
|
restartDesktopDaemonMock: vi.fn(),
|
||||||
|
startDesktopDaemonMock: vi.fn(),
|
||||||
|
stopDesktopDaemonMock: vi.fn(),
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/desktop/daemon/desktop-daemon", () => ({
|
||||||
|
getCliDaemonStatus: daemonCommandMocks.getCliDaemonStatusMock,
|
||||||
|
restartDesktopDaemon: daemonCommandMocks.restartDesktopDaemonMock,
|
||||||
|
shouldUseDesktopDaemon: vi.fn(() => true),
|
||||||
|
startDesktopDaemon: daemonCommandMocks.startDesktopDaemonMock,
|
||||||
|
stopDesktopDaemon: daemonCommandMocks.stopDesktopDaemonMock,
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/utils/app-version", () => ({
|
||||||
|
resolveAppVersion: vi.fn(() => "1.2.3"),
|
||||||
|
}));
|
||||||
|
|
||||||
|
describe("LocalDaemonSection", () => {
|
||||||
|
afterEach(() => {
|
||||||
|
cleanup();
|
||||||
|
});
|
||||||
|
|
||||||
|
beforeEach(() => {
|
||||||
|
alertMock.mockReset();
|
||||||
|
confirmDialogMock.mockReset();
|
||||||
|
settingsState.settings.daemon.manageBuiltInDaemon = true;
|
||||||
|
settingsState.settings.daemon.keepRunningAfterQuit = true;
|
||||||
|
settingsState.updateSettings.mockReset();
|
||||||
|
settingsState.updateSettings.mockResolvedValue();
|
||||||
|
daemonStatusState.data.status.status = "running";
|
||||||
|
daemonStatusState.setStatus.mockReset();
|
||||||
|
daemonStatusState.refetch.mockReset();
|
||||||
|
daemonCommandMocks.startDesktopDaemonMock.mockReset();
|
||||||
|
daemonCommandMocks.stopDesktopDaemonMock.mockReset();
|
||||||
|
daemonCommandMocks.stopDesktopDaemonMock.mockResolvedValue({
|
||||||
|
...daemonStatusState.data.status,
|
||||||
|
status: "stopped",
|
||||||
|
});
|
||||||
|
daemonCommandMocks.restartDesktopDaemonMock.mockReset();
|
||||||
|
daemonCommandMocks.getCliDaemonStatusMock.mockReset();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("shows the keep-running-after-quit control enabled by default", () => {
|
||||||
|
const screen = render(<LocalDaemonSection />);
|
||||||
|
|
||||||
|
expect(screen.getByText("Keep daemon running after quit")).toBeTruthy();
|
||||||
|
expect(
|
||||||
|
screen.getByText(
|
||||||
|
"Enabled. The built-in daemon keeps running after you close the desktop app.",
|
||||||
|
),
|
||||||
|
).toBeTruthy();
|
||||||
|
expect(screen.getByRole("button", { name: "Disable" })).toBeTruthy();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("updates keep-running-after-quit without changing daemon lifecycle", async () => {
|
||||||
|
const screen = render(<LocalDaemonSection />);
|
||||||
|
|
||||||
|
fireEvent.click(screen.getByRole("button", { name: "Disable" }));
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(settingsState.updateSettings).toHaveBeenCalledWith({
|
||||||
|
daemon: {
|
||||||
|
keepRunningAfterQuit: false,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
});
|
||||||
|
expect(confirmDialogMock).not.toHaveBeenCalled();
|
||||||
|
expect(daemonCommandMocks.startDesktopDaemonMock).not.toHaveBeenCalled();
|
||||||
|
expect(daemonCommandMocks.stopDesktopDaemonMock).not.toHaveBeenCalled();
|
||||||
|
expect(daemonCommandMocks.restartDesktopDaemonMock).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("pauses built-in daemon management and persists the setting through desktop settings", async () => {
|
||||||
|
confirmDialogMock.mockResolvedValue(true);
|
||||||
|
const screen = render(<LocalDaemonSection />);
|
||||||
|
|
||||||
|
fireEvent.click(screen.getByRole("button", { name: "Pause" }));
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(daemonCommandMocks.stopDesktopDaemonMock).toHaveBeenCalledTimes(1);
|
||||||
|
});
|
||||||
|
expect(settingsState.updateSettings).toHaveBeenCalledWith({
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -1,4 +1,4 @@
|
|||||||
import { useCallback, useMemo, useState } from "react";
|
import React, { type ReactElement, useCallback, useMemo, useState } from "react";
|
||||||
import { ActivityIndicator, Alert, Text, View } from "react-native";
|
import { ActivityIndicator, Alert, Text, View } from "react-native";
|
||||||
import * as Clipboard from "expo-clipboard";
|
import * as Clipboard from "expo-clipboard";
|
||||||
import { StyleSheet, useUnistyles } from "react-native-unistyles";
|
import { StyleSheet, useUnistyles } from "react-native-unistyles";
|
||||||
@@ -7,7 +7,6 @@ import { SettingsSection } from "@/screens/settings/settings-section";
|
|||||||
import { ArrowUpRight, Play, Pause, RotateCw, Copy, FileText, Activity } from "lucide-react-native";
|
import { ArrowUpRight, Play, Pause, RotateCw, Copy, FileText, Activity } from "lucide-react-native";
|
||||||
import { AdaptiveModalSheet } from "@/components/adaptive-modal-sheet";
|
import { AdaptiveModalSheet } from "@/components/adaptive-modal-sheet";
|
||||||
import { Button } from "@/components/ui/button";
|
import { Button } from "@/components/ui/button";
|
||||||
import { useAppSettings } from "@/hooks/use-settings";
|
|
||||||
import { confirmDialog } from "@/utils/confirm-dialog";
|
import { confirmDialog } from "@/utils/confirm-dialog";
|
||||||
import { openExternalUrl } from "@/utils/open-external-url";
|
import { openExternalUrl } from "@/utils/open-external-url";
|
||||||
import { isVersionMismatch } from "@/desktop/updates/desktop-updates";
|
import { isVersionMismatch } from "@/desktop/updates/desktop-updates";
|
||||||
@@ -19,21 +18,25 @@ import {
|
|||||||
stopDesktopDaemon,
|
stopDesktopDaemon,
|
||||||
} from "@/desktop/daemon/desktop-daemon";
|
} from "@/desktop/daemon/desktop-daemon";
|
||||||
import { useDaemonStatus } from "@/desktop/hooks/use-daemon-status";
|
import { useDaemonStatus } from "@/desktop/hooks/use-daemon-status";
|
||||||
|
import { useDesktopSettings, type DesktopSettings } from "@/desktop/settings/desktop-settings";
|
||||||
import type { DesktopDaemonStatus } from "@/desktop/daemon/desktop-daemon";
|
import type { DesktopDaemonStatus } from "@/desktop/daemon/desktop-daemon";
|
||||||
import { resolveAppVersion } from "@/utils/app-version";
|
import { resolveAppVersion } from "@/utils/app-version";
|
||||||
|
|
||||||
function getDaemonManagementButtonLabel(isUpdating: boolean, isPaused: boolean): string {
|
type DesktopDaemonSettings = DesktopSettings["daemon"];
|
||||||
|
|
||||||
|
function managementLabel(isUpdating: boolean, isPaused: boolean): string {
|
||||||
if (isUpdating) return isPaused ? "Resuming..." : "Pausing...";
|
if (isUpdating) return isPaused ? "Resuming..." : "Pausing...";
|
||||||
return isPaused ? "Resume" : "Pause";
|
return isPaused ? "Resume" : "Pause";
|
||||||
}
|
}
|
||||||
|
|
||||||
function getDaemonRestartButtonLabel(
|
function keepRunningLabel(isUpdating: boolean, isEnabled: boolean): string {
|
||||||
isRestarting: boolean,
|
if (isUpdating) return isEnabled ? "Disabling..." : "Enabling...";
|
||||||
daemonStatus: string | undefined,
|
return isEnabled ? "Disable" : "Enable";
|
||||||
actionLabel: string,
|
}
|
||||||
): string {
|
|
||||||
if (!isRestarting) return actionLabel;
|
function restartLabel(isRestarting: boolean, isRunning: boolean, idleLabel: string): string {
|
||||||
return daemonStatus === "running" ? "Restarting..." : "Starting...";
|
if (!isRestarting) return idleLabel;
|
||||||
|
return isRunning ? "Restarting..." : "Starting...";
|
||||||
}
|
}
|
||||||
|
|
||||||
function useDaemonRestartAction(args: {
|
function useDaemonRestartAction(args: {
|
||||||
@@ -109,8 +112,8 @@ function useDaemonRestartAction(args: {
|
|||||||
|
|
||||||
function useDaemonManagementToggle(args: {
|
function useDaemonManagementToggle(args: {
|
||||||
daemonStatus: DesktopDaemonStatus | null;
|
daemonStatus: DesktopDaemonStatus | null;
|
||||||
settings: { manageBuiltInDaemon: boolean };
|
settings: DesktopDaemonSettings;
|
||||||
updateSettings: (next: { manageBuiltInDaemon: boolean }) => Promise<unknown>;
|
updateSettings: (next: Partial<DesktopDaemonSettings>) => Promise<unknown>;
|
||||||
setStatus: (status: DesktopDaemonStatus) => void;
|
setStatus: (status: DesktopDaemonStatus) => void;
|
||||||
setStatusMessage: (message: string | null) => void;
|
setStatusMessage: (message: string | null) => void;
|
||||||
refetch: () => void;
|
refetch: () => void;
|
||||||
@@ -200,6 +203,28 @@ function useDaemonManagementToggle(args: {
|
|||||||
return { isUpdatingDaemonManagement, handleToggleDaemonManagement };
|
return { isUpdatingDaemonManagement, handleToggleDaemonManagement };
|
||||||
}
|
}
|
||||||
|
|
||||||
|
function useKeepRunningAfterQuitToggle(args: {
|
||||||
|
settings: DesktopDaemonSettings;
|
||||||
|
updateSettings: (next: Partial<DesktopDaemonSettings>) => Promise<unknown>;
|
||||||
|
}) {
|
||||||
|
const { settings, updateSettings } = args;
|
||||||
|
const [isUpdatingKeepRunningAfterQuit, setIsUpdatingKeepRunningAfterQuit] = useState(false);
|
||||||
|
|
||||||
|
const handleToggleKeepRunningAfterQuit = useCallback(() => {
|
||||||
|
setIsUpdatingKeepRunningAfterQuit(true);
|
||||||
|
void updateSettings({ keepRunningAfterQuit: !settings.keepRunningAfterQuit })
|
||||||
|
.catch((error) => {
|
||||||
|
console.error("[Settings] Failed to update desktop quit daemon behavior", error);
|
||||||
|
Alert.alert("Error", "Unable to update the desktop quit daemon behavior.");
|
||||||
|
})
|
||||||
|
.finally(() => {
|
||||||
|
setIsUpdatingKeepRunningAfterQuit(false);
|
||||||
|
});
|
||||||
|
}, [settings.keepRunningAfterQuit, updateSettings]);
|
||||||
|
|
||||||
|
return { isUpdatingKeepRunningAfterQuit, handleToggleKeepRunningAfterQuit };
|
||||||
|
}
|
||||||
|
|
||||||
function useDaemonCliStatusModal() {
|
function useDaemonCliStatusModal() {
|
||||||
const [cliStatusOutput, setCliStatusOutput] = useState<string | null>(null);
|
const [cliStatusOutput, setCliStatusOutput] = useState<string | null>(null);
|
||||||
const [isCliStatusModalOpen, setIsCliStatusModalOpen] = useState(false);
|
const [isCliStatusModalOpen, setIsCliStatusModalOpen] = useState(false);
|
||||||
@@ -233,10 +258,6 @@ function useDaemonCliStatusModal() {
|
|||||||
});
|
});
|
||||||
}, [cliStatusOutput]);
|
}, [cliStatusOutput]);
|
||||||
|
|
||||||
const handleRunCliStatus = useCallback(() => {
|
|
||||||
void handleOpenCliStatus();
|
|
||||||
}, [handleOpenCliStatus]);
|
|
||||||
|
|
||||||
const handleCloseCliStatusModal = useCallback(() => setIsCliStatusModalOpen(false), []);
|
const handleCloseCliStatusModal = useCallback(() => setIsCliStatusModalOpen(false), []);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
@@ -244,7 +265,7 @@ function useDaemonCliStatusModal() {
|
|||||||
isCliStatusModalOpen,
|
isCliStatusModalOpen,
|
||||||
isLoadingCliStatus,
|
isLoadingCliStatus,
|
||||||
handleCopyCliStatus,
|
handleCopyCliStatus,
|
||||||
handleRunCliStatus,
|
handleOpenCliStatus,
|
||||||
handleCloseCliStatusModal,
|
handleCloseCliStatusModal,
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
@@ -348,14 +369,17 @@ interface DaemonInfoCardProps {
|
|||||||
daemonStatusStateText: string;
|
daemonStatusStateText: string;
|
||||||
daemonStatusDetailText: string;
|
daemonStatusDetailText: string;
|
||||||
isDaemonManagementPaused: boolean;
|
isDaemonManagementPaused: boolean;
|
||||||
playIcon: React.ReactElement;
|
playIcon: ReactElement;
|
||||||
pauseIcon: React.ReactElement;
|
pauseIcon: ReactElement;
|
||||||
rotateIcon: React.ReactElement;
|
rotateIcon: ReactElement;
|
||||||
copyIcon: React.ReactElement;
|
copyIcon: ReactElement;
|
||||||
fileTextIcon: React.ReactElement;
|
fileTextIcon: ReactElement;
|
||||||
activityIcon: React.ReactElement;
|
activityIcon: ReactElement;
|
||||||
handleToggleDaemonManagement: () => void;
|
handleToggleDaemonManagement: () => void;
|
||||||
isUpdatingDaemonManagement: boolean;
|
isUpdatingDaemonManagement: boolean;
|
||||||
|
keepRunningAfterQuit: boolean;
|
||||||
|
handleToggleKeepRunningAfterQuit: () => void;
|
||||||
|
isUpdatingKeepRunningAfterQuit: boolean;
|
||||||
daemonActionLabel: string;
|
daemonActionLabel: string;
|
||||||
daemonActionMessage: string;
|
daemonActionMessage: string;
|
||||||
statusMessage: string | null;
|
statusMessage: string | null;
|
||||||
@@ -382,6 +406,9 @@ function DaemonInfoCard(props: DaemonInfoCardProps) {
|
|||||||
activityIcon,
|
activityIcon,
|
||||||
handleToggleDaemonManagement,
|
handleToggleDaemonManagement,
|
||||||
isUpdatingDaemonManagement,
|
isUpdatingDaemonManagement,
|
||||||
|
keepRunningAfterQuit,
|
||||||
|
handleToggleKeepRunningAfterQuit,
|
||||||
|
isUpdatingKeepRunningAfterQuit,
|
||||||
daemonActionLabel,
|
daemonActionLabel,
|
||||||
daemonActionMessage,
|
daemonActionMessage,
|
||||||
statusMessage,
|
statusMessage,
|
||||||
@@ -395,6 +422,20 @@ function DaemonInfoCard(props: DaemonInfoCardProps) {
|
|||||||
isLoadingCliStatus,
|
isLoadingCliStatus,
|
||||||
} = props;
|
} = props;
|
||||||
|
|
||||||
|
const managementButtonLabel = managementLabel(
|
||||||
|
isUpdatingDaemonManagement,
|
||||||
|
isDaemonManagementPaused,
|
||||||
|
);
|
||||||
|
const keepRunningButtonLabel = keepRunningLabel(
|
||||||
|
isUpdatingKeepRunningAfterQuit,
|
||||||
|
keepRunningAfterQuit,
|
||||||
|
);
|
||||||
|
const restartButtonLabel = restartLabel(
|
||||||
|
isRestartingDaemon,
|
||||||
|
daemonStatus?.status === "running",
|
||||||
|
daemonActionLabel,
|
||||||
|
);
|
||||||
|
|
||||||
return (
|
return (
|
||||||
<View style={settingsStyles.card}>
|
<View style={settingsStyles.card}>
|
||||||
<View style={settingsStyles.row}>
|
<View style={settingsStyles.row}>
|
||||||
@@ -425,7 +466,25 @@ function DaemonInfoCard(props: DaemonInfoCardProps) {
|
|||||||
onPress={handleToggleDaemonManagement}
|
onPress={handleToggleDaemonManagement}
|
||||||
disabled={isUpdatingDaemonManagement}
|
disabled={isUpdatingDaemonManagement}
|
||||||
>
|
>
|
||||||
{getDaemonManagementButtonLabel(isUpdatingDaemonManagement, isDaemonManagementPaused)}
|
{managementButtonLabel}
|
||||||
|
</Button>
|
||||||
|
</View>
|
||||||
|
<View style={ROW_WITH_BORDER_STYLE}>
|
||||||
|
<View style={settingsStyles.rowContent}>
|
||||||
|
<Text style={settingsStyles.rowTitle}>Keep daemon running after quit</Text>
|
||||||
|
<Text style={settingsStyles.rowHint}>
|
||||||
|
{keepRunningAfterQuit
|
||||||
|
? "Enabled. The built-in daemon keeps running after you close the desktop app."
|
||||||
|
: "Disabled. Quitting the desktop app stops the built-in daemon if desktop management is enabled."}
|
||||||
|
</Text>
|
||||||
|
</View>
|
||||||
|
<Button
|
||||||
|
variant="outline"
|
||||||
|
size="sm"
|
||||||
|
onPress={handleToggleKeepRunningAfterQuit}
|
||||||
|
disabled={isUpdatingKeepRunningAfterQuit}
|
||||||
|
>
|
||||||
|
{keepRunningButtonLabel}
|
||||||
</Button>
|
</Button>
|
||||||
</View>
|
</View>
|
||||||
<View style={ROW_WITH_BORDER_STYLE}>
|
<View style={ROW_WITH_BORDER_STYLE}>
|
||||||
@@ -441,7 +500,7 @@ function DaemonInfoCard(props: DaemonInfoCardProps) {
|
|||||||
onPress={handleUpdateLocalDaemon}
|
onPress={handleUpdateLocalDaemon}
|
||||||
disabled={isRestartingDaemon}
|
disabled={isRestartingDaemon}
|
||||||
>
|
>
|
||||||
{getDaemonRestartButtonLabel(isRestartingDaemon, daemonStatus?.status, daemonActionLabel)}
|
{restartButtonLabel}
|
||||||
</Button>
|
</Button>
|
||||||
</View>
|
</View>
|
||||||
<View style={ROW_WITH_BORDER_STYLE}>
|
<View style={ROW_WITH_BORDER_STYLE}>
|
||||||
@@ -493,7 +552,12 @@ export function LocalDaemonSection() {
|
|||||||
const { theme } = useUnistyles();
|
const { theme } = useUnistyles();
|
||||||
const showSection = shouldUseDesktopDaemon();
|
const showSection = shouldUseDesktopDaemon();
|
||||||
const appVersion = resolveAppVersion();
|
const appVersion = resolveAppVersion();
|
||||||
const { settings, updateSettings } = useAppSettings();
|
const { settings, updateSettings, isLoading: isLoadingSettings } = useDesktopSettings();
|
||||||
|
const daemonSettings = settings.daemon;
|
||||||
|
const updateDaemonSettings = useCallback(
|
||||||
|
(updates: Partial<DesktopDaemonSettings>) => updateSettings({ daemon: updates }),
|
||||||
|
[updateSettings],
|
||||||
|
);
|
||||||
const { data, isLoading, error: statusError, setStatus, refetch } = useDaemonStatus();
|
const { data, isLoading, error: statusError, setStatus, refetch } = useDaemonStatus();
|
||||||
|
|
||||||
const daemonStatus = data?.status ?? null;
|
const daemonStatus = data?.status ?? null;
|
||||||
@@ -504,7 +568,7 @@ export function LocalDaemonSection() {
|
|||||||
const daemonStatusStateText =
|
const daemonStatusStateText =
|
||||||
statusError ?? (daemonStatus?.status === "running" ? daemonStatus.status : "not running");
|
statusError ?? (daemonStatus?.status === "running" ? daemonStatus.status : "not running");
|
||||||
const daemonStatusDetailText = `PID ${daemonStatus?.pid ? daemonStatus.pid : "—"}`;
|
const daemonStatusDetailText = `PID ${daemonStatus?.pid ? daemonStatus.pid : "—"}`;
|
||||||
const isDaemonManagementPaused = !settings.manageBuiltInDaemon;
|
const isDaemonManagementPaused = !daemonSettings.manageBuiltInDaemon;
|
||||||
const daemonActionLabel = daemonStatus?.status === "running" ? "Restart daemon" : "Start daemon";
|
const daemonActionLabel = daemonStatus?.status === "running" ? "Restart daemon" : "Start daemon";
|
||||||
const daemonActionMessage =
|
const daemonActionMessage =
|
||||||
daemonStatus?.status === "running"
|
daemonStatus?.status === "running"
|
||||||
@@ -522,12 +586,17 @@ export function LocalDaemonSection() {
|
|||||||
|
|
||||||
const { isUpdatingDaemonManagement, handleToggleDaemonManagement } = useDaemonManagementToggle({
|
const { isUpdatingDaemonManagement, handleToggleDaemonManagement } = useDaemonManagementToggle({
|
||||||
daemonStatus,
|
daemonStatus,
|
||||||
settings,
|
settings: daemonSettings,
|
||||||
updateSettings,
|
updateSettings: updateDaemonSettings,
|
||||||
setStatus,
|
setStatus,
|
||||||
setStatusMessage,
|
setStatusMessage,
|
||||||
refetch,
|
refetch,
|
||||||
});
|
});
|
||||||
|
const { isUpdatingKeepRunningAfterQuit, handleToggleKeepRunningAfterQuit } =
|
||||||
|
useKeepRunningAfterQuitToggle({
|
||||||
|
settings: daemonSettings,
|
||||||
|
updateSettings: updateDaemonSettings,
|
||||||
|
});
|
||||||
|
|
||||||
const { isLogsModalOpen, handleCopyLogPath, handleOpenLogs, handleCloseLogsModal } =
|
const { isLogsModalOpen, handleCopyLogPath, handleOpenLogs, handleCloseLogsModal } =
|
||||||
useDaemonLogsModal(daemonLogs);
|
useDaemonLogsModal(daemonLogs);
|
||||||
@@ -537,9 +606,12 @@ export function LocalDaemonSection() {
|
|||||||
isCliStatusModalOpen,
|
isCliStatusModalOpen,
|
||||||
isLoadingCliStatus,
|
isLoadingCliStatus,
|
||||||
handleCopyCliStatus,
|
handleCopyCliStatus,
|
||||||
handleRunCliStatus,
|
handleOpenCliStatus,
|
||||||
handleCloseCliStatusModal,
|
handleCloseCliStatusModal,
|
||||||
} = useDaemonCliStatusModal();
|
} = useDaemonCliStatusModal();
|
||||||
|
const handleRunCliStatus = useCallback(() => {
|
||||||
|
void handleOpenCliStatus();
|
||||||
|
}, [handleOpenCliStatus]);
|
||||||
|
|
||||||
const handleOpenAdvancedSettings = useCallback(
|
const handleOpenAdvancedSettings = useCallback(
|
||||||
() => void openExternalUrl(ADVANCED_DAEMON_SETTINGS_URL),
|
() => void openExternalUrl(ADVANCED_DAEMON_SETTINGS_URL),
|
||||||
@@ -602,7 +674,7 @@ export function LocalDaemonSection() {
|
|||||||
trailing={advancedSettingsButton}
|
trailing={advancedSettingsButton}
|
||||||
testID="host-page-daemon-lifecycle-card"
|
testID="host-page-daemon-lifecycle-card"
|
||||||
>
|
>
|
||||||
{isLoading ? (
|
{isLoading || isLoadingSettings ? (
|
||||||
<View style={LOADING_CARD_STYLE}>
|
<View style={LOADING_CARD_STYLE}>
|
||||||
<ActivityIndicator size="small" color={theme.colors.foregroundMuted} />
|
<ActivityIndicator size="small" color={theme.colors.foregroundMuted} />
|
||||||
</View>
|
</View>
|
||||||
@@ -620,6 +692,9 @@ export function LocalDaemonSection() {
|
|||||||
activityIcon={activityIcon}
|
activityIcon={activityIcon}
|
||||||
handleToggleDaemonManagement={handleToggleDaemonManagement}
|
handleToggleDaemonManagement={handleToggleDaemonManagement}
|
||||||
isUpdatingDaemonManagement={isUpdatingDaemonManagement}
|
isUpdatingDaemonManagement={isUpdatingDaemonManagement}
|
||||||
|
keepRunningAfterQuit={daemonSettings.keepRunningAfterQuit}
|
||||||
|
handleToggleKeepRunningAfterQuit={handleToggleKeepRunningAfterQuit}
|
||||||
|
isUpdatingKeepRunningAfterQuit={isUpdatingKeepRunningAfterQuit}
|
||||||
daemonActionLabel={daemonActionLabel}
|
daemonActionLabel={daemonActionLabel}
|
||||||
daemonActionMessage={daemonActionMessage}
|
daemonActionMessage={daemonActionMessage}
|
||||||
statusMessage={statusMessage}
|
statusMessage={statusMessage}
|
||||||
|
|||||||
@@ -0,0 +1,138 @@
|
|||||||
|
import { useCallback } from "react";
|
||||||
|
import { useQuery, useQueryClient } from "@tanstack/react-query";
|
||||||
|
import { getIsElectron } from "@/constants/platform";
|
||||||
|
import { invokeDesktopCommand } from "@/desktop/electron/invoke";
|
||||||
|
import type { ReleaseChannel } from "@/hooks/use-settings";
|
||||||
|
|
||||||
|
export const DESKTOP_SETTINGS_QUERY_KEY = ["desktop-settings"] as const;
|
||||||
|
|
||||||
|
export interface DesktopSettings {
|
||||||
|
releaseChannel: ReleaseChannel;
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: boolean;
|
||||||
|
keepRunningAfterQuit: boolean;
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface DesktopSettingsPatch {
|
||||||
|
releaseChannel?: ReleaseChannel;
|
||||||
|
daemon?: Partial<DesktopSettings["daemon"]>;
|
||||||
|
}
|
||||||
|
|
||||||
|
export const DEFAULT_DESKTOP_SETTINGS: DesktopSettings = {
|
||||||
|
releaseChannel: "stable",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: true,
|
||||||
|
keepRunningAfterQuit: true,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
export function useDesktopSettings(): {
|
||||||
|
settings: DesktopSettings;
|
||||||
|
isLoading: boolean;
|
||||||
|
error: unknown;
|
||||||
|
updateSettings: (updates: DesktopSettingsPatch) => Promise<void>;
|
||||||
|
} {
|
||||||
|
const queryClient = useQueryClient();
|
||||||
|
const { data, isPending, error } = useQuery({
|
||||||
|
queryKey: DESKTOP_SETTINGS_QUERY_KEY,
|
||||||
|
queryFn: loadDesktopSettings,
|
||||||
|
staleTime: Infinity,
|
||||||
|
gcTime: Infinity,
|
||||||
|
});
|
||||||
|
|
||||||
|
const updateSettings = useCallback(
|
||||||
|
async (updates: DesktopSettingsPatch) => {
|
||||||
|
if (!getIsElectron()) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
const previous =
|
||||||
|
queryClient.getQueryData<DesktopSettings>(DESKTOP_SETTINGS_QUERY_KEY) ??
|
||||||
|
DEFAULT_DESKTOP_SETTINGS;
|
||||||
|
const next = mergeDesktopSettings(previous, updates);
|
||||||
|
queryClient.setQueryData<DesktopSettings>(DESKTOP_SETTINGS_QUERY_KEY, next);
|
||||||
|
const persisted = await updatePersistedDesktopSettings(updates);
|
||||||
|
queryClient.setQueryData<DesktopSettings>(DESKTOP_SETTINGS_QUERY_KEY, persisted);
|
||||||
|
},
|
||||||
|
[queryClient],
|
||||||
|
);
|
||||||
|
|
||||||
|
return {
|
||||||
|
settings: data ?? DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
isLoading: isPending,
|
||||||
|
error: error ?? null,
|
||||||
|
updateSettings,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function loadDesktopSettings(): Promise<DesktopSettings> {
|
||||||
|
if (!getIsElectron()) {
|
||||||
|
return DEFAULT_DESKTOP_SETTINGS;
|
||||||
|
}
|
||||||
|
return parseDesktopSettings(await invokeDesktopCommand<unknown>("get_desktop_settings"));
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function updatePersistedDesktopSettings(
|
||||||
|
updates: DesktopSettingsPatch,
|
||||||
|
): Promise<DesktopSettings> {
|
||||||
|
if (!getIsElectron()) {
|
||||||
|
return DEFAULT_DESKTOP_SETTINGS;
|
||||||
|
}
|
||||||
|
return parseDesktopSettings(
|
||||||
|
await invokeDesktopCommand<unknown>("patch_desktop_settings", normalizePatch(updates)),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function migrateLegacyDesktopSettings(input: {
|
||||||
|
manageBuiltInDaemon?: boolean;
|
||||||
|
releaseChannel?: ReleaseChannel;
|
||||||
|
}): Promise<void> {
|
||||||
|
if (!getIsElectron()) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
await invokeDesktopCommand("migrate_legacy_desktop_settings", input);
|
||||||
|
}
|
||||||
|
|
||||||
|
function parseDesktopSettings(raw: unknown): DesktopSettings {
|
||||||
|
const record = isRecord(raw) ? raw : {};
|
||||||
|
const daemon = isRecord(record.daemon) ? record.daemon : {};
|
||||||
|
|
||||||
|
return {
|
||||||
|
releaseChannel: record.releaseChannel === "beta" ? "beta" : "stable",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon:
|
||||||
|
typeof daemon.manageBuiltInDaemon === "boolean"
|
||||||
|
? daemon.manageBuiltInDaemon
|
||||||
|
: DEFAULT_DESKTOP_SETTINGS.daemon.manageBuiltInDaemon,
|
||||||
|
keepRunningAfterQuit:
|
||||||
|
typeof daemon.keepRunningAfterQuit === "boolean"
|
||||||
|
? daemon.keepRunningAfterQuit
|
||||||
|
: DEFAULT_DESKTOP_SETTINGS.daemon.keepRunningAfterQuit,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function mergeDesktopSettings(
|
||||||
|
current: DesktopSettings,
|
||||||
|
updates: DesktopSettingsPatch,
|
||||||
|
): DesktopSettings {
|
||||||
|
return {
|
||||||
|
releaseChannel: updates.releaseChannel ?? current.releaseChannel,
|
||||||
|
daemon: {
|
||||||
|
...current.daemon,
|
||||||
|
...updates.daemon,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function normalizePatch(updates: DesktopSettingsPatch): Record<string, unknown> {
|
||||||
|
return {
|
||||||
|
...(updates.releaseChannel ? { releaseChannel: updates.releaseChannel } : {}),
|
||||||
|
...(updates.daemon ? { daemon: updates.daemon } : {}),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function isRecord(value: unknown): value is Record<string, unknown> {
|
||||||
|
return typeof value === "object" && value !== null && !Array.isArray(value);
|
||||||
|
}
|
||||||
@@ -0,0 +1,71 @@
|
|||||||
|
/**
|
||||||
|
* @vitest-environment jsdom
|
||||||
|
*/
|
||||||
|
import { act, renderHook, waitFor } from "@testing-library/react";
|
||||||
|
import { beforeEach, describe, expect, it, vi } from "vitest";
|
||||||
|
import { useDesktopAppUpdater } from "./use-desktop-app-updater";
|
||||||
|
|
||||||
|
const desktopUpdatesMock = vi.hoisted(() => ({
|
||||||
|
shouldShowDesktopUpdateSection: vi.fn(() => true),
|
||||||
|
checkDesktopAppUpdate: vi.fn(async () => ({
|
||||||
|
hasUpdate: false,
|
||||||
|
readyToInstall: false,
|
||||||
|
latestVersion: null,
|
||||||
|
})),
|
||||||
|
installDesktopAppUpdate: vi.fn(async () => ({
|
||||||
|
installed: false,
|
||||||
|
message: null,
|
||||||
|
})),
|
||||||
|
formatVersionWithPrefix: vi.fn((version: string | null) => version ?? "\u2014"),
|
||||||
|
}));
|
||||||
|
|
||||||
|
const settingsState = vi.hoisted(() => ({
|
||||||
|
releaseChannel: "stable" as "stable" | "beta",
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/desktop/updates/desktop-updates", () => desktopUpdatesMock);
|
||||||
|
|
||||||
|
vi.mock("@/desktop/settings/desktop-settings", () => ({
|
||||||
|
useDesktopSettings: () => ({
|
||||||
|
settings: {
|
||||||
|
releaseChannel: settingsState.releaseChannel,
|
||||||
|
daemon: { manageBuiltInDaemon: true, keepRunningAfterQuit: true },
|
||||||
|
},
|
||||||
|
isLoading: false,
|
||||||
|
error: null,
|
||||||
|
updateSettings: vi.fn(async () => {}),
|
||||||
|
}),
|
||||||
|
}));
|
||||||
|
|
||||||
|
describe("useDesktopAppUpdater", () => {
|
||||||
|
beforeEach(() => {
|
||||||
|
settingsState.releaseChannel = "stable";
|
||||||
|
desktopUpdatesMock.checkDesktopAppUpdate.mockClear();
|
||||||
|
desktopUpdatesMock.installDesktopAppUpdate.mockClear();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("uses the effective desktop release channel when checking for updates", async () => {
|
||||||
|
settingsState.releaseChannel = "beta";
|
||||||
|
|
||||||
|
renderHook(() => useDesktopAppUpdater());
|
||||||
|
|
||||||
|
await waitFor(() => {
|
||||||
|
expect(desktopUpdatesMock.checkDesktopAppUpdate).toHaveBeenCalledWith({
|
||||||
|
releaseChannel: "beta",
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("uses the effective desktop release channel when installing updates", async () => {
|
||||||
|
settingsState.releaseChannel = "beta";
|
||||||
|
const { result } = renderHook(() => useDesktopAppUpdater());
|
||||||
|
|
||||||
|
await act(async () => {
|
||||||
|
await result.current.installUpdate();
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(desktopUpdatesMock.installDesktopAppUpdate).toHaveBeenCalledWith({
|
||||||
|
releaseChannel: "beta",
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -7,7 +7,7 @@ import {
|
|||||||
type DesktopAppUpdateCheckResult,
|
type DesktopAppUpdateCheckResult,
|
||||||
type DesktopAppUpdateInstallResult,
|
type DesktopAppUpdateInstallResult,
|
||||||
} from "@/desktop/updates/desktop-updates";
|
} from "@/desktop/updates/desktop-updates";
|
||||||
import { useAppSettings } from "@/hooks/use-settings";
|
import { useDesktopSettings } from "@/desktop/settings/desktop-settings";
|
||||||
|
|
||||||
export type DesktopAppUpdateStatus =
|
export type DesktopAppUpdateStatus =
|
||||||
| "idle"
|
| "idle"
|
||||||
@@ -84,8 +84,8 @@ function formatStatusText(input: {
|
|||||||
|
|
||||||
export function useDesktopAppUpdater(): UseDesktopAppUpdaterReturn {
|
export function useDesktopAppUpdater(): UseDesktopAppUpdaterReturn {
|
||||||
const isDesktopApp = shouldShowDesktopUpdateSection();
|
const isDesktopApp = shouldShowDesktopUpdateSection();
|
||||||
const { settings } = useAppSettings();
|
const { settings: desktopSettings } = useDesktopSettings();
|
||||||
const releaseChannel = settings.releaseChannel;
|
const releaseChannel = desktopSettings.releaseChannel;
|
||||||
const requestVersionRef = useRef(0);
|
const requestVersionRef = useRef(0);
|
||||||
const [status, setStatus] = useState<DesktopAppUpdateStatus>("idle");
|
const [status, setStatus] = useState<DesktopAppUpdateStatus>("idle");
|
||||||
const [availableUpdate, setAvailableUpdate] = useState<DesktopAppUpdateCheckResult | null>(null);
|
const [availableUpdate, setAvailableUpdate] = useState<DesktopAppUpdateCheckResult | null>(null);
|
||||||
|
|||||||
@@ -5,15 +5,33 @@ const asyncStorageMock = vi.hoisted(() => ({
|
|||||||
setItem: vi.fn<(_: string, __: string) => Promise<void>>(),
|
setItem: vi.fn<(_: string, __: string) => Promise<void>>(),
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
const electronRuntimeState = vi.hoisted(() => ({
|
||||||
|
isElectron: false,
|
||||||
|
}));
|
||||||
|
|
||||||
|
const desktopSettingsMock = vi.hoisted(() => ({
|
||||||
|
loadDesktopSettings: vi.fn<() => Promise<unknown>>(),
|
||||||
|
migrateLegacyDesktopSettings: vi.fn<(_: unknown) => Promise<void>>(),
|
||||||
|
}));
|
||||||
|
|
||||||
vi.mock("@react-native-async-storage/async-storage", () => ({
|
vi.mock("@react-native-async-storage/async-storage", () => ({
|
||||||
default: asyncStorageMock,
|
default: asyncStorageMock,
|
||||||
}));
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/desktop/host", () => ({
|
||||||
|
isElectronRuntime: () => electronRuntimeState.isElectron,
|
||||||
|
}));
|
||||||
|
|
||||||
|
vi.mock("@/desktop/settings/desktop-settings", () => desktopSettingsMock);
|
||||||
|
|
||||||
describe("use-settings", () => {
|
describe("use-settings", () => {
|
||||||
beforeEach(() => {
|
beforeEach(() => {
|
||||||
vi.resetModules();
|
vi.resetModules();
|
||||||
asyncStorageMock.getItem.mockReset();
|
asyncStorageMock.getItem.mockReset();
|
||||||
asyncStorageMock.setItem.mockReset();
|
asyncStorageMock.setItem.mockReset();
|
||||||
|
electronRuntimeState.isElectron = false;
|
||||||
|
desktopSettingsMock.loadDesktopSettings.mockReset();
|
||||||
|
desktopSettingsMock.migrateLegacyDesktopSettings.mockReset();
|
||||||
});
|
});
|
||||||
|
|
||||||
it("defaults built-in daemon management to enabled when storage is empty", async () => {
|
it("defaults built-in daemon management to enabled when storage is empty", async () => {
|
||||||
@@ -26,7 +44,7 @@ describe("use-settings", () => {
|
|||||||
expect(result).toEqual(mod.DEFAULT_APP_SETTINGS);
|
expect(result).toEqual(mod.DEFAULT_APP_SETTINGS);
|
||||||
expect(asyncStorageMock.setItem).toHaveBeenCalledWith(
|
expect(asyncStorageMock.setItem).toHaveBeenCalledWith(
|
||||||
mod.APP_SETTINGS_KEY,
|
mod.APP_SETTINGS_KEY,
|
||||||
JSON.stringify(mod.DEFAULT_APP_SETTINGS),
|
JSON.stringify(mod.DEFAULT_CLIENT_SETTINGS),
|
||||||
);
|
);
|
||||||
});
|
});
|
||||||
|
|
||||||
@@ -50,7 +68,7 @@ describe("use-settings", () => {
|
|||||||
expect(result.releaseChannel).toBe("stable");
|
expect(result.releaseChannel).toBe("stable");
|
||||||
});
|
});
|
||||||
|
|
||||||
it("loads persisted built-in daemon management state", async () => {
|
it("ignores renderer-owned daemon management state outside Electron", async () => {
|
||||||
asyncStorageMock.getItem.mockImplementation(async (key: string) => {
|
asyncStorageMock.getItem.mockImplementation(async (key: string) => {
|
||||||
if (key === "@paseo:app-settings") {
|
if (key === "@paseo:app-settings") {
|
||||||
return JSON.stringify({
|
return JSON.stringify({
|
||||||
@@ -66,14 +84,13 @@ describe("use-settings", () => {
|
|||||||
|
|
||||||
expect(result).toEqual({
|
expect(result).toEqual({
|
||||||
theme: "light",
|
theme: "light",
|
||||||
manageBuiltInDaemon: false,
|
manageBuiltInDaemon: true,
|
||||||
sendBehavior: "interrupt",
|
sendBehavior: "interrupt",
|
||||||
releaseChannel: "stable",
|
releaseChannel: "stable",
|
||||||
});
|
});
|
||||||
expect(asyncStorageMock.setItem).not.toHaveBeenCalled();
|
|
||||||
});
|
});
|
||||||
|
|
||||||
it("loads persisted beta release channel", async () => {
|
it("ignores renderer-owned release channel outside Electron", async () => {
|
||||||
asyncStorageMock.getItem.mockImplementation(async (key: string) => {
|
asyncStorageMock.getItem.mockImplementation(async (key: string) => {
|
||||||
if (key === "@paseo:app-settings") {
|
if (key === "@paseo:app-settings") {
|
||||||
return JSON.stringify({
|
return JSON.stringify({
|
||||||
@@ -86,6 +103,89 @@ describe("use-settings", () => {
|
|||||||
const mod = await import("./use-settings");
|
const mod = await import("./use-settings");
|
||||||
const result = await mod.loadSettingsFromStorage();
|
const result = await mod.loadSettingsFromStorage();
|
||||||
|
|
||||||
expect(result.releaseChannel).toBe("beta");
|
expect(result.releaseChannel).toBe("stable");
|
||||||
|
});
|
||||||
|
|
||||||
|
it("keeps legacy AsyncStorage migration for client settings only", async () => {
|
||||||
|
asyncStorageMock.getItem.mockImplementation(async (key: string) => {
|
||||||
|
if (key === "@paseo:app-settings") {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
if (key === "@paseo:settings") {
|
||||||
|
return JSON.stringify({
|
||||||
|
theme: "dark",
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
releaseChannel: "beta",
|
||||||
|
});
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
});
|
||||||
|
asyncStorageMock.setItem.mockResolvedValue();
|
||||||
|
|
||||||
|
const mod = await import("./use-settings");
|
||||||
|
const result = await mod.loadAppSettingsFromStorage();
|
||||||
|
|
||||||
|
expect(result).toEqual({
|
||||||
|
theme: "dark",
|
||||||
|
sendBehavior: "interrupt",
|
||||||
|
});
|
||||||
|
expect(asyncStorageMock.setItem).toHaveBeenCalledWith(
|
||||||
|
mod.APP_SETTINGS_KEY,
|
||||||
|
JSON.stringify(result),
|
||||||
|
);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("migrates legacy desktop-owned settings through Electron before reading effective settings", async () => {
|
||||||
|
electronRuntimeState.isElectron = true;
|
||||||
|
asyncStorageMock.getItem.mockImplementation(async (key: string) => {
|
||||||
|
if (key === "@paseo:app-settings") {
|
||||||
|
return JSON.stringify({
|
||||||
|
theme: "light",
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
releaseChannel: "beta",
|
||||||
|
});
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
});
|
||||||
|
desktopSettingsMock.migrateLegacyDesktopSettings.mockResolvedValue();
|
||||||
|
desktopSettingsMock.loadDesktopSettings.mockResolvedValue({
|
||||||
|
releaseChannel: "beta",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
keepRunningAfterQuit: true,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
const mod = await import("./use-settings");
|
||||||
|
const result = await mod.loadSettingsFromStorage();
|
||||||
|
|
||||||
|
expect(desktopSettingsMock.migrateLegacyDesktopSettings).toHaveBeenCalledWith({
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
releaseChannel: "beta",
|
||||||
|
});
|
||||||
|
expect(result).toEqual({
|
||||||
|
theme: "light",
|
||||||
|
sendBehavior: "interrupt",
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
releaseChannel: "beta",
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("skips desktop IPC when loading effective settings outside Electron", async () => {
|
||||||
|
asyncStorageMock.getItem.mockResolvedValue(
|
||||||
|
JSON.stringify({
|
||||||
|
theme: "light",
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
|
||||||
|
const mod = await import("./use-settings");
|
||||||
|
const result = await mod.loadSettingsFromStorage();
|
||||||
|
|
||||||
|
expect(result).toEqual({
|
||||||
|
theme: "light",
|
||||||
|
sendBehavior: "interrupt",
|
||||||
|
manageBuiltInDaemon: true,
|
||||||
|
releaseChannel: "stable",
|
||||||
|
});
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|||||||
@@ -1,46 +1,66 @@
|
|||||||
import { useCallback } from "react";
|
import { useCallback } from "react";
|
||||||
import AsyncStorage from "@react-native-async-storage/async-storage";
|
import AsyncStorage from "@react-native-async-storage/async-storage";
|
||||||
import { useQuery, useQueryClient } from "@tanstack/react-query";
|
import { useQuery, useQueryClient } from "@tanstack/react-query";
|
||||||
|
import {
|
||||||
|
DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
loadDesktopSettings,
|
||||||
|
migrateLegacyDesktopSettings,
|
||||||
|
useDesktopSettings,
|
||||||
|
} from "@/desktop/settings/desktop-settings";
|
||||||
|
import { isElectronRuntime } from "@/desktop/host";
|
||||||
|
import { THEME_TO_UNISTYLES, type ThemeName } from "@/styles/theme";
|
||||||
|
|
||||||
export const APP_SETTINGS_KEY = "@paseo:app-settings";
|
export const APP_SETTINGS_KEY = "@paseo:app-settings";
|
||||||
const LEGACY_SETTINGS_KEY = "@paseo:settings";
|
const LEGACY_SETTINGS_KEY = "@paseo:settings";
|
||||||
const APP_SETTINGS_QUERY_KEY = ["app-settings"];
|
const APP_SETTINGS_QUERY_KEY = ["app-settings"];
|
||||||
|
|
||||||
import { THEME_TO_UNISTYLES, type ThemeName } from "@/styles/theme";
|
|
||||||
|
|
||||||
export type SendBehavior = "interrupt" | "queue";
|
export type SendBehavior = "interrupt" | "queue";
|
||||||
export type ReleaseChannel = "stable" | "beta";
|
export type ReleaseChannel = "stable" | "beta";
|
||||||
|
|
||||||
const VALID_THEMES = new Set<string>([...Object.keys(THEME_TO_UNISTYLES), "auto"]);
|
const VALID_THEMES = new Set<string>([...Object.keys(THEME_TO_UNISTYLES), "auto"]);
|
||||||
const VALID_RELEASE_CHANNELS = new Set<string>(["stable", "beta"]);
|
|
||||||
|
|
||||||
export interface AppSettings {
|
export interface AppSettings {
|
||||||
theme: ThemeName | "auto";
|
theme: ThemeName | "auto";
|
||||||
manageBuiltInDaemon: boolean;
|
|
||||||
sendBehavior: SendBehavior;
|
sendBehavior: SendBehavior;
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface Settings extends AppSettings {
|
||||||
|
manageBuiltInDaemon: boolean;
|
||||||
releaseChannel: ReleaseChannel;
|
releaseChannel: ReleaseChannel;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const DEFAULT_APP_SETTINGS: AppSettings = {
|
export const DEFAULT_CLIENT_SETTINGS: AppSettings = {
|
||||||
theme: "auto",
|
theme: "auto",
|
||||||
manageBuiltInDaemon: true,
|
|
||||||
sendBehavior: "interrupt",
|
sendBehavior: "interrupt",
|
||||||
|
};
|
||||||
|
|
||||||
|
export const DEFAULT_APP_SETTINGS: Settings = {
|
||||||
|
...DEFAULT_CLIENT_SETTINGS,
|
||||||
|
manageBuiltInDaemon: true,
|
||||||
releaseChannel: "stable",
|
releaseChannel: "stable",
|
||||||
};
|
};
|
||||||
|
|
||||||
export interface UseAppSettingsReturn {
|
export interface UseAppSettingsReturn {
|
||||||
settings: AppSettings;
|
settings: AppSettings;
|
||||||
isLoading: boolean;
|
isLoading: boolean;
|
||||||
error: unknown | null;
|
error: unknown;
|
||||||
updateSettings: (updates: Partial<AppSettings>) => Promise<void>;
|
updateSettings: (updates: Partial<AppSettings>) => Promise<void>;
|
||||||
resetSettings: () => Promise<void>;
|
resetSettings: () => Promise<void>;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export interface UseSettingsReturn {
|
||||||
|
settings: Settings;
|
||||||
|
isLoading: boolean;
|
||||||
|
error: unknown;
|
||||||
|
updateSettings: (updates: Partial<Settings>) => Promise<void>;
|
||||||
|
resetSettings: () => Promise<void>;
|
||||||
|
}
|
||||||
|
|
||||||
export function useAppSettings(): UseAppSettingsReturn {
|
export function useAppSettings(): UseAppSettingsReturn {
|
||||||
const queryClient = useQueryClient();
|
const queryClient = useQueryClient();
|
||||||
const { data, isPending, error } = useQuery({
|
const { data, isPending, error } = useQuery({
|
||||||
queryKey: APP_SETTINGS_QUERY_KEY,
|
queryKey: APP_SETTINGS_QUERY_KEY,
|
||||||
queryFn: loadSettingsFromStorage,
|
queryFn: loadAppSettingsFromStorage,
|
||||||
staleTime: Infinity,
|
staleTime: Infinity,
|
||||||
gcTime: Infinity,
|
gcTime: Infinity,
|
||||||
});
|
});
|
||||||
@@ -49,7 +69,7 @@ export function useAppSettings(): UseAppSettingsReturn {
|
|||||||
async (updates: Partial<AppSettings>) => {
|
async (updates: Partial<AppSettings>) => {
|
||||||
try {
|
try {
|
||||||
const prev =
|
const prev =
|
||||||
queryClient.getQueryData<AppSettings>(APP_SETTINGS_QUERY_KEY) ?? DEFAULT_APP_SETTINGS;
|
queryClient.getQueryData<AppSettings>(APP_SETTINGS_QUERY_KEY) ?? DEFAULT_CLIENT_SETTINGS;
|
||||||
const next = { ...prev, ...updates };
|
const next = { ...prev, ...updates };
|
||||||
queryClient.setQueryData<AppSettings>(APP_SETTINGS_QUERY_KEY, next);
|
queryClient.setQueryData<AppSettings>(APP_SETTINGS_QUERY_KEY, next);
|
||||||
await AsyncStorage.setItem(APP_SETTINGS_KEY, JSON.stringify(next));
|
await AsyncStorage.setItem(APP_SETTINGS_KEY, JSON.stringify(next));
|
||||||
@@ -63,7 +83,7 @@ export function useAppSettings(): UseAppSettingsReturn {
|
|||||||
|
|
||||||
const resetSettings = useCallback(async () => {
|
const resetSettings = useCallback(async () => {
|
||||||
try {
|
try {
|
||||||
const next = { ...DEFAULT_APP_SETTINGS };
|
const next = { ...DEFAULT_CLIENT_SETTINGS };
|
||||||
queryClient.setQueryData<AppSettings>(APP_SETTINGS_QUERY_KEY, next);
|
queryClient.setQueryData<AppSettings>(APP_SETTINGS_QUERY_KEY, next);
|
||||||
await AsyncStorage.setItem(APP_SETTINGS_KEY, JSON.stringify(next));
|
await AsyncStorage.setItem(APP_SETTINGS_KEY, JSON.stringify(next));
|
||||||
} catch (err) {
|
} catch (err) {
|
||||||
@@ -73,7 +93,7 @@ export function useAppSettings(): UseAppSettingsReturn {
|
|||||||
}, [queryClient]);
|
}, [queryClient]);
|
||||||
|
|
||||||
return {
|
return {
|
||||||
settings: data ?? DEFAULT_APP_SETTINGS,
|
settings: data ?? DEFAULT_CLIENT_SETTINGS,
|
||||||
isLoading: isPending,
|
isLoading: isPending,
|
||||||
error: error ?? null,
|
error: error ?? null,
|
||||||
updateSettings,
|
updateSettings,
|
||||||
@@ -81,51 +101,172 @@ export function useAppSettings(): UseAppSettingsReturn {
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
export async function loadSettingsFromStorage(): Promise<AppSettings> {
|
export function useSettings(): UseSettingsReturn {
|
||||||
|
const appSettings = useAppSettings();
|
||||||
|
const desktopSettings = useDesktopSettings();
|
||||||
|
|
||||||
|
const updateSettings = useCallback(
|
||||||
|
async (updates: Partial<Settings>) => {
|
||||||
|
const appUpdates: Partial<AppSettings> = {};
|
||||||
|
if (updates.theme !== undefined) {
|
||||||
|
appUpdates.theme = updates.theme;
|
||||||
|
}
|
||||||
|
if (updates.sendBehavior !== undefined) {
|
||||||
|
appUpdates.sendBehavior = updates.sendBehavior;
|
||||||
|
}
|
||||||
|
|
||||||
|
const promises: Promise<void>[] = [];
|
||||||
|
if (Object.keys(appUpdates).length > 0) {
|
||||||
|
promises.push(appSettings.updateSettings(appUpdates));
|
||||||
|
}
|
||||||
|
|
||||||
|
if (isElectronRuntime()) {
|
||||||
|
const desktopUpdates: Parameters<typeof desktopSettings.updateSettings>[0] = {};
|
||||||
|
if (updates.manageBuiltInDaemon !== undefined) {
|
||||||
|
desktopUpdates.daemon = {
|
||||||
|
manageBuiltInDaemon: updates.manageBuiltInDaemon,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
if (updates.releaseChannel !== undefined) {
|
||||||
|
desktopUpdates.releaseChannel = updates.releaseChannel;
|
||||||
|
}
|
||||||
|
if (Object.keys(desktopUpdates).length > 0) {
|
||||||
|
promises.push(desktopSettings.updateSettings(desktopUpdates));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
await Promise.all(promises);
|
||||||
|
},
|
||||||
|
[appSettings, desktopSettings],
|
||||||
|
);
|
||||||
|
|
||||||
|
const resetSettings = useCallback(async () => {
|
||||||
|
const resets: Promise<void>[] = [appSettings.resetSettings()];
|
||||||
|
if (isElectronRuntime()) {
|
||||||
|
resets.push(desktopSettings.updateSettings(DEFAULT_DESKTOP_SETTINGS));
|
||||||
|
}
|
||||||
|
await Promise.all(resets);
|
||||||
|
}, [appSettings, desktopSettings]);
|
||||||
|
|
||||||
|
return {
|
||||||
|
settings: {
|
||||||
|
...DEFAULT_APP_SETTINGS,
|
||||||
|
...appSettings.settings,
|
||||||
|
manageBuiltInDaemon: desktopSettings.settings.daemon.manageBuiltInDaemon,
|
||||||
|
releaseChannel: desktopSettings.settings.releaseChannel,
|
||||||
|
},
|
||||||
|
isLoading: appSettings.isLoading || desktopSettings.isLoading,
|
||||||
|
error: appSettings.error ?? desktopSettings.error,
|
||||||
|
updateSettings,
|
||||||
|
resetSettings,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function loadAppSettingsFromStorage(): Promise<AppSettings> {
|
||||||
try {
|
try {
|
||||||
const stored = await AsyncStorage.getItem(APP_SETTINGS_KEY);
|
const stored = await AsyncStorage.getItem(APP_SETTINGS_KEY);
|
||||||
if (stored) {
|
if (stored) {
|
||||||
const parsed = JSON.parse(stored) as Partial<AppSettings>;
|
const parsed = JSON.parse(stored) as Partial<AppSettings>;
|
||||||
if (parsed.theme && !VALID_THEMES.has(parsed.theme)) {
|
return { ...DEFAULT_CLIENT_SETTINGS, ...pickAppSettings(parsed) };
|
||||||
parsed.theme = DEFAULT_APP_SETTINGS.theme;
|
|
||||||
}
|
|
||||||
if (parsed.releaseChannel && !VALID_RELEASE_CHANNELS.has(parsed.releaseChannel)) {
|
|
||||||
parsed.releaseChannel = DEFAULT_APP_SETTINGS.releaseChannel;
|
|
||||||
}
|
|
||||||
return { ...DEFAULT_APP_SETTINGS, ...parsed };
|
|
||||||
}
|
}
|
||||||
|
|
||||||
const legacyStored = await AsyncStorage.getItem(LEGACY_SETTINGS_KEY);
|
const legacyStored = await AsyncStorage.getItem(LEGACY_SETTINGS_KEY);
|
||||||
if (legacyStored) {
|
if (legacyStored) {
|
||||||
const legacyParsed = JSON.parse(legacyStored) as Record<string, unknown>;
|
const legacyParsed = JSON.parse(legacyStored) as Record<string, unknown>;
|
||||||
const next = {
|
const next = {
|
||||||
...DEFAULT_APP_SETTINGS,
|
...DEFAULT_CLIENT_SETTINGS,
|
||||||
...pickAppSettingsFromLegacy(legacyParsed),
|
...pickAppSettingsFromLegacy(legacyParsed),
|
||||||
} satisfies AppSettings;
|
} satisfies AppSettings;
|
||||||
await AsyncStorage.setItem(APP_SETTINGS_KEY, JSON.stringify(next));
|
await AsyncStorage.setItem(APP_SETTINGS_KEY, JSON.stringify(next));
|
||||||
return next;
|
return next;
|
||||||
}
|
}
|
||||||
|
|
||||||
await AsyncStorage.setItem(APP_SETTINGS_KEY, JSON.stringify(DEFAULT_APP_SETTINGS));
|
await AsyncStorage.setItem(APP_SETTINGS_KEY, JSON.stringify(DEFAULT_CLIENT_SETTINGS));
|
||||||
return DEFAULT_APP_SETTINGS;
|
return DEFAULT_CLIENT_SETTINGS;
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error("[AppSettings] Failed to load settings:", error);
|
console.error("[AppSettings] Failed to load settings:", error);
|
||||||
throw error;
|
throw error;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
export async function loadSettingsFromStorage(): Promise<Settings> {
|
||||||
|
const legacyDesktopSettings = isElectronRuntime()
|
||||||
|
? await loadLegacyDesktopSettingsFromStorage()
|
||||||
|
: null;
|
||||||
|
const appSettings = await loadAppSettingsFromStorage();
|
||||||
|
|
||||||
|
if (!isElectronRuntime()) {
|
||||||
|
return {
|
||||||
|
...DEFAULT_APP_SETTINGS,
|
||||||
|
...appSettings,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
if (legacyDesktopSettings) {
|
||||||
|
await migrateLegacyDesktopSettings(legacyDesktopSettings);
|
||||||
|
}
|
||||||
|
|
||||||
|
const desktopSettings = await loadDesktopSettings();
|
||||||
|
return {
|
||||||
|
...DEFAULT_APP_SETTINGS,
|
||||||
|
...appSettings,
|
||||||
|
manageBuiltInDaemon: desktopSettings.daemon.manageBuiltInDaemon,
|
||||||
|
releaseChannel: desktopSettings.releaseChannel,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function pickAppSettings(stored: Partial<AppSettings>): Partial<AppSettings> {
|
||||||
|
const result: Partial<AppSettings> = {};
|
||||||
|
if (typeof stored.theme === "string" && VALID_THEMES.has(stored.theme)) {
|
||||||
|
result.theme = stored.theme as AppSettings["theme"];
|
||||||
|
}
|
||||||
|
if (stored.sendBehavior === "interrupt" || stored.sendBehavior === "queue") {
|
||||||
|
result.sendBehavior = stored.sendBehavior;
|
||||||
|
}
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
function pickAppSettingsFromLegacy(legacy: Record<string, unknown>): Partial<AppSettings> {
|
function pickAppSettingsFromLegacy(legacy: Record<string, unknown>): Partial<AppSettings> {
|
||||||
const result: Partial<AppSettings> = {};
|
const result: Partial<AppSettings> = {};
|
||||||
if (legacy.theme === "dark" || legacy.theme === "light" || legacy.theme === "auto") {
|
if (legacy.theme === "dark" || legacy.theme === "light" || legacy.theme === "auto") {
|
||||||
result.theme = legacy.theme;
|
result.theme = legacy.theme;
|
||||||
}
|
}
|
||||||
if (typeof legacy.manageBuiltInDaemon === "boolean") {
|
|
||||||
result.manageBuiltInDaemon = legacy.manageBuiltInDaemon;
|
|
||||||
}
|
|
||||||
if (legacy.releaseChannel === "stable" || legacy.releaseChannel === "beta") {
|
|
||||||
result.releaseChannel = legacy.releaseChannel;
|
|
||||||
}
|
|
||||||
return result;
|
return result;
|
||||||
}
|
}
|
||||||
|
|
||||||
export const useSettings = useAppSettings;
|
async function loadLegacyDesktopSettingsFromStorage(): Promise<{
|
||||||
|
manageBuiltInDaemon?: boolean;
|
||||||
|
releaseChannel?: ReleaseChannel;
|
||||||
|
} | null> {
|
||||||
|
const stored = await loadRendererSettingsPayload();
|
||||||
|
if (!stored) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
const result: {
|
||||||
|
manageBuiltInDaemon?: boolean;
|
||||||
|
releaseChannel?: ReleaseChannel;
|
||||||
|
} = {};
|
||||||
|
|
||||||
|
if (typeof stored.manageBuiltInDaemon === "boolean") {
|
||||||
|
result.manageBuiltInDaemon = stored.manageBuiltInDaemon;
|
||||||
|
}
|
||||||
|
if (stored.releaseChannel === "stable" || stored.releaseChannel === "beta") {
|
||||||
|
result.releaseChannel = stored.releaseChannel;
|
||||||
|
}
|
||||||
|
|
||||||
|
return Object.keys(result).length > 0 ? result : null;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function loadRendererSettingsPayload(): Promise<Record<string, unknown> | null> {
|
||||||
|
const current = await AsyncStorage.getItem(APP_SETTINGS_KEY);
|
||||||
|
if (current) {
|
||||||
|
return JSON.parse(current) as Record<string, unknown>;
|
||||||
|
}
|
||||||
|
|
||||||
|
const legacy = await AsyncStorage.getItem(LEGACY_SETTINGS_KEY);
|
||||||
|
if (!legacy) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
return JSON.parse(legacy) as Record<string, unknown>;
|
||||||
|
}
|
||||||
|
|||||||
@@ -33,7 +33,13 @@ import { SidebarSeparator } from "@/components/sidebar/sidebar-separator";
|
|||||||
import { ScreenTitle } from "@/components/headers/screen-title";
|
import { ScreenTitle } from "@/components/headers/screen-title";
|
||||||
import { HeaderIconBadge } from "@/components/headers/header-icon-badge";
|
import { HeaderIconBadge } from "@/components/headers/header-icon-badge";
|
||||||
import { SettingsSection } from "@/screens/settings/settings-section";
|
import { SettingsSection } from "@/screens/settings/settings-section";
|
||||||
import { useAppSettings, type AppSettings, type SendBehavior } from "@/hooks/use-settings";
|
import {
|
||||||
|
useAppSettings,
|
||||||
|
useSettings,
|
||||||
|
type AppSettings,
|
||||||
|
type SendBehavior,
|
||||||
|
type Settings as EffectiveSettings,
|
||||||
|
} from "@/hooks/use-settings";
|
||||||
import { THEME_SWATCHES } from "@/styles/theme";
|
import { THEME_SWATCHES } from "@/styles/theme";
|
||||||
import { getHostRuntimeStore, isHostRuntimeConnected, useHosts } from "@/runtime/host-runtime";
|
import { getHostRuntimeStore, isHostRuntimeConnected, useHosts } from "@/runtime/host-runtime";
|
||||||
import { TitlebarDragRegion } from "@/components/desktop/titlebar-drag-region";
|
import { TitlebarDragRegion } from "@/components/desktop/titlebar-drag-region";
|
||||||
@@ -354,7 +360,7 @@ function getUpdateButtonLabel(
|
|||||||
}
|
}
|
||||||
|
|
||||||
function DesktopAppUpdateRow() {
|
function DesktopAppUpdateRow() {
|
||||||
const { settings, updateSettings } = useAppSettings();
|
const { settings, updateSettings } = useSettings();
|
||||||
const {
|
const {
|
||||||
isDesktopApp,
|
isDesktopApp,
|
||||||
statusText,
|
statusText,
|
||||||
@@ -384,7 +390,7 @@ function DesktopAppUpdateRow() {
|
|||||||
}, [checkForUpdates, isDesktopApp]);
|
}, [checkForUpdates, isDesktopApp]);
|
||||||
|
|
||||||
const handleReleaseChannelChange = useCallback(
|
const handleReleaseChannelChange = useCallback(
|
||||||
(releaseChannel: AppSettings["releaseChannel"]) => {
|
(releaseChannel: EffectiveSettings["releaseChannel"]) => {
|
||||||
void updateSettings({ releaseChannel });
|
void updateSettings({ releaseChannel });
|
||||||
},
|
},
|
||||||
[updateSettings],
|
[updateSettings],
|
||||||
|
|||||||
@@ -33,6 +33,11 @@ import {
|
|||||||
runCliJsonCommand,
|
runCliJsonCommand,
|
||||||
runCliTextCommand,
|
runCliTextCommand,
|
||||||
} from "./runtime-paths.js";
|
} from "./runtime-paths.js";
|
||||||
|
import {
|
||||||
|
createDesktopSettingsCommandHandlers,
|
||||||
|
type DesktopCommandHandler,
|
||||||
|
} from "../settings/desktop-settings-commands.js";
|
||||||
|
import { getDesktopSettingsStore } from "../settings/desktop-settings-electron.js";
|
||||||
|
|
||||||
const DAEMON_LOG_FILENAME = "daemon.log";
|
const DAEMON_LOG_FILENAME = "daemon.log";
|
||||||
const PID_POLL_INTERVAL_MS = 100;
|
const PID_POLL_INTERVAL_MS = 100;
|
||||||
@@ -44,7 +49,7 @@ const DETACHED_STARTUP_GRACE_MS = 1200;
|
|||||||
|
|
||||||
type DesktopDaemonState = "starting" | "running" | "stopped" | "errored";
|
type DesktopDaemonState = "starting" | "running" | "stopped" | "errored";
|
||||||
|
|
||||||
interface DesktopDaemonStatus {
|
export interface DesktopDaemonStatus {
|
||||||
serverId: string;
|
serverId: string;
|
||||||
status: DesktopDaemonState;
|
status: DesktopDaemonState;
|
||||||
listen: string | null;
|
listen: string | null;
|
||||||
@@ -67,10 +72,16 @@ interface DesktopPairingOffer {
|
|||||||
qr: string | null;
|
qr: string | null;
|
||||||
}
|
}
|
||||||
|
|
||||||
type DesktopCommandHandler = (args?: Record<string, unknown>) => Promise<unknown> | unknown;
|
function parseReleaseChannel(
|
||||||
|
args: Record<string, unknown> | undefined,
|
||||||
function parseReleaseChannel(args: Record<string, unknown> | undefined): AppReleaseChannel {
|
): AppReleaseChannel | undefined {
|
||||||
return args?.releaseChannel === "beta" ? "beta" : "stable";
|
if (args?.releaseChannel === "beta") {
|
||||||
|
return "beta";
|
||||||
|
}
|
||||||
|
if (args?.releaseChannel === "stable") {
|
||||||
|
return "stable";
|
||||||
|
}
|
||||||
|
return undefined;
|
||||||
}
|
}
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
@@ -195,7 +206,7 @@ function resolveDesktopAppVersion(): string {
|
|||||||
// Daemon lifecycle
|
// Daemon lifecycle
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
|
|
||||||
async function resolveStatus(): Promise<DesktopDaemonStatus> {
|
export async function resolveDesktopDaemonStatus(): Promise<DesktopDaemonStatus> {
|
||||||
const home = getPaseoHome();
|
const home = getPaseoHome();
|
||||||
|
|
||||||
try {
|
try {
|
||||||
@@ -265,8 +276,8 @@ function buildStartupFailureError(
|
|||||||
|
|
||||||
async function pollForRunningDaemon(): Promise<DesktopDaemonStatus> {
|
async function pollForRunningDaemon(): Promise<DesktopDaemonStatus> {
|
||||||
async function poll(attempt: number): Promise<DesktopDaemonStatus> {
|
async function poll(attempt: number): Promise<DesktopDaemonStatus> {
|
||||||
if (attempt >= STARTUP_POLL_MAX_ATTEMPTS) return resolveStatus();
|
if (attempt >= STARTUP_POLL_MAX_ATTEMPTS) return resolveDesktopDaemonStatus();
|
||||||
const status = await resolveStatus();
|
const status = await resolveDesktopDaemonStatus();
|
||||||
if (attempt === 0 || attempt === STARTUP_POLL_MAX_ATTEMPTS - 1 || attempt % 10 === 9) {
|
if (attempt === 0 || attempt === STARTUP_POLL_MAX_ATTEMPTS - 1 || attempt % 10 === 9) {
|
||||||
logDesktopDaemonLifecycle("polling daemon status after detached start", {
|
logDesktopDaemonLifecycle("polling daemon status after detached start", {
|
||||||
attempt: attempt + 1,
|
attempt: attempt + 1,
|
||||||
@@ -284,7 +295,7 @@ async function pollForRunningDaemon(): Promise<DesktopDaemonStatus> {
|
|||||||
}
|
}
|
||||||
|
|
||||||
async function startDaemon(): Promise<DesktopDaemonStatus> {
|
async function startDaemon(): Promise<DesktopDaemonStatus> {
|
||||||
const current = await resolveStatus();
|
const current = await resolveDesktopDaemonStatus();
|
||||||
logDesktopDaemonLifecycle("initial status check before start", {
|
logDesktopDaemonLifecycle("initial status check before start", {
|
||||||
status: current.status,
|
status: current.status,
|
||||||
pid: current.pid,
|
pid: current.pid,
|
||||||
@@ -299,7 +310,7 @@ async function startDaemon(): Promise<DesktopDaemonStatus> {
|
|||||||
appVersion: normalizeVersion(resolveDesktopAppVersion()),
|
appVersion: normalizeVersion(resolveDesktopAppVersion()),
|
||||||
daemonVersion: normalizeVersion(current.version),
|
daemonVersion: normalizeVersion(current.version),
|
||||||
});
|
});
|
||||||
await stopDaemon();
|
await stopDesktopDaemon();
|
||||||
} else {
|
} else {
|
||||||
return current;
|
return current;
|
||||||
}
|
}
|
||||||
@@ -389,8 +400,8 @@ async function startDaemon(): Promise<DesktopDaemonStatus> {
|
|||||||
return pollForRunningDaemon();
|
return pollForRunningDaemon();
|
||||||
}
|
}
|
||||||
|
|
||||||
async function stopDaemon(): Promise<DesktopDaemonStatus> {
|
export async function stopDesktopDaemon(): Promise<DesktopDaemonStatus> {
|
||||||
const status = await resolveStatus();
|
const status = await resolveDesktopDaemonStatus();
|
||||||
if (status.status !== "running" || !status.pid) return status;
|
if (status.status !== "running" || !status.pid) return status;
|
||||||
|
|
||||||
const pid = status.pid;
|
const pid = status.pid;
|
||||||
@@ -406,11 +417,11 @@ async function stopDaemon(): Promise<DesktopDaemonStatus> {
|
|||||||
throw new Error(`Timed out waiting for daemon PID ${pid} to stop`);
|
throw new Error(`Timed out waiting for daemon PID ${pid} to stop`);
|
||||||
}
|
}
|
||||||
|
|
||||||
return await resolveStatus();
|
return await resolveDesktopDaemonStatus();
|
||||||
}
|
}
|
||||||
|
|
||||||
async function restartDaemon(): Promise<DesktopDaemonStatus> {
|
async function restartDaemon(): Promise<DesktopDaemonStatus> {
|
||||||
await stopDaemon();
|
await stopDesktopDaemon();
|
||||||
return startDaemon();
|
return startDaemon();
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -427,7 +438,7 @@ async function getCliDaemonStatus(): Promise<string> {
|
|||||||
}
|
}
|
||||||
|
|
||||||
async function getDaemonPairing(): Promise<DesktopPairingOffer> {
|
async function getDaemonPairing(): Promise<DesktopPairingOffer> {
|
||||||
const status = await resolveStatus();
|
const status = await resolveDesktopDaemonStatus();
|
||||||
if (status.status !== "running") {
|
if (status.status !== "running") {
|
||||||
return {
|
return {
|
||||||
relayEnabled: false,
|
relayEnabled: false,
|
||||||
@@ -457,7 +468,7 @@ async function getDaemonPairing(): Promise<DesktopPairingOffer> {
|
|||||||
}
|
}
|
||||||
|
|
||||||
async function getLocalDaemonVersion(): Promise<{ version: string | null; error: string | null }> {
|
async function getLocalDaemonVersion(): Promise<{ version: string | null; error: string | null }> {
|
||||||
const status = await resolveStatus();
|
const status = await resolveDesktopDaemonStatus();
|
||||||
if (status.status !== "running") {
|
if (status.status !== "running") {
|
||||||
return { version: null, error: "Daemon is not running." };
|
return { version: null, error: "Daemon is not running." };
|
||||||
}
|
}
|
||||||
@@ -467,12 +478,10 @@ async function getLocalDaemonVersion(): Promise<{ version: string | null; error:
|
|||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
function resolveCurrentUpdateVersion(): string {
|
async function resolveRequestedReleaseChannel(
|
||||||
return resolveDesktopAppVersion();
|
args: Record<string, unknown> | undefined,
|
||||||
}
|
): Promise<AppReleaseChannel> {
|
||||||
|
return parseReleaseChannel(args) ?? (await getDesktopSettingsStore().get()).releaseChannel;
|
||||||
function getSystemIdleTimeMs(): number {
|
|
||||||
return powerMonitor.getSystemIdleTime() * 1000;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// ---------------------------------------------------------------------------
|
// ---------------------------------------------------------------------------
|
||||||
@@ -481,13 +490,14 @@ function getSystemIdleTimeMs(): number {
|
|||||||
|
|
||||||
export function createDaemonCommandHandlers(): Record<string, DesktopCommandHandler> {
|
export function createDaemonCommandHandlers(): Record<string, DesktopCommandHandler> {
|
||||||
return {
|
return {
|
||||||
desktop_daemon_status: () => resolveStatus(),
|
...createDesktopSettingsCommandHandlers({ settingsStore: getDesktopSettingsStore() }),
|
||||||
|
desktop_daemon_status: () => resolveDesktopDaemonStatus(),
|
||||||
start_desktop_daemon: () => startDaemon(),
|
start_desktop_daemon: () => startDaemon(),
|
||||||
stop_desktop_daemon: () => stopDaemon(),
|
stop_desktop_daemon: () => stopDesktopDaemon(),
|
||||||
restart_desktop_daemon: () => restartDaemon(),
|
restart_desktop_daemon: () => restartDaemon(),
|
||||||
desktop_daemon_logs: () => getDaemonLogs(),
|
desktop_daemon_logs: () => getDaemonLogs(),
|
||||||
desktop_daemon_pairing: () => getDaemonPairing(),
|
desktop_daemon_pairing: () => getDaemonPairing(),
|
||||||
desktop_get_system_idle_time: () => getSystemIdleTimeMs(),
|
desktop_get_system_idle_time: () => powerMonitor.getSystemIdleTime() * 1000,
|
||||||
cli_daemon_status: () => getCliDaemonStatus(),
|
cli_daemon_status: () => getCliDaemonStatus(),
|
||||||
write_attachment_base64: (args) => writeAttachmentBase64(args ?? {}),
|
write_attachment_base64: (args) => writeAttachmentBase64(args ?? {}),
|
||||||
copy_attachment_file: (args) => copyAttachmentFileToManagedStorage(args ?? {}),
|
copy_attachment_file: (args) => copyAttachmentFileToManagedStorage(args ?? {}),
|
||||||
@@ -511,15 +521,18 @@ export function createDaemonCommandHandlers(): Record<string, DesktopCommandHand
|
|||||||
if (sessionId) closeLocalTransportSession(sessionId);
|
if (sessionId) closeLocalTransportSession(sessionId);
|
||||||
},
|
},
|
||||||
check_app_update: async (args) => {
|
check_app_update: async (args) => {
|
||||||
const currentVersion = await resolveCurrentUpdateVersion();
|
const currentVersion = resolveDesktopAppVersion();
|
||||||
return checkForAppUpdate({ currentVersion, releaseChannel: parseReleaseChannel(args) });
|
return checkForAppUpdate({
|
||||||
|
currentVersion,
|
||||||
|
releaseChannel: await resolveRequestedReleaseChannel(args),
|
||||||
|
});
|
||||||
},
|
},
|
||||||
install_app_update: async (args) => {
|
install_app_update: async (args) => {
|
||||||
const currentVersion = await resolveCurrentUpdateVersion();
|
const currentVersion = resolveDesktopAppVersion();
|
||||||
return downloadAndInstallUpdate(
|
return downloadAndInstallUpdate(
|
||||||
{ currentVersion, releaseChannel: parseReleaseChannel(args) },
|
{ currentVersion, releaseChannel: await resolveRequestedReleaseChannel(args) },
|
||||||
async () => {
|
async () => {
|
||||||
await stopDaemon();
|
await stopDesktopDaemon();
|
||||||
},
|
},
|
||||||
);
|
);
|
||||||
},
|
},
|
||||||
|
|||||||
@@ -0,0 +1,95 @@
|
|||||||
|
import { describe, expect, it, vi } from "vitest";
|
||||||
|
|
||||||
|
import { DEFAULT_DESKTOP_SETTINGS } from "../settings/desktop-settings";
|
||||||
|
import {
|
||||||
|
createBeforeQuitHandler,
|
||||||
|
shouldStopDesktopManagedDaemonOnQuit,
|
||||||
|
stopDesktopManagedDaemonOnQuitIfNeeded,
|
||||||
|
} from "./quit-lifecycle";
|
||||||
|
|
||||||
|
describe("quit-lifecycle", () => {
|
||||||
|
it("stops only when quit persistence disables keep-running and the daemon is desktop-managed", () => {
|
||||||
|
expect(
|
||||||
|
shouldStopDesktopManagedDaemonOnQuit({
|
||||||
|
settings: {
|
||||||
|
...DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
daemon: {
|
||||||
|
...DEFAULT_DESKTOP_SETTINGS.daemon,
|
||||||
|
keepRunningAfterQuit: false,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
daemonStatus: {
|
||||||
|
status: "running",
|
||||||
|
desktopManaged: true,
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
).toBe(true);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("does not stop a manually started daemon on quit", async () => {
|
||||||
|
const stopDaemon = vi.fn(async () => undefined);
|
||||||
|
|
||||||
|
const stopped = await stopDesktopManagedDaemonOnQuitIfNeeded({
|
||||||
|
settingsStore: {
|
||||||
|
get: async () => ({
|
||||||
|
...DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
daemon: {
|
||||||
|
...DEFAULT_DESKTOP_SETTINGS.daemon,
|
||||||
|
keepRunningAfterQuit: false,
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
patch: async () => DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
migrateLegacyRendererSettings: async () => DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
},
|
||||||
|
resolveStatus: async () => ({
|
||||||
|
status: "running",
|
||||||
|
desktopManaged: false,
|
||||||
|
}),
|
||||||
|
stopDaemon,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(stopped).toBe(false);
|
||||||
|
expect(stopDaemon).not.toHaveBeenCalled();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("gates quit until the stop decision completes, then lets the next quit pass through", async () => {
|
||||||
|
let resolveStopDecision: (() => void) | null = null;
|
||||||
|
const app = { quit: vi.fn() };
|
||||||
|
const closeTransportSessions = vi.fn();
|
||||||
|
const onStopError = vi.fn();
|
||||||
|
const preventDefault = vi.fn();
|
||||||
|
const secondPreventDefault = vi.fn();
|
||||||
|
|
||||||
|
const handleBeforeQuit = createBeforeQuitHandler({
|
||||||
|
app,
|
||||||
|
closeTransportSessions,
|
||||||
|
stopDesktopManagedDaemonIfNeeded: vi.fn(
|
||||||
|
() =>
|
||||||
|
new Promise<boolean>((resolve) => {
|
||||||
|
resolveStopDecision = () => resolve(false);
|
||||||
|
}),
|
||||||
|
),
|
||||||
|
onStopError,
|
||||||
|
});
|
||||||
|
|
||||||
|
handleBeforeQuit({ preventDefault });
|
||||||
|
|
||||||
|
expect(preventDefault).toHaveBeenCalledTimes(1);
|
||||||
|
expect(closeTransportSessions).toHaveBeenCalledTimes(1);
|
||||||
|
expect(app.quit).not.toHaveBeenCalled();
|
||||||
|
expect(resolveStopDecision).not.toBeNull();
|
||||||
|
|
||||||
|
resolveStopDecision?.();
|
||||||
|
await Promise.resolve();
|
||||||
|
await Promise.resolve();
|
||||||
|
|
||||||
|
expect(app.quit).toHaveBeenCalledTimes(1);
|
||||||
|
expect(onStopError).not.toHaveBeenCalled();
|
||||||
|
|
||||||
|
handleBeforeQuit({ preventDefault: secondPreventDefault });
|
||||||
|
|
||||||
|
expect(secondPreventDefault).not.toHaveBeenCalled();
|
||||||
|
expect(closeTransportSessions).toHaveBeenCalledTimes(2);
|
||||||
|
expect(app.quit).toHaveBeenCalledTimes(1);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,93 @@
|
|||||||
|
import type { DesktopSettingsStore } from "../settings/desktop-settings.js";
|
||||||
|
|
||||||
|
interface QuitLifecycleSettings {
|
||||||
|
daemon: {
|
||||||
|
keepRunningAfterQuit: boolean;
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
interface QuitLifecycleStatus {
|
||||||
|
status: "starting" | "running" | "stopped" | "errored";
|
||||||
|
desktopManaged: boolean;
|
||||||
|
}
|
||||||
|
|
||||||
|
interface BeforeQuitEvent {
|
||||||
|
preventDefault(): void;
|
||||||
|
}
|
||||||
|
|
||||||
|
interface BeforeQuitApp {
|
||||||
|
quit(): void;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function shouldStopDesktopManagedDaemonOnQuit({
|
||||||
|
settings,
|
||||||
|
daemonStatus,
|
||||||
|
}: {
|
||||||
|
settings: QuitLifecycleSettings;
|
||||||
|
daemonStatus: QuitLifecycleStatus;
|
||||||
|
}): boolean {
|
||||||
|
return (
|
||||||
|
settings.daemon.keepRunningAfterQuit === false &&
|
||||||
|
daemonStatus.status === "running" &&
|
||||||
|
daemonStatus.desktopManaged
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
export async function stopDesktopManagedDaemonOnQuitIfNeeded({
|
||||||
|
settingsStore,
|
||||||
|
resolveStatus,
|
||||||
|
stopDaemon,
|
||||||
|
}: {
|
||||||
|
settingsStore: DesktopSettingsStore;
|
||||||
|
resolveStatus: () => Promise<QuitLifecycleStatus>;
|
||||||
|
stopDaemon: () => Promise<unknown>;
|
||||||
|
}): Promise<boolean> {
|
||||||
|
const settings = await settingsStore.get();
|
||||||
|
const daemonStatus = await resolveStatus();
|
||||||
|
|
||||||
|
if (!shouldStopDesktopManagedDaemonOnQuit({ settings, daemonStatus })) {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
await stopDaemon();
|
||||||
|
return true;
|
||||||
|
}
|
||||||
|
|
||||||
|
export function createBeforeQuitHandler({
|
||||||
|
app,
|
||||||
|
closeTransportSessions,
|
||||||
|
stopDesktopManagedDaemonIfNeeded,
|
||||||
|
onStopError,
|
||||||
|
}: {
|
||||||
|
app: BeforeQuitApp;
|
||||||
|
closeTransportSessions: () => void;
|
||||||
|
stopDesktopManagedDaemonIfNeeded: () => Promise<boolean>;
|
||||||
|
onStopError: (error: unknown) => void;
|
||||||
|
}): (event: BeforeQuitEvent) => void {
|
||||||
|
let allowingQuitToContinue = false;
|
||||||
|
let quittingInProgress = false;
|
||||||
|
|
||||||
|
return (event) => {
|
||||||
|
closeTransportSessions();
|
||||||
|
|
||||||
|
if (allowingQuitToContinue) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
event.preventDefault();
|
||||||
|
if (quittingInProgress) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
quittingInProgress = true;
|
||||||
|
void stopDesktopManagedDaemonIfNeeded()
|
||||||
|
.catch((error) => {
|
||||||
|
onStopError(error);
|
||||||
|
})
|
||||||
|
.finally(() => {
|
||||||
|
allowingQuitToContinue = true;
|
||||||
|
quittingInProgress = false;
|
||||||
|
app.quit();
|
||||||
|
});
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -34,6 +34,12 @@ import {
|
|||||||
import { registerOpenerHandlers } from "./features/opener.js";
|
import { registerOpenerHandlers } from "./features/opener.js";
|
||||||
import { setupApplicationMenu } from "./features/menu.js";
|
import { setupApplicationMenu } from "./features/menu.js";
|
||||||
import { parseOpenProjectPathFromArgv } from "./open-project-routing.js";
|
import { parseOpenProjectPathFromArgv } from "./open-project-routing.js";
|
||||||
|
import { getDesktopSettingsStore } from "./settings/desktop-settings-electron.js";
|
||||||
|
import { resolveDesktopDaemonStatus, stopDesktopDaemon } from "./daemon/daemon-manager.js";
|
||||||
|
import {
|
||||||
|
createBeforeQuitHandler,
|
||||||
|
stopDesktopManagedDaemonOnQuitIfNeeded,
|
||||||
|
} from "./daemon/quit-lifecycle.js";
|
||||||
|
|
||||||
const DEV_SERVER_URL = process.env.EXPO_DEV_URL ?? "http://localhost:8081";
|
const DEV_SERVER_URL = process.env.EXPO_DEV_URL ?? "http://localhost:8081";
|
||||||
const APP_SCHEME = "paseo";
|
const APP_SCHEME = "paseo";
|
||||||
@@ -340,9 +346,22 @@ void bootstrap().catch((error) => {
|
|||||||
process.exit(1);
|
process.exit(1);
|
||||||
});
|
});
|
||||||
|
|
||||||
app.on("before-quit", () => {
|
app.on(
|
||||||
closeAllTransportSessions();
|
"before-quit",
|
||||||
});
|
createBeforeQuitHandler({
|
||||||
|
app,
|
||||||
|
closeTransportSessions: closeAllTransportSessions,
|
||||||
|
stopDesktopManagedDaemonIfNeeded: () =>
|
||||||
|
stopDesktopManagedDaemonOnQuitIfNeeded({
|
||||||
|
settingsStore: getDesktopSettingsStore(),
|
||||||
|
resolveStatus: resolveDesktopDaemonStatus,
|
||||||
|
stopDaemon: stopDesktopDaemon,
|
||||||
|
}),
|
||||||
|
onStopError: (error) => {
|
||||||
|
log.error("[desktop daemon] failed to stop managed daemon on quit", error);
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
|
||||||
app.on("window-all-closed", () => {
|
app.on("window-all-closed", () => {
|
||||||
if (process.platform !== "darwin") {
|
if (process.platform !== "darwin") {
|
||||||
|
|||||||
@@ -0,0 +1,67 @@
|
|||||||
|
import { describe, expect, it, vi } from "vitest";
|
||||||
|
|
||||||
|
import { DEFAULT_DESKTOP_SETTINGS, type DesktopSettingsStore } from "./desktop-settings";
|
||||||
|
import { createDesktopSettingsCommandHandlers } from "./desktop-settings-commands";
|
||||||
|
|
||||||
|
function createStoreMock(): DesktopSettingsStore {
|
||||||
|
return {
|
||||||
|
get: vi.fn(async () => DEFAULT_DESKTOP_SETTINGS),
|
||||||
|
patch: vi.fn(async () => ({
|
||||||
|
...DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
releaseChannel: "beta",
|
||||||
|
})),
|
||||||
|
migrateLegacyRendererSettings: vi.fn(async () => ({
|
||||||
|
...DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
releaseChannel: "beta",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
keepRunningAfterQuit: true,
|
||||||
|
},
|
||||||
|
})),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
describe("desktop-settings-commands", () => {
|
||||||
|
it("exposes get and patch handlers through the desktop command bus shape", async () => {
|
||||||
|
const store = createStoreMock();
|
||||||
|
const handlers = createDesktopSettingsCommandHandlers({ settingsStore: store });
|
||||||
|
|
||||||
|
await expect(handlers.get_desktop_settings()).resolves.toEqual(DEFAULT_DESKTOP_SETTINGS);
|
||||||
|
await expect(
|
||||||
|
handlers.patch_desktop_settings({
|
||||||
|
daemon: { keepRunningAfterQuit: false },
|
||||||
|
}),
|
||||||
|
).resolves.toEqual({
|
||||||
|
...DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
releaseChannel: "beta",
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(store.get).toHaveBeenCalledTimes(1);
|
||||||
|
expect(store.patch).toHaveBeenCalledWith({
|
||||||
|
daemon: { keepRunningAfterQuit: false },
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("accepts legacy renderer settings migration payloads", async () => {
|
||||||
|
const store = createStoreMock();
|
||||||
|
const handlers = createDesktopSettingsCommandHandlers({ settingsStore: store });
|
||||||
|
|
||||||
|
const result = await handlers.migrate_legacy_desktop_settings({
|
||||||
|
releaseChannel: "beta",
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(result).toEqual({
|
||||||
|
...DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
releaseChannel: "beta",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
keepRunningAfterQuit: true,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expect(store.migrateLegacyRendererSettings).toHaveBeenCalledWith({
|
||||||
|
releaseChannel: "beta",
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
});
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,15 @@
|
|||||||
|
import type { DesktopSettingsStore } from "./desktop-settings.js";
|
||||||
|
|
||||||
|
export type DesktopCommandHandler = (args?: Record<string, unknown>) => Promise<unknown> | unknown;
|
||||||
|
|
||||||
|
export function createDesktopSettingsCommandHandlers({
|
||||||
|
settingsStore,
|
||||||
|
}: {
|
||||||
|
settingsStore: DesktopSettingsStore;
|
||||||
|
}): Record<string, DesktopCommandHandler> {
|
||||||
|
return {
|
||||||
|
get_desktop_settings: () => settingsStore.get(),
|
||||||
|
patch_desktop_settings: (args) => settingsStore.patch(args),
|
||||||
|
migrate_legacy_desktop_settings: (args) => settingsStore.migrateLegacyRendererSettings(args),
|
||||||
|
};
|
||||||
|
}
|
||||||
@@ -0,0 +1,12 @@
|
|||||||
|
import { app } from "electron";
|
||||||
|
|
||||||
|
import { createDesktopSettingsStore, type DesktopSettingsStore } from "./desktop-settings.js";
|
||||||
|
|
||||||
|
let desktopSettingsStore: DesktopSettingsStore | null = null;
|
||||||
|
|
||||||
|
export function getDesktopSettingsStore(): DesktopSettingsStore {
|
||||||
|
desktopSettingsStore ??= createDesktopSettingsStore({
|
||||||
|
userDataPath: app.getPath("userData"),
|
||||||
|
});
|
||||||
|
return desktopSettingsStore;
|
||||||
|
}
|
||||||
@@ -0,0 +1,127 @@
|
|||||||
|
import { mkdtemp, readFile, readdir, rm, writeFile } from "node:fs/promises";
|
||||||
|
import os from "node:os";
|
||||||
|
import path from "node:path";
|
||||||
|
import { afterEach, describe, expect, it } from "vitest";
|
||||||
|
|
||||||
|
import {
|
||||||
|
DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
type DesktopSettings,
|
||||||
|
createDesktopSettingsStore,
|
||||||
|
} from "./desktop-settings";
|
||||||
|
|
||||||
|
async function createTempUserDataDir(): Promise<string> {
|
||||||
|
return await mkdtemp(path.join(os.tmpdir(), "paseo-desktop-settings-"));
|
||||||
|
}
|
||||||
|
|
||||||
|
function settingsFilePath(userDataPath: string): string {
|
||||||
|
return path.join(userDataPath, "desktop-settings.json");
|
||||||
|
}
|
||||||
|
|
||||||
|
describe("desktop-settings", () => {
|
||||||
|
const directories = new Set<string>();
|
||||||
|
|
||||||
|
afterEach(async () => {
|
||||||
|
await Promise.all(
|
||||||
|
[...directories].map(async (directory) => {
|
||||||
|
await rm(directory, { recursive: true, force: true });
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
directories.clear();
|
||||||
|
});
|
||||||
|
|
||||||
|
it("persists default settings for new users", async () => {
|
||||||
|
const userDataPath = await createTempUserDataDir();
|
||||||
|
directories.add(userDataPath);
|
||||||
|
const store = createDesktopSettingsStore({ userDataPath });
|
||||||
|
|
||||||
|
const settings = await store.get();
|
||||||
|
const persisted = JSON.parse(await readFile(settingsFilePath(userDataPath), "utf8")) as {
|
||||||
|
settings: DesktopSettings;
|
||||||
|
};
|
||||||
|
|
||||||
|
expect(settings).toEqual(DEFAULT_DESKTOP_SETTINGS);
|
||||||
|
expect(persisted.settings).toEqual(DEFAULT_DESKTOP_SETTINGS);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("coerces invalid persisted values back to safe defaults", async () => {
|
||||||
|
const userDataPath = await createTempUserDataDir();
|
||||||
|
directories.add(userDataPath);
|
||||||
|
await writeFile(
|
||||||
|
settingsFilePath(userDataPath),
|
||||||
|
JSON.stringify({
|
||||||
|
version: 1,
|
||||||
|
settings: {
|
||||||
|
releaseChannel: "nightly",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: "sometimes",
|
||||||
|
keepRunningAfterQuit: false,
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}),
|
||||||
|
);
|
||||||
|
const store = createDesktopSettingsStore({ userDataPath });
|
||||||
|
|
||||||
|
const settings = await store.get();
|
||||||
|
|
||||||
|
expect(settings).toEqual({
|
||||||
|
releaseChannel: "stable",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: true,
|
||||||
|
keepRunningAfterQuit: false,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
});
|
||||||
|
|
||||||
|
it("patches nested settings and leaves no temp files behind", async () => {
|
||||||
|
const userDataPath = await createTempUserDataDir();
|
||||||
|
directories.add(userDataPath);
|
||||||
|
const store = createDesktopSettingsStore({ userDataPath });
|
||||||
|
|
||||||
|
await store.get();
|
||||||
|
const next = await store.patch({
|
||||||
|
releaseChannel: "beta",
|
||||||
|
daemon: { keepRunningAfterQuit: false },
|
||||||
|
});
|
||||||
|
const files = await readdir(userDataPath);
|
||||||
|
|
||||||
|
expect(next).toEqual({
|
||||||
|
releaseChannel: "beta",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: true,
|
||||||
|
keepRunningAfterQuit: false,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expect(files).toEqual(["desktop-settings.json"]);
|
||||||
|
});
|
||||||
|
|
||||||
|
it("migrates desktop-owned values from legacy renderer settings once", async () => {
|
||||||
|
const userDataPath = await createTempUserDataDir();
|
||||||
|
directories.add(userDataPath);
|
||||||
|
const store = createDesktopSettingsStore({ userDataPath });
|
||||||
|
|
||||||
|
await store.patch({
|
||||||
|
daemon: {
|
||||||
|
keepRunningAfterQuit: false,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
const migrated = await store.migrateLegacyRendererSettings({
|
||||||
|
releaseChannel: "beta",
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
theme: "dark",
|
||||||
|
});
|
||||||
|
const ignoredSecondMigration = await store.migrateLegacyRendererSettings({
|
||||||
|
releaseChannel: "stable",
|
||||||
|
manageBuiltInDaemon: true,
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(migrated).toEqual({
|
||||||
|
releaseChannel: "beta",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: false,
|
||||||
|
keepRunningAfterQuit: false,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
expect(ignoredSecondMigration).toEqual(migrated);
|
||||||
|
});
|
||||||
|
});
|
||||||
@@ -0,0 +1,261 @@
|
|||||||
|
import { access, mkdir, readFile, rename, writeFile } from "node:fs/promises";
|
||||||
|
import path from "node:path";
|
||||||
|
|
||||||
|
import type { AppReleaseChannel } from "../features/auto-updater.js";
|
||||||
|
|
||||||
|
export interface DesktopSettings {
|
||||||
|
releaseChannel: AppReleaseChannel;
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: boolean;
|
||||||
|
keepRunningAfterQuit: boolean;
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
interface DesktopSettingsPatch {
|
||||||
|
releaseChannel?: AppReleaseChannel;
|
||||||
|
daemon?: Partial<DesktopSettings["daemon"]>;
|
||||||
|
}
|
||||||
|
|
||||||
|
interface PersistedDesktopSettingsDocument {
|
||||||
|
version: 1;
|
||||||
|
settings: DesktopSettings;
|
||||||
|
migrations: {
|
||||||
|
legacyRendererSettingsImported: boolean;
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
export interface DesktopSettingsStore {
|
||||||
|
get(): Promise<DesktopSettings>;
|
||||||
|
patch(patch: unknown): Promise<DesktopSettings>;
|
||||||
|
migrateLegacyRendererSettings(legacySettings: unknown): Promise<DesktopSettings>;
|
||||||
|
}
|
||||||
|
|
||||||
|
export const DEFAULT_DESKTOP_SETTINGS: DesktopSettings = {
|
||||||
|
releaseChannel: "stable",
|
||||||
|
daemon: {
|
||||||
|
manageBuiltInDaemon: true,
|
||||||
|
keepRunningAfterQuit: true,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
|
||||||
|
const DESKTOP_SETTINGS_FILENAME = "desktop-settings.json";
|
||||||
|
|
||||||
|
function isRecord(value: unknown): value is Record<string, unknown> {
|
||||||
|
return typeof value === "object" && value !== null && !Array.isArray(value);
|
||||||
|
}
|
||||||
|
|
||||||
|
function coerceReleaseChannel(value: unknown): AppReleaseChannel | null {
|
||||||
|
if (value === "beta") {
|
||||||
|
return "beta";
|
||||||
|
}
|
||||||
|
if (value === "stable") {
|
||||||
|
return "stable";
|
||||||
|
}
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
|
function coerceBoolean(value: unknown): boolean | null {
|
||||||
|
return typeof value === "boolean" ? value : null;
|
||||||
|
}
|
||||||
|
|
||||||
|
function buildDefaultDocument(): PersistedDesktopSettingsDocument {
|
||||||
|
return {
|
||||||
|
version: 1,
|
||||||
|
settings: DEFAULT_DESKTOP_SETTINGS,
|
||||||
|
migrations: {
|
||||||
|
legacyRendererSettingsImported: false,
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function coerceDesktopSettings(input: unknown): DesktopSettings {
|
||||||
|
const result: DesktopSettings = {
|
||||||
|
releaseChannel: DEFAULT_DESKTOP_SETTINGS.releaseChannel,
|
||||||
|
daemon: { ...DEFAULT_DESKTOP_SETTINGS.daemon },
|
||||||
|
};
|
||||||
|
|
||||||
|
if (!isRecord(input)) {
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
const releaseChannel = coerceReleaseChannel(input.releaseChannel);
|
||||||
|
if (releaseChannel) {
|
||||||
|
result.releaseChannel = releaseChannel;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (isRecord(input.daemon)) {
|
||||||
|
const manageBuiltInDaemon = coerceBoolean(input.daemon.manageBuiltInDaemon);
|
||||||
|
if (manageBuiltInDaemon !== null) {
|
||||||
|
result.daemon.manageBuiltInDaemon = manageBuiltInDaemon;
|
||||||
|
}
|
||||||
|
|
||||||
|
const keepRunningAfterQuit = coerceBoolean(input.daemon.keepRunningAfterQuit);
|
||||||
|
if (keepRunningAfterQuit !== null) {
|
||||||
|
result.daemon.keepRunningAfterQuit = keepRunningAfterQuit;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
function coerceDesktopSettingsPatch(input: unknown): DesktopSettingsPatch {
|
||||||
|
if (!isRecord(input)) {
|
||||||
|
return {};
|
||||||
|
}
|
||||||
|
|
||||||
|
const patch: DesktopSettingsPatch = {};
|
||||||
|
|
||||||
|
const releaseChannel = coerceReleaseChannel(input.releaseChannel);
|
||||||
|
if (releaseChannel) {
|
||||||
|
patch.releaseChannel = releaseChannel;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (isRecord(input.daemon)) {
|
||||||
|
const daemonPatch: Partial<DesktopSettings["daemon"]> = {};
|
||||||
|
const manageBuiltInDaemon = coerceBoolean(input.daemon.manageBuiltInDaemon);
|
||||||
|
if (manageBuiltInDaemon !== null) {
|
||||||
|
daemonPatch.manageBuiltInDaemon = manageBuiltInDaemon;
|
||||||
|
}
|
||||||
|
const keepRunningAfterQuit = coerceBoolean(input.daemon.keepRunningAfterQuit);
|
||||||
|
if (keepRunningAfterQuit !== null) {
|
||||||
|
daemonPatch.keepRunningAfterQuit = keepRunningAfterQuit;
|
||||||
|
}
|
||||||
|
if (Object.keys(daemonPatch).length > 0) {
|
||||||
|
patch.daemon = daemonPatch;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return patch;
|
||||||
|
}
|
||||||
|
|
||||||
|
function pickDesktopSettingsFromLegacyRendererSettings(
|
||||||
|
legacySettings: unknown,
|
||||||
|
): DesktopSettingsPatch {
|
||||||
|
if (!isRecord(legacySettings)) {
|
||||||
|
return {};
|
||||||
|
}
|
||||||
|
|
||||||
|
const patch: DesktopSettingsPatch = {};
|
||||||
|
const releaseChannel = coerceReleaseChannel(legacySettings.releaseChannel);
|
||||||
|
if (releaseChannel) {
|
||||||
|
patch.releaseChannel = releaseChannel;
|
||||||
|
}
|
||||||
|
|
||||||
|
const manageBuiltInDaemon = coerceBoolean(legacySettings.manageBuiltInDaemon);
|
||||||
|
if (manageBuiltInDaemon !== null) {
|
||||||
|
patch.daemon = { manageBuiltInDaemon };
|
||||||
|
}
|
||||||
|
|
||||||
|
return patch;
|
||||||
|
}
|
||||||
|
|
||||||
|
function mergeDesktopSettings(
|
||||||
|
current: DesktopSettings,
|
||||||
|
patch: DesktopSettingsPatch,
|
||||||
|
): DesktopSettings {
|
||||||
|
return {
|
||||||
|
releaseChannel: patch.releaseChannel ?? current.releaseChannel,
|
||||||
|
daemon: { ...current.daemon, ...patch.daemon },
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
function coerceDocument(input: unknown): PersistedDesktopSettingsDocument {
|
||||||
|
if (!isRecord(input)) {
|
||||||
|
return buildDefaultDocument();
|
||||||
|
}
|
||||||
|
|
||||||
|
const settings = coerceDesktopSettings(input.settings);
|
||||||
|
const migrations = isRecord(input.migrations)
|
||||||
|
? {
|
||||||
|
legacyRendererSettingsImported: input.migrations.legacyRendererSettingsImported === true,
|
||||||
|
}
|
||||||
|
: {
|
||||||
|
legacyRendererSettingsImported: false,
|
||||||
|
};
|
||||||
|
|
||||||
|
return {
|
||||||
|
version: 1,
|
||||||
|
settings,
|
||||||
|
migrations,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
export function createDesktopSettingsStore({
|
||||||
|
userDataPath,
|
||||||
|
}: {
|
||||||
|
userDataPath: string;
|
||||||
|
}): DesktopSettingsStore {
|
||||||
|
const filePath = path.join(userDataPath, DESKTOP_SETTINGS_FILENAME);
|
||||||
|
let cachedDocument: PersistedDesktopSettingsDocument | null = null;
|
||||||
|
|
||||||
|
async function persistDocument(document: PersistedDesktopSettingsDocument): Promise<void> {
|
||||||
|
await mkdir(userDataPath, { recursive: true });
|
||||||
|
const tempFilePath = `${filePath}.tmp`;
|
||||||
|
await writeFile(tempFilePath, `${JSON.stringify(document, null, 2)}\n`, "utf8");
|
||||||
|
await rename(tempFilePath, filePath);
|
||||||
|
cachedDocument = document;
|
||||||
|
}
|
||||||
|
|
||||||
|
async function loadDocument(): Promise<PersistedDesktopSettingsDocument> {
|
||||||
|
if (cachedDocument) {
|
||||||
|
return cachedDocument;
|
||||||
|
}
|
||||||
|
|
||||||
|
try {
|
||||||
|
await access(filePath);
|
||||||
|
} catch {
|
||||||
|
const document = buildDefaultDocument();
|
||||||
|
await persistDocument(document);
|
||||||
|
return document;
|
||||||
|
}
|
||||||
|
|
||||||
|
try {
|
||||||
|
const raw = await readFile(filePath, "utf8");
|
||||||
|
const document = coerceDocument(JSON.parse(raw));
|
||||||
|
await persistDocument(document);
|
||||||
|
return document;
|
||||||
|
} catch {
|
||||||
|
const document = buildDefaultDocument();
|
||||||
|
await persistDocument(document);
|
||||||
|
return document;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return {
|
||||||
|
async get(): Promise<DesktopSettings> {
|
||||||
|
const document = await loadDocument();
|
||||||
|
return document.settings;
|
||||||
|
},
|
||||||
|
|
||||||
|
async patch(patch: unknown): Promise<DesktopSettings> {
|
||||||
|
const current = await loadDocument();
|
||||||
|
const next = mergeDesktopSettings(current.settings, coerceDesktopSettingsPatch(patch));
|
||||||
|
await persistDocument({
|
||||||
|
...current,
|
||||||
|
settings: next,
|
||||||
|
});
|
||||||
|
return next;
|
||||||
|
},
|
||||||
|
|
||||||
|
async migrateLegacyRendererSettings(legacySettings: unknown): Promise<DesktopSettings> {
|
||||||
|
const current = await loadDocument();
|
||||||
|
if (current.migrations.legacyRendererSettingsImported) {
|
||||||
|
return current.settings;
|
||||||
|
}
|
||||||
|
|
||||||
|
const next = mergeDesktopSettings(
|
||||||
|
current.settings,
|
||||||
|
pickDesktopSettingsFromLegacyRendererSettings(legacySettings),
|
||||||
|
);
|
||||||
|
await persistDocument({
|
||||||
|
...current,
|
||||||
|
settings: next,
|
||||||
|
migrations: {
|
||||||
|
...current.migrations,
|
||||||
|
legacyRendererSettingsImported: true,
|
||||||
|
},
|
||||||
|
});
|
||||||
|
return next;
|
||||||
|
},
|
||||||
|
};
|
||||||
|
}
|
||||||
Reference in New Issue
Block a user