Context from recent agent work - Prior commits focused on voice/background model gating, speech resolver typing, and timeline cursor loading. - This change targets a separate CLI command path to avoid overlap. What changed - Normalized the optional mode argument once (`mode?.trim()`) and reused it. - Removed duplicated `client.close()` calls and centralized cleanup in a `finally` block. - Typed the daemon client variable explicitly (`Awaited<ReturnType<typeof connectToDaemon>> | undefined`). - Kept user-facing behavior and error codes stable, including DAEMON_NOT_RUNNING and MODE_OPERATION_FAILED. Reasoning - The previous implementation duplicated lifecycle handling and relied on non-null assertions for mode values. - Centralized resource cleanup lowers leak risk and makes control flow easier to audit. - This is a behavior-preserving refactor aligned with the refactor skill contract. Verification - `npm run typecheck` - `npx tsx packages/cli/tests/10-agent-mode.test.ts` Accomplishments for next agent - `runModeCommand` now has a single cleanup path and clearer branching for list vs set mode. - Mode argument handling is explicit and trimmed before use. Challenges / follow-up - CLI output typing still requires `AnyCommandResult<any>` for mixed-shape commands due the current `withOutput` generic design. - If desired, a future refactor can redesign output typing to support per-branch result schemas without `any`.
143 lines
4.0 KiB
TypeScript
143 lines
4.0 KiB
TypeScript
import type { Command } from 'commander'
|
|
import { connectToDaemon, getDaemonHost } from '../../utils/client.js'
|
|
import type {
|
|
CommandOptions,
|
|
OutputSchema,
|
|
CommandError,
|
|
AnyCommandResult,
|
|
} from '../../output/index.js'
|
|
import type { AgentMode } from '@getpaseo/server'
|
|
|
|
/** Result for setting mode */
|
|
export interface SetModeResult {
|
|
agentId: string
|
|
mode: string
|
|
}
|
|
|
|
/** Schema for mode list output */
|
|
export const modeListSchema: OutputSchema<AgentMode> = {
|
|
idField: 'id',
|
|
columns: [
|
|
{ header: 'MODE', field: 'id', width: 15 },
|
|
{ header: 'LABEL', field: 'label', width: 25 },
|
|
{ header: 'DESCRIPTION', field: 'description', width: 40 },
|
|
],
|
|
}
|
|
|
|
/** Schema for set mode output */
|
|
export const setModeSchema: OutputSchema<SetModeResult> = {
|
|
idField: 'agentId',
|
|
columns: [
|
|
{ header: 'AGENT ID', field: 'agentId', width: 12 },
|
|
{ header: 'MODE', field: 'mode', width: 20 },
|
|
],
|
|
}
|
|
|
|
export interface AgentModeOptions extends CommandOptions {
|
|
list?: boolean
|
|
}
|
|
|
|
// This command returns two different data shapes (set result vs mode list).
|
|
// Keep `any` here to match the existing output wrapper generic contract.
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
export type AgentModeResult = AnyCommandResult<any>
|
|
|
|
export async function runModeCommand(
|
|
id: string,
|
|
mode: string | undefined,
|
|
options: AgentModeOptions,
|
|
_command: Command
|
|
): Promise<AgentModeResult> {
|
|
const normalizedMode = mode?.trim()
|
|
const host = getDaemonHost({ host: options.host as string | undefined })
|
|
|
|
// Validate arguments
|
|
if (!options.list && !normalizedMode) {
|
|
const error: CommandError = {
|
|
code: 'MISSING_ARGUMENT',
|
|
message: 'Mode argument required unless --list is specified',
|
|
details: 'Usage: paseo agent mode <id> <mode> | paseo agent mode --list <id>',
|
|
}
|
|
throw error
|
|
}
|
|
|
|
let client: Awaited<ReturnType<typeof connectToDaemon>> | undefined
|
|
try {
|
|
client = await connectToDaemon({ host: options.host as string | undefined })
|
|
const agent = await client.fetchAgent(id)
|
|
if (!agent) {
|
|
const error: CommandError = {
|
|
code: 'AGENT_NOT_FOUND',
|
|
message: `No agent found matching: ${id}`,
|
|
details: 'Use `paseo ls` to list available agents',
|
|
}
|
|
throw error
|
|
}
|
|
const resolvedId = agent.id
|
|
|
|
if (options.list) {
|
|
// List available modes for this agent
|
|
const availableModes = agent.availableModes ?? []
|
|
|
|
const items: AgentMode[] = availableModes.map((m) => ({
|
|
id: m.id,
|
|
label: m.label,
|
|
description: m.description,
|
|
}))
|
|
|
|
return {
|
|
type: 'list',
|
|
data: items,
|
|
schema: modeListSchema,
|
|
}
|
|
} else {
|
|
if (!normalizedMode) {
|
|
const error: CommandError = {
|
|
code: 'MISSING_ARGUMENT',
|
|
message: 'Mode argument required unless --list is specified',
|
|
details: 'Usage: paseo agent mode <id> <mode> | paseo agent mode --list <id>',
|
|
}
|
|
throw error
|
|
}
|
|
|
|
// Set the agent mode
|
|
await client.setAgentMode(resolvedId, normalizedMode)
|
|
|
|
return {
|
|
type: 'single',
|
|
data: {
|
|
agentId: resolvedId.slice(0, 7),
|
|
mode: normalizedMode,
|
|
},
|
|
schema: setModeSchema,
|
|
}
|
|
}
|
|
} catch (err) {
|
|
// Re-throw if it's already a CommandError
|
|
if (err && typeof err === 'object' && 'code' in err) {
|
|
throw err
|
|
}
|
|
|
|
if (!client) {
|
|
const message = err instanceof Error ? err.message : String(err)
|
|
const error: CommandError = {
|
|
code: 'DAEMON_NOT_RUNNING',
|
|
message: `Cannot connect to daemon at ${host}: ${message}`,
|
|
details: 'Start the daemon with: paseo daemon start',
|
|
}
|
|
throw error
|
|
}
|
|
|
|
const message = err instanceof Error ? err.message : String(err)
|
|
const error: CommandError = {
|
|
code: 'MODE_OPERATION_FAILED',
|
|
message: `Failed to ${options.list ? 'list modes' : 'set mode'}: ${message}`,
|
|
}
|
|
throw error
|
|
} finally {
|
|
if (client) {
|
|
await client.close().catch(() => {})
|
|
}
|
|
}
|
|
}
|