* fix(agents): preserve Claude thinking selections Model switches now resolve thinking against the target model's saved preference instead of resetting to the catalog default. Claude owns its configured-model defaults and legacy Fable alias handling, while persisted permission modes remain unchanged. * chore(claude): tag Fable compatibility shim * fix(app): resolve persisted model aliases * fix(models): preserve aliases for older clients * fix(models): hide compatibility aliases from listings * fix(settings): hide compatibility model aliases * test(claude): cover legacy catalog entry * test(app): expect mock thinking controls in schedules * fix(app): preserve queued thinking preferences * fix(app): reconcile schedule provider snapshots * fix(app): preserve schedule model selections * fix(claude): preserve exact configured model ids * fix(app): preserve committed thinking preferences * fix(app): preserve aliased schedule thinking
241 lines
9.1 KiB
TypeScript
241 lines
9.1 KiB
TypeScript
import { expect, test } from "../support/fixtures";
|
|
import { gotoAppShell } from "../support/helpers/app";
|
|
import {
|
|
addFakeScheduleHostAndReload,
|
|
buildFakeScheduleHostWorkspace,
|
|
FAKE_HOST_MODEL_ID,
|
|
FAKE_HOST_MODEL_LABEL,
|
|
installFakeScheduleHost,
|
|
} from "../support/helpers/schedule-fake-host";
|
|
import { seedWorkspace, type SeededWorkspace } from "../support/helpers/seed-client";
|
|
import { expectSettled, expectStableHeight } from "../support/helpers/settled";
|
|
import { waitForSidebarHydration } from "../support/helpers/workspace-ui";
|
|
import { buildSchedulesRoute } from "../../src/utils/host-routes";
|
|
|
|
interface ScheduleSeedClient {
|
|
scheduleCreate(input: {
|
|
prompt: string;
|
|
name?: string;
|
|
cadence: { type: "cron"; expression: string };
|
|
target: {
|
|
type: "new-agent";
|
|
config: {
|
|
provider: "mock";
|
|
cwd: string;
|
|
model: string;
|
|
modeId: string;
|
|
title: string;
|
|
};
|
|
};
|
|
runOnCreate: boolean;
|
|
}): Promise<{ schedule: { id: string } | null; error: string | null }>;
|
|
scheduleDelete(input: { id: string }): Promise<{ error: string | null }>;
|
|
}
|
|
|
|
async function seedMockSchedule(workspace: SeededWorkspace, name: string): Promise<string> {
|
|
const client = workspace.client as unknown as ScheduleSeedClient;
|
|
const result = await client.scheduleCreate({
|
|
prompt: "Say hello from the scheduled agent.",
|
|
name,
|
|
cadence: { type: "cron", expression: "0 9 * * *" },
|
|
target: {
|
|
type: "new-agent",
|
|
config: {
|
|
provider: "mock",
|
|
cwd: workspace.repoPath,
|
|
model: "ten-second-stream",
|
|
modeId: "load-test",
|
|
title: name,
|
|
},
|
|
},
|
|
runOnCreate: false,
|
|
});
|
|
|
|
if (!result.schedule) {
|
|
throw new Error(result.error ?? "Failed to seed schedule");
|
|
}
|
|
|
|
return result.schedule.id;
|
|
}
|
|
|
|
function ignoreScheduleDeleteError(): void {}
|
|
|
|
async function deleteSeededSchedule(workspace: SeededWorkspace, id: string): Promise<void> {
|
|
await (workspace.client as unknown as ScheduleSeedClient)
|
|
.scheduleDelete({ id })
|
|
.catch(ignoreScheduleDeleteError);
|
|
}
|
|
|
|
type FakeScheduleHostSchedule = NonNullable<
|
|
Parameters<typeof installFakeScheduleHost>[0]["schedules"]
|
|
>[number];
|
|
|
|
function buildFakeHostSchedule(input: {
|
|
id: string;
|
|
name: string;
|
|
cwd: string;
|
|
}): FakeScheduleHostSchedule {
|
|
const now = "2026-07-01T00:00:00.000Z";
|
|
return {
|
|
id: input.id,
|
|
name: input.name,
|
|
prompt: "Run on the secondary host.",
|
|
cadence: { type: "cron", expression: "0 9 * * *" },
|
|
target: {
|
|
type: "new-agent",
|
|
config: {
|
|
provider: "mock",
|
|
cwd: input.cwd,
|
|
model: FAKE_HOST_MODEL_ID,
|
|
modeId: "load-test",
|
|
title: input.name,
|
|
},
|
|
},
|
|
status: "active",
|
|
createdAt: now,
|
|
updatedAt: now,
|
|
nextRunAt: now,
|
|
lastRunAt: null,
|
|
pausedAt: null,
|
|
expiresAt: null,
|
|
maxRuns: null,
|
|
};
|
|
}
|
|
|
|
test.describe("Schedules", () => {
|
|
const cleanupTasks: Array<() => Promise<void>> = [];
|
|
|
|
test.afterEach(async () => {
|
|
for (const cleanup of cleanupTasks.toReversed()) {
|
|
await cleanup();
|
|
}
|
|
cleanupTasks.length = 0;
|
|
});
|
|
|
|
test("edit form hydrates the scheduled model selection", async ({ page }) => {
|
|
const workspace = await seedWorkspace({ repoPrefix: "schedule-model-hydration-" });
|
|
cleanupTasks.push(() => workspace.cleanup());
|
|
const scheduleName = `Hydrate model ${Date.now()}`;
|
|
const scheduleId = await seedMockSchedule(workspace, scheduleName);
|
|
cleanupTasks.push(() => deleteSeededSchedule(workspace, scheduleId));
|
|
|
|
await page.goto(buildSchedulesRoute());
|
|
const row = page.getByTestId(`schedule-row-${scheduleId}`);
|
|
await expect(row).toBeVisible({ timeout: 30_000 });
|
|
await expect(row).toContainText(workspace.projectDisplayName, { timeout: 30_000 });
|
|
|
|
await row.click();
|
|
const formSheet = page.getByTestId("schedule-form-sheet");
|
|
await expect(formSheet).toBeVisible({ timeout: 10_000 });
|
|
await expectStableHeight(formSheet);
|
|
const hostTrigger = page.getByTestId("schedule-host-trigger");
|
|
const projectTrigger = page.getByTestId("schedule-project-trigger");
|
|
const modelTrigger = page.getByTestId("schedule-model-trigger");
|
|
const thinkingTrigger = page.getByTestId("schedule-thinking-trigger");
|
|
const modeTrigger = page.getByTestId("schedule-mode-trigger");
|
|
await expect(hostTrigger).toBeVisible({ timeout: 30_000 });
|
|
await expect(hostTrigger).toBeDisabled();
|
|
await expectSettled(hostTrigger);
|
|
await expect(projectTrigger).toContainText(workspace.projectDisplayName, { timeout: 30_000 });
|
|
await expectSettled(projectTrigger);
|
|
await expect(modelTrigger).toContainText("Ten second stream", { timeout: 30_000 });
|
|
await expectSettled(modelTrigger);
|
|
await expect(thinkingTrigger).toContainText("Low");
|
|
await expectSettled(thinkingTrigger);
|
|
await expect(modeTrigger).toBeVisible({ timeout: 30_000 });
|
|
await expectSettled(modeTrigger);
|
|
await expect(page.getByTestId("cadence-mode")).toHaveCount(0);
|
|
await expect(page.getByTestId("cadence-interval-value")).toHaveCount(0);
|
|
await expect(page.getByTestId("schedule-cadence-preset-trigger")).toContainText("Daily 9:00");
|
|
await expect(page.getByText(/Times are in/)).toHaveCount(0);
|
|
await expect(formSheet.getByText("Cron", { exact: true })).toHaveCount(0);
|
|
});
|
|
|
|
test("edit form hydrates a non-default host schedule after reload", async ({ page }) => {
|
|
const workspace = await seedWorkspace({ repoPrefix: "schedule-host-b-hydration-" });
|
|
cleanupTasks.push(() => workspace.cleanup());
|
|
const fakeHost = await buildFakeScheduleHostWorkspace(workspace);
|
|
const fakePort = String(59_000 + Math.floor(Math.random() * 900));
|
|
const scheduleId = "fake-host-schedule";
|
|
const scheduleName = "Secondary host schedule";
|
|
|
|
await installFakeScheduleHost({
|
|
page,
|
|
port: fakePort,
|
|
serverId: fakeHost.serverId,
|
|
workspace: fakeHost.workspace,
|
|
project: fakeHost,
|
|
schedules: [
|
|
buildFakeHostSchedule({
|
|
id: scheduleId,
|
|
name: scheduleName,
|
|
cwd: String(fakeHost.workspace.workspaceDirectory),
|
|
}),
|
|
],
|
|
});
|
|
|
|
await gotoAppShell(page);
|
|
await waitForSidebarHydration(page);
|
|
await page.goto(buildSchedulesRoute());
|
|
await addFakeScheduleHostAndReload({
|
|
page,
|
|
serverId: fakeHost.serverId,
|
|
label: "Fake host",
|
|
port: fakePort,
|
|
});
|
|
await page.reload();
|
|
|
|
const row = page.getByTestId(`schedule-row-${scheduleId}`);
|
|
await expect(row).toBeVisible({ timeout: 30_000 });
|
|
await row.click();
|
|
|
|
const formSheet = page.getByTestId("schedule-form-sheet");
|
|
await expect(formSheet).toBeVisible({ timeout: 10_000 });
|
|
await expectStableHeight(formSheet);
|
|
const hostTrigger = page.getByTestId("schedule-host-trigger");
|
|
const projectTrigger = page.getByTestId("schedule-project-trigger");
|
|
const modelTrigger = page.getByTestId("schedule-model-trigger");
|
|
const modeTrigger = page.getByTestId("schedule-mode-trigger");
|
|
|
|
await expect(hostTrigger).toContainText("Fake host", { timeout: 30_000 });
|
|
await expect(hostTrigger).toBeDisabled();
|
|
await expectSettled(hostTrigger);
|
|
await expect(projectTrigger).toContainText(fakeHost.projectDisplayName, { timeout: 30_000 });
|
|
await expectSettled(projectTrigger);
|
|
await expect(modelTrigger).toContainText(FAKE_HOST_MODEL_LABEL, { timeout: 30_000 });
|
|
await expectSettled(modelTrigger);
|
|
await expect(modeTrigger).toContainText("Load test", { timeout: 30_000 });
|
|
await expectSettled(modeTrigger);
|
|
await expect(page.getByTestId("cadence-mode")).toHaveCount(0);
|
|
await expect(page.getByTestId("schedule-cadence-preset-trigger")).toContainText("Daily 9:00");
|
|
});
|
|
|
|
test("create opens pristine after closing an edit form", async ({ page }) => {
|
|
const workspace = await seedWorkspace({ repoPrefix: "schedule-pristine-create-" });
|
|
cleanupTasks.push(() => workspace.cleanup());
|
|
const scheduleName = `Pristine create ${Date.now()}`;
|
|
const scheduleId = await seedMockSchedule(workspace, scheduleName);
|
|
cleanupTasks.push(() => deleteSeededSchedule(workspace, scheduleId));
|
|
|
|
await page.goto(buildSchedulesRoute());
|
|
const row = page.getByTestId(`schedule-row-${scheduleId}`);
|
|
await expect(row).toBeVisible({ timeout: 30_000 });
|
|
await row.click();
|
|
const formSheet = page.getByTestId("schedule-form-sheet");
|
|
await expect(formSheet).toBeVisible({ timeout: 10_000 });
|
|
await expectStableHeight(formSheet);
|
|
await page.getByRole("button", { name: "Cancel" }).click();
|
|
await expect(formSheet).toHaveCount(0, { timeout: 30_000 });
|
|
|
|
await page.getByTestId("schedules-new").click();
|
|
await expect(formSheet).toBeVisible({ timeout: 10_000 });
|
|
const projectTrigger = page.getByTestId("schedule-project-trigger");
|
|
await expect(projectTrigger).toContainText(/select project/i);
|
|
await expectSettled(projectTrigger);
|
|
await expect(page.getByTestId("schedule-model-trigger")).toHaveCount(0);
|
|
await expect(page.getByTestId("schedule-thinking-trigger")).toHaveCount(0);
|
|
await expect(page.getByTestId("schedule-mode-trigger")).toHaveCount(0);
|
|
await expect(page.getByTestId("cadence-interval-value")).toHaveCount(0);
|
|
});
|
|
});
|