Mohamed BoudraandGitHub
5a30affd7f
* fix(ci): skip unrelated required checks cleanly Matrix jobs had to start no-op runners to preserve interpolated required-check names. Static named jobs let GitHub report genuine skipped conclusions while keeping those names stable. * fix(ci): gate changes to install patching script * fix(ci): route cross-package test contracts narrowly * fix(ci): keep routed contracts merge-blocking * fix(server): exclude nested test utilities from builds * fix(ci): cover app-owned native and browser domains * refactor(ci): align tests with runtime domains Own browser specs, desktop specs, and Electron-only app code by stable directories so PR routing does not depend on filename conventions. Keep desktop integration coverage inside the required desktop check. * fix(ci): keep routing and desktop suites isolated The routing regression must run before dependency installation, and desktop Vitest must not collect Playwright-owned specs. * fix(ci): isolate desktop e2e runtime * perf(test): isolate Playwright workers * perf(test): parallelize Playwright within specs * fix(test): keep Playwright file scheduling * fix(test): share dynamic Metro fixture * fix(test): preserve own-host restart fixtures * fix(ci): preserve routed contracts after rebase * Stabilize Playwright wheel-scroll assertions
76 lines
3.1 KiB
TypeScript
76 lines
3.1 KiB
TypeScript
import { test, expect, type Page } from "../support/fixtures";
|
|
import { gotoAppShell } from "../support/helpers/app";
|
|
import { seedWorkspace } from "../support/helpers/seed-client";
|
|
import { getServerId } from "../support/helpers/server-id";
|
|
|
|
function workspaceRowTestId(workspaceId: string): string {
|
|
return `sidebar-workspace-row-${getServerId()}:${workspaceId}`;
|
|
}
|
|
|
|
function workspaceRenameModalTestId(workspaceId: string, suffix: string): string {
|
|
return `sidebar-workspace-rename-modal-${getServerId()}:${workspaceId}-${suffix}`;
|
|
}
|
|
|
|
async function openRenameModal(page: Page, workspaceId: string) {
|
|
const serverId = getServerId();
|
|
const row = page.getByTestId(`sidebar-workspace-row-${serverId}:${workspaceId}`);
|
|
await expect(row).toBeVisible({ timeout: 30_000 });
|
|
await row.hover();
|
|
|
|
const kebab = page.getByTestId(`sidebar-workspace-kebab-${serverId}:${workspaceId}`);
|
|
await expect(kebab).toBeVisible({ timeout: 10_000 });
|
|
await kebab.click();
|
|
|
|
const renameItem = page.getByTestId(`sidebar-workspace-menu-rename-${serverId}:${workspaceId}`);
|
|
await expect(renameItem).toBeVisible({ timeout: 10_000 });
|
|
await renameItem.click();
|
|
|
|
const input = page.getByTestId(workspaceRenameModalTestId(workspaceId, "input"));
|
|
await expect(input).toBeVisible({ timeout: 10_000 });
|
|
return input;
|
|
}
|
|
|
|
// In Model B the workspace title is its identity: renaming sets a custom title
|
|
// layered over the derived branch/directory name, and reconciliation never
|
|
// touches it. The sidebar row shows the title verbatim — no branch mutation.
|
|
test.describe("Sidebar workspace rename", () => {
|
|
test("renaming via kebab sets a custom title that survives reload", async ({ page }) => {
|
|
const workspace = await seedWorkspace({ repoPrefix: "sidebar-rename-" });
|
|
|
|
try {
|
|
expect(workspace.workspaceName).toBe("main");
|
|
|
|
await gotoAppShell(page);
|
|
await expect(page.getByTestId(workspaceRowTestId(workspace.workspaceId))).toBeVisible({
|
|
timeout: 30_000,
|
|
});
|
|
|
|
const input = await openRenameModal(page, workspace.workspaceId);
|
|
await expect(input).toHaveValue("main");
|
|
|
|
const customTitle = "Payments Refactor";
|
|
await input.fill(customTitle);
|
|
await page.getByTestId(workspaceRenameModalTestId(workspace.workspaceId, "submit")).click();
|
|
|
|
await expect(input).toHaveCount(0, { timeout: 15_000 });
|
|
// The title is shown exactly as typed — not slugified into a branch name.
|
|
await expect(page.getByTestId(workspaceRowTestId(workspace.workspaceId))).toContainText(
|
|
customTitle,
|
|
{ timeout: 15_000 },
|
|
);
|
|
|
|
// The custom title is backing metadata on the workspace: a full reload
|
|
// re-resolves the descriptor from persistence and must not lose it. This
|
|
// exercises the same descriptor resolution reconciliation re-runs against,
|
|
// so a reconcile pass cannot overwrite the user's title either.
|
|
await page.reload();
|
|
await expect(page.getByTestId(workspaceRowTestId(workspace.workspaceId))).toContainText(
|
|
customTitle,
|
|
{ timeout: 30_000 },
|
|
);
|
|
} finally {
|
|
await workspace.cleanup();
|
|
}
|
|
});
|
|
});
|