Mohamed Boudra
345638dc7f
Upgrading to 0.5.0-beta.1 left the old docked explorer sidebar showing next to the new explorer pane, with no way to dismiss it. The sidebar rendered off the persisted `desktop.fileExplorerOpen` flag. #3287 rerouted the explorer toggle to the workspace-layout explorer pane, so nothing on a wide layout ever wrote that flag false again, and no migration cleared it. Assistant directory links and review attachments could still set it. On Windows and Linux the sidebar's close button was suppressed because the OS window controls own the top-right corner, so there was no affordance at all. The explorer is now one surface picked from two facts — is the layout compact, and can the platform render split panes: compact -> slide-over overlay (panel store) non-compact + splits -> dedicated right pane (layout store) non-compact, no splits -> ordinary tabs in the focused pane `workspace-tabs/explorer-surface.ts` owns that choice and every entry point routes through it, so the toggle, Ctrl+E, Ctrl+., directory links, review attachments and side file opens can no longer disagree about where the explorer lives. Pane splits stay gated on `isWeb`: they depend on dnd-kit and DOM-backed accessibility helpers. Native tablets are non-compact without splits, so they get explorer tabs rather than a second pane — deliberately trading side-by-side agent and Changes for a surface that only renders what the single-column tab row can actually reach. Ctrl+. is handled by the workspace screen rather than the app shell. The pathname alone cannot identify the active workspace: desktop cold-starts at "/" and restores the remembered workspace from route params, so a key derived from the pathname is null exactly when a workspace is mounted, and the explorer reads as permanently closed. `desktop.fileExplorerOpen` and `explorerWidth` are dropped by a migration to panel-state v15 but stay declared in the persisted schema. That schema is a strict object and the validated storage deletes the whole entry when parsing fails, so removing the keys outright would wipe every upgrading user's sidebar width, expanded paths and diff-collapse state.
30 lines
857 B
TypeScript
30 lines
857 B
TypeScript
interface DesktopSidebarToggleInput {
|
|
isAgentListOpen: boolean;
|
|
isExplorerOpen: boolean;
|
|
openAgentList: () => void;
|
|
closeAgentList: () => void;
|
|
toggleExplorer: () => void;
|
|
}
|
|
|
|
/**
|
|
* "Toggle both sidebars" collapses the workspace to just its content when
|
|
* anything is showing, and restores both when nothing is. The explorer only
|
|
* exposes a toggle, so each side is nudged only when it is on the wrong side
|
|
* of the intent.
|
|
*/
|
|
export function toggleDesktopSidebarsWithCheckoutIntent(input: DesktopSidebarToggleInput): boolean {
|
|
const shouldOpen = !input.isAgentListOpen && !input.isExplorerOpen;
|
|
|
|
if (input.isAgentListOpen !== shouldOpen) {
|
|
if (shouldOpen) {
|
|
input.openAgentList();
|
|
} else {
|
|
input.closeAgentList();
|
|
}
|
|
}
|
|
if (input.isExplorerOpen !== shouldOpen) {
|
|
input.toggleExplorer();
|
|
}
|
|
return true;
|
|
}
|