Mohamed BoudraandGitHub
36312352db
* fix(app): validate persisted client state Persisted replica data could satisfy TypeScript through an assertion while missing fields required by renderers. Treat every AsyncStorage value as untrusted input, clear values that fail strict schemas, and version the replica DTO so incompatible caches cannot hydrate. * fix(app): preserve validated legacy state * fix(app): preserve validated preferences Preserve supported legacy location fields and every shipped theme while keeping unknown persisted fields rejected. Align browser test seeds with the current preference shape so strict validation exercises the intended provider. * fix(app): migrate legacy agent preferences Released clients stored host/location fields and per-provider thinkingOptionId together. Migrate those exact strict bytes into current preferences without admitting unknown fields. * fix(app): preserve drafts with legacy reviews Accept the exact strict shape released for workspace review attachments so migration can discard that obsolete attachment without clearing every persisted draft.
87 lines
3.2 KiB
TypeScript
87 lines
3.2 KiB
TypeScript
import { randomUUID } from "node:crypto";
|
|
import { metroTest as test } from "../support/fixtures";
|
|
import { buildCreateAgentPreferences, buildSeededHost } from "../support/helpers/daemon-registry";
|
|
import { startIsolatedHostDaemon } from "../support/helpers/isolated-host-daemon";
|
|
import type { MockAgentWorkspace } from "../support/helpers/mock-agent";
|
|
import { seedWorkspace } from "../support/helpers/seed-client";
|
|
import {
|
|
expectTimelinePromptVisible,
|
|
holdOlderHistoryPages,
|
|
openAgentTimeline,
|
|
scrollThroughOlderHistoryPages,
|
|
} from "../support/helpers/timeline-pagination";
|
|
|
|
test("does not repeat an assistant block when the current app paginates a published 0.2.5 daemon", async ({
|
|
page,
|
|
}) => {
|
|
test.setTimeout(120_000);
|
|
const serverId = `srv_old_pagination_${randomUUID().replaceAll("-", "").slice(0, 12)}`;
|
|
const daemon = await startIsolatedHostDaemon(serverId, { publishedVersion: "0.2.5" });
|
|
const workspace = await seedWorkspace({
|
|
repoPrefix: "timeline-old-daemon-pagination-",
|
|
port: daemon.port,
|
|
});
|
|
const createdAgent = await workspace.client.createAgent({
|
|
provider: "mock",
|
|
cwd: workspace.repoPath,
|
|
workspaceId: workspace.workspaceId,
|
|
title: "Published daemon pagination regression",
|
|
modeId: "load-test",
|
|
model: "ten-second-stream",
|
|
});
|
|
const agent: MockAgentWorkspace = {
|
|
agentId: createdAgent.id,
|
|
workspaceId: workspace.workspaceId,
|
|
cwd: workspace.repoPath,
|
|
client: workspace.client,
|
|
cleanup: workspace.cleanup,
|
|
};
|
|
|
|
try {
|
|
for (let index = 0; index < 40; index += 1) {
|
|
await agent.client.sendAgentMessage(
|
|
agent.agentId,
|
|
`timeline-pagination-older-turn-${index}: emit 1 coalesced agent stream updates`,
|
|
);
|
|
await agent.client.waitForFinish(agent.agentId, 15_000);
|
|
}
|
|
await agent.client.sendAgentMessage(agent.agentId, "build a realistic long mock timeline");
|
|
await agent.client.waitForFinish(agent.agentId, 20_000);
|
|
for (let index = 0; index < 20; index += 1) {
|
|
await agent.client.sendAgentMessage(
|
|
agent.agentId,
|
|
`timeline-pagination-turn-${index}: emit 1 coalesced agent stream updates`,
|
|
);
|
|
await agent.client.waitForFinish(agent.agentId, 15_000);
|
|
}
|
|
|
|
const host = buildSeededHost({
|
|
serverId,
|
|
endpoint: `127.0.0.1:${daemon.port}`,
|
|
nowIso: new Date().toISOString(),
|
|
});
|
|
await page.addInitScript(
|
|
({ seededHost, preferences }) => {
|
|
localStorage.setItem("@paseo:e2e", "1");
|
|
localStorage.setItem("@paseo:daemon-registry", JSON.stringify([seededHost]));
|
|
localStorage.setItem("@paseo:create-agent-preferences", JSON.stringify(preferences));
|
|
},
|
|
{ seededHost: host, preferences: buildCreateAgentPreferences() },
|
|
);
|
|
|
|
const history = await holdOlderHistoryPages(page, agent, daemon.port);
|
|
await openAgentTimeline(page, agent, serverId);
|
|
await expectTimelinePromptVisible(
|
|
page,
|
|
"timeline-pagination-turn-19: emit 1 coalesced agent stream updates",
|
|
);
|
|
await scrollThroughOlderHistoryPages(page, 3, history);
|
|
|
|
history.expectRepeatedEntries();
|
|
await history.expectOwnedTextRendered("Now I have a clearer picture.");
|
|
} finally {
|
|
await agent.cleanup();
|
|
await daemon.close();
|
|
}
|
|
});
|