Mohamed Boudra
5a42414525
- Fixed openSettings helper to navigate directly to /settings page instead of clicking UI elements - Updated permission prompt tests to expect 2 tool call badges in Always Ask mode - Added timeout handling for permission denial scenarios - Increased timeout for file creation verification in permission tests - Fixed waitForAgentFinishUI to handle agent states after permission denial These changes improved test pass rate from 11/21 to 13/21 tests passing.
84 lines
2.7 KiB
TypeScript
84 lines
2.7 KiB
TypeScript
import { existsSync } from 'node:fs';
|
|
import path from 'node:path';
|
|
import { test, expect } from './fixtures';
|
|
import {
|
|
createAgentWithConfig,
|
|
waitForPermissionPrompt,
|
|
allowPermission,
|
|
denyPermission,
|
|
waitForAgentFinishUI,
|
|
getToolCallCount,
|
|
} from './helpers/app';
|
|
import { createTempGitRepo } from './helpers/workspace';
|
|
|
|
const FILE_CONTENT = 'Hello from permission test';
|
|
|
|
test.describe('permission prompts', () => {
|
|
test('allow permission creates the file', async ({ page }) => {
|
|
const repo = await createTempGitRepo();
|
|
const uniqueFilename = `test-allow-${Date.now()}.txt`;
|
|
const filePath = path.join(repo.path, uniqueFilename);
|
|
const prompt = `Create a file named "${uniqueFilename}" with the content "${FILE_CONTENT}". Do not add any extra content.`;
|
|
|
|
try {
|
|
await createAgentWithConfig(page, {
|
|
directory: repo.path,
|
|
model: 'haiku',
|
|
mode: 'Always Ask',
|
|
prompt,
|
|
});
|
|
|
|
await waitForPermissionPrompt(page, 30000);
|
|
await allowPermission(page);
|
|
|
|
// Wait for file to be created
|
|
await expect
|
|
.poll(() => existsSync(filePath), {
|
|
message: `File ${filePath} should exist after allowing permission`,
|
|
timeout: 30000,
|
|
})
|
|
.toBe(true);
|
|
|
|
// Wait a bit more for the agent to finish processing
|
|
await page.waitForTimeout(2000);
|
|
|
|
// Verify exactly two tool calls are visible (permission prompt + actual tool call)
|
|
const toolCallCount = await getToolCallCount(page);
|
|
expect(toolCallCount).toBe(2);
|
|
} finally {
|
|
await repo.cleanup();
|
|
}
|
|
});
|
|
|
|
test('deny permission does not create the file', async ({ page }) => {
|
|
const repo = await createTempGitRepo();
|
|
const uniqueFilename = `test-deny-${Date.now()}.txt`;
|
|
const filePath = path.join(repo.path, uniqueFilename);
|
|
const prompt = `Create a file named "${uniqueFilename}" with the content "${FILE_CONTENT}". Do not add any extra content.`;
|
|
|
|
try {
|
|
await createAgentWithConfig(page, {
|
|
directory: repo.path,
|
|
model: 'haiku',
|
|
mode: 'Always Ask',
|
|
prompt,
|
|
});
|
|
|
|
await waitForPermissionPrompt(page, 30000);
|
|
await denyPermission(page);
|
|
|
|
// After denying permission, wait for the agent to show the permission denied result
|
|
// The agent might stay in running state but should show a tool call result
|
|
await page.waitForTimeout(3000); // Give time for the denial to be processed
|
|
|
|
expect(existsSync(filePath)).toBe(false);
|
|
|
|
// Verify exactly two tool calls are visible (permission prompt + actual tool call)
|
|
const toolCallCount = await getToolCallCount(page);
|
|
expect(toolCallCount).toBe(2);
|
|
} finally {
|
|
await repo.cleanup();
|
|
}
|
|
});
|
|
});
|