Mohamed BoudraandGitHub
0b78379b77
* test(server): add real-spawn round-trip for % in argv RED test: pass --format=%(refname)... through spawnProcess to a child node script that echoes argv[2]. Asserts the child receives the original string verbatim. Wired into the Windows CI matrix to expose the escapeWindowsCmdValue %-doubling bug under cmd.exe. * test(server): use bare 'node' command so cmd.exe path is exercised process.execPath has both an extension and a path separator on Windows, so shouldUseWindowsShell returns false and the broken %-escape pipeline is never invoked. Use the bare command name 'node' instead. * fix(server): stop doubling % in cmd.exe arg escaping on Windows cmd.exe only collapses `%%` → `%` inside batch files; on the command line / via `cmd /c "..."` `%%` stays literal. Doubling `%` in escapeWindowsCmdValue meant args like `--format=%(refname)` reached git as `--format=%%(refname)`, which git interprets as the escape sequence for a literal `%`, so format atoms appeared verbatim and the branch picker showed `%(refname)%09%(committerdate:unix)` instead of branch names. Update unit tests that pinned the broken doubling behavior.
50 lines
1.7 KiB
TypeScript
50 lines
1.7 KiB
TypeScript
import { mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import path from "node:path";
|
|
import { afterEach, describe, expect, test } from "vitest";
|
|
|
|
import { execCommand } from "./spawn.js";
|
|
|
|
const tempDirs: string[] = [];
|
|
|
|
afterEach(() => {
|
|
for (const dir of tempDirs.splice(0)) {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
function writeEchoArgScript(): string {
|
|
const dir = mkdtempSync(path.join(tmpdir(), "paseo-percent-escape-"));
|
|
tempDirs.push(dir);
|
|
const scriptPath = path.join(dir, "echo-arg.js");
|
|
writeFileSync(scriptPath, "process.stdout.write(process.argv[2] ?? '');\n");
|
|
return scriptPath;
|
|
}
|
|
|
|
// Use the bare command name "node" (no extension, no path separator) so
|
|
// `shouldUseWindowsShell` resolves to true on Windows. That routes the spawn
|
|
// through cmd.exe and exercises `quoteWindowsArgument`, which is where the
|
|
// %-doubling bug lives. Using `process.execPath` here would skip the shell
|
|
// path entirely and silently pass the test.
|
|
const COMMAND = "node";
|
|
|
|
describe("spawn argument escaping for % characters", () => {
|
|
test("delivers a git for-each-ref --format atom to the child verbatim", async () => {
|
|
const scriptPath = writeEchoArgScript();
|
|
const formatArg = "--format=%(refname)%09%(committerdate:unix)";
|
|
|
|
const { stdout } = await execCommand(COMMAND, [scriptPath, formatArg]);
|
|
|
|
expect(stdout).toBe(formatArg);
|
|
});
|
|
|
|
test("delivers a bare percent-prefixed token to the child verbatim", async () => {
|
|
const scriptPath = writeEchoArgScript();
|
|
const arg = "%(refname)";
|
|
|
|
const { stdout } = await execCommand(COMMAND, [scriptPath, arg]);
|
|
|
|
expect(stdout).toBe(arg);
|
|
});
|
|
});
|