* Make workspace IDs opaque, independent of the filesystem path Workspace IDs were the resolved checkout/worktree path, so code could treat an ID as a path: prefix matching, deriving directories from it, falling back to a path when a lookup missed. IDs are now opaque - compared only by exact equality and never used as a path. Anything path-shaped resolves the workspace record first and reads its cwd. New workspaces get a generated `wks_` ID; existing path-shaped IDs are read from disk and never regenerated, so there is no migration and no change to the wire or persisted schemas. Groundwork for running multiple workspaces in a single directory. * Keep attachment scope key stable and align refetch test The attachment scope key keeps `workspace=` instead of `wsid=` so existing persisted drafts are not orphaned; the rename was cosmetic. The SDK refetch test no longer asserts a filter, matching refetch fetching one page and selecting by id client-side. * Fix live agent updates in directories without a registered workspace The opaque-ID work removed buildProjectPlacementForCwd's directory fallback, so an agent running in a folder with no registered workspace (e.g. a fresh non-git dir) produced a null placement. forwardAgentUpdate then threw "Workspace not found", the error was swallowed by its catch, and no agent_update was emitted — live model/thinking switches and status updates silently stopped. Caught by the live-preferences e2e suite. The fallback builds a directory-scoped project placement keyed by the path. That key is a project grouping key (non-git projects group by path), not a workspace id, so it stays within the opaque-id rule. * Always run server worktree archive, even without a resolved workspace Archiving bailed out entirely when the workspace was not found in the client store, so a race or stale state could make "archive" do nothing server-side with only a console.warn. The server archive is keyed by worktreePath, which is always available, so it now runs regardless; only the optimistic client-side updates (keyed by workspace id) are gated on the workspace being resolved. * Expect a directory-scoped placement for unregistered agent dirs This unit test asserted the no-placement behavior reverted in the live agent-update fix, which had broken live model/thinking switching. Update it to expect the directory-scoped placement now emitted for an agent in a directory with no registered workspace. * Fix opaque workspace routing in app E2E * Preserve workspace IDs during partial bootstrap * Fix archive flows for opaque workspace IDs * Stop treating opaque workspace IDs as filesystem paths Workspace IDs are opaque (wks_<hex>), but several call sites still passed the id where a directory was expected, which broke those flows for opaque IDs. The branch switcher sent the id as a cwd to branch/stash/checkout git operations, and server archive/reconcile cleanup keyed git-watch and subscription teardown by id, leaking that state. Git and filesystem operations now take the workspace directory; the opaque id is used only for identity and cache keys. Archive/reconcile cleanup routes through a single teardownArchivedWorkspace helper that keeps the key split explicit: runtime store by id, git watch and subscription by cwd. Path-derived grouping keys are renamed to directory keys, and the helpers are split into workspace-identity and workspace-directory so the id-vs-path boundary is obvious.
76 lines
3.0 KiB
TypeScript
76 lines
3.0 KiB
TypeScript
import { randomUUID } from "node:crypto";
|
|
import { test, expect, type Page } from "./fixtures";
|
|
import { seedWorkspace } from "./helpers/seed-client";
|
|
import { createIdleAgent, expectWorkspaceTabVisible } from "./helpers/archive-tab";
|
|
import { waitForWorkspaceTabsVisible } from "./helpers/workspace-tabs";
|
|
import { buildHostAgentDetailRoute } from "@/utils/host-routes";
|
|
import { captureWsSessionFrames, renameModalInput, renameModalSubmit } from "./helpers/rename";
|
|
import { getServerId } from "./helpers/server-id";
|
|
|
|
async function openAgentInWorkspace(page: Page, agent: { id: string; workspaceId: string }) {
|
|
await page.goto(buildHostAgentDetailRoute(getServerId(), agent.id, agent.workspaceId));
|
|
await page.waitForURL(
|
|
(url) => url.pathname.includes("/workspace/") && !url.searchParams.has("open"),
|
|
{ timeout: 60_000 },
|
|
);
|
|
await waitForWorkspaceTabsVisible(page);
|
|
await expectWorkspaceTabVisible(page, agent.id);
|
|
}
|
|
|
|
test.describe("Workspace agent tab rename", () => {
|
|
test("right-click rename sends update_agent_request and updates the tab label", async ({
|
|
page,
|
|
}) => {
|
|
test.setTimeout(120_000);
|
|
|
|
const workspace = await seedWorkspace({ repoPrefix: "workspace-agent-rename-" });
|
|
|
|
try {
|
|
const initialTitle = `agent-rename-${randomUUID().slice(0, 8)}`;
|
|
const agent = await createIdleAgent(workspace.client, {
|
|
cwd: workspace.repoPath,
|
|
title: initialTitle,
|
|
});
|
|
|
|
const updateFrames = captureWsSessionFrames(page, "update_agent_request", (inner) => ({
|
|
agentId: String(inner.agentId ?? ""),
|
|
name: String(inner.name ?? ""),
|
|
requestId: String(inner.requestId ?? ""),
|
|
}));
|
|
|
|
await openAgentInWorkspace(page, agent);
|
|
|
|
const tab = page.getByTestId(`workspace-tab-agent_${agent.id}`).first();
|
|
await expect(tab).toContainText(initialTitle, { timeout: 15_000 });
|
|
|
|
await tab.click({ button: "right" });
|
|
await expect(page.getByTestId(`workspace-tab-context-agent_${agent.id}`)).toBeVisible({
|
|
timeout: 10_000,
|
|
});
|
|
const renameItem = page.getByTestId(`workspace-tab-context-agent_${agent.id}-rename`);
|
|
await expect(renameItem).toBeVisible({ timeout: 10_000 });
|
|
await renameItem.click();
|
|
|
|
const modalPrefix = `workspace-tab-rename-modal-agent-${agent.id}`;
|
|
const input = renameModalInput(page, modalPrefix);
|
|
await expect(input).toBeVisible({ timeout: 10_000 });
|
|
await expect(input).toHaveValue(initialTitle);
|
|
|
|
const renamed = "My Renamed Agent";
|
|
await input.fill(renamed);
|
|
await renameModalSubmit(page, modalPrefix).click();
|
|
|
|
await expect(input).toHaveCount(0, { timeout: 15_000 });
|
|
await expect(tab).toContainText(renamed, { timeout: 15_000 });
|
|
|
|
expect(updateFrames.length).toBeGreaterThan(0);
|
|
const lastFrame = updateFrames.at(-1)!;
|
|
expect(lastFrame.agentId).toBe(agent.id);
|
|
expect(lastFrame.name).toBe(renamed);
|
|
expect(lastFrame.requestId.length).toBeGreaterThan(0);
|
|
} finally {
|
|
await workspace.cleanup();
|
|
}
|
|
});
|
|
});
|