"Open in browser" links for a self-hosted forge served on a non-standard port (e.g. Forgejo/Gitea on :60443) dropped the port, producing https://host/owner/repo/... instead of https://host:60443/owner/repo/..., which 404s or hits the wrong service. parseGitRemoteLocation discarded parsed.port (GitRemoteLocation had no port field), and buildForgeBranchTreeUrl / buildForgeBlobUrl rebuilt the origin from the portless host. Preserve the port on GitRemoteLocation and reattach it in the web-URL builders, only for self-hosted http(s) origins (an SSH port isn't the web port; a canonicalized cloud host uses the default port). Host-identity matching (forge detection, cloud-host checks) stays port-agnostic. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
236 lines
7.1 KiB
TypeScript
236 lines
7.1 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import { buildForgeBlobUrl, buildForgeBranchTreeUrl, hasForgeWebUrls } from "./forge-url";
|
|
|
|
describe("buildForgeBranchTreeUrl", () => {
|
|
it("builds a branch-specific GitHub tree URL", () => {
|
|
expect(
|
|
buildForgeBranchTreeUrl("github", {
|
|
remoteUrl: "git@github.com:acme/repo.git",
|
|
branch: "feature/workspace-button",
|
|
}),
|
|
).toBe("https://github.com/acme/repo/tree/feature/workspace-button");
|
|
});
|
|
|
|
it("encodes reserved branch characters while preserving slash-separated branch names", () => {
|
|
expect(
|
|
buildForgeBranchTreeUrl("github", {
|
|
remoteUrl: "https://github.com/acme/repo.git",
|
|
branch: "feature/ship #42",
|
|
}),
|
|
).toBe("https://github.com/acme/repo/tree/feature/ship%20%2342");
|
|
});
|
|
|
|
it("uses the GitLab /-/tree/ infix and supports subgroups", () => {
|
|
expect(
|
|
buildForgeBranchTreeUrl("gitlab", {
|
|
remoteUrl: "https://gitlab.com/group/sub/repo.git",
|
|
branch: "main",
|
|
}),
|
|
).toBe("https://gitlab.com/group/sub/repo/-/tree/main");
|
|
});
|
|
|
|
it("uses the Gitea-family /src/branch/ infix", () => {
|
|
expect(
|
|
buildForgeBranchTreeUrl("gitea", {
|
|
remoteUrl: "https://gitea.com/acme/repo.git",
|
|
branch: "main",
|
|
}),
|
|
).toBe("https://gitea.com/acme/repo/src/branch/main");
|
|
expect(
|
|
buildForgeBranchTreeUrl("codeberg", {
|
|
remoteUrl: "https://codeberg.org/acme/repo.git",
|
|
branch: "main",
|
|
}),
|
|
).toBe("https://codeberg.org/acme/repo/src/branch/main");
|
|
});
|
|
|
|
it("preserves a non-default port for a self-hosted https remote", () => {
|
|
expect(
|
|
buildForgeBranchTreeUrl("forgejo", {
|
|
remoteUrl: "https://home-git.example.com:60443/team/repo.git",
|
|
branch: "master",
|
|
}),
|
|
).toBe("https://home-git.example.com:60443/team/repo/src/branch/master");
|
|
});
|
|
|
|
it("omits the port for a self-hosted remote on the default port", () => {
|
|
expect(
|
|
buildForgeBranchTreeUrl("forgejo", {
|
|
remoteUrl: "https://home-git.example.com/team/repo.git",
|
|
branch: "master",
|
|
}),
|
|
).toBe("https://home-git.example.com/team/repo/src/branch/master");
|
|
});
|
|
|
|
it("returns null when the current branch is unavailable", () => {
|
|
expect(
|
|
buildForgeBranchTreeUrl("github", {
|
|
remoteUrl: "https://github.com/acme/repo.git",
|
|
branch: "HEAD",
|
|
}),
|
|
).toBeNull();
|
|
});
|
|
|
|
it("returns null for a forge with no known URL grammar", () => {
|
|
expect(
|
|
buildForgeBranchTreeUrl("bitbucket", {
|
|
remoteUrl: "https://bitbucket.org/acme/repo.git",
|
|
branch: "main",
|
|
}),
|
|
).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("buildForgeBlobUrl", () => {
|
|
it("builds a blob URL for a file path", () => {
|
|
expect(
|
|
buildForgeBlobUrl("github", {
|
|
remoteUrl: "git@github.com:acme/repo.git",
|
|
branch: "main",
|
|
path: "src/index.ts",
|
|
}),
|
|
).toBe("https://github.com/acme/repo/blob/main/src/index.ts");
|
|
});
|
|
|
|
it("appends a single-line anchor", () => {
|
|
expect(
|
|
buildForgeBlobUrl("github", {
|
|
remoteUrl: "https://github.com/acme/repo.git",
|
|
branch: "main",
|
|
path: "src/index.ts",
|
|
lineStart: 12,
|
|
}),
|
|
).toBe("https://github.com/acme/repo/blob/main/src/index.ts#L12");
|
|
});
|
|
|
|
it("appends a GitHub line range anchor (#L12-L20)", () => {
|
|
expect(
|
|
buildForgeBlobUrl("github", {
|
|
remoteUrl: "https://github.com/acme/repo.git",
|
|
branch: "main",
|
|
path: "src/index.ts",
|
|
lineStart: 12,
|
|
lineEnd: 20,
|
|
}),
|
|
).toBe("https://github.com/acme/repo/blob/main/src/index.ts#L12-L20");
|
|
});
|
|
|
|
it("uses the GitLab /-/blob/ infix and #L12-20 range anchor", () => {
|
|
expect(
|
|
buildForgeBlobUrl("gitlab", {
|
|
remoteUrl: "https://gitlab.com/group/sub/repo.git",
|
|
branch: "main",
|
|
path: "src/index.ts",
|
|
lineStart: 12,
|
|
lineEnd: 20,
|
|
}),
|
|
).toBe("https://gitlab.com/group/sub/repo/-/blob/main/src/index.ts#L12-20");
|
|
});
|
|
|
|
it("uses the Gitea-family /src/branch/ blob path with a #L12-L20 anchor", () => {
|
|
expect(
|
|
buildForgeBlobUrl("forgejo", {
|
|
remoteUrl: "https://codeberg.org/acme/repo.git",
|
|
branch: "main",
|
|
path: "src/index.ts",
|
|
lineStart: 12,
|
|
lineEnd: 20,
|
|
}),
|
|
).toBe("https://codeberg.org/acme/repo/src/branch/main/src/index.ts#L12-L20");
|
|
});
|
|
|
|
it("derives the web host from a self-hosted remote (GitHub Enterprise)", () => {
|
|
expect(
|
|
buildForgeBlobUrl("github", {
|
|
remoteUrl: "git@github.acme.internal:team/repo.git",
|
|
branch: "main",
|
|
path: "src/index.ts",
|
|
}),
|
|
).toBe("https://github.acme.internal/team/repo/blob/main/src/index.ts");
|
|
});
|
|
|
|
it("preserves a non-default port for a self-hosted https remote", () => {
|
|
expect(
|
|
buildForgeBlobUrl("forgejo", {
|
|
remoteUrl: "https://home-git.example.com:60443/team/repo.git",
|
|
branch: "master",
|
|
path: "src/index.ts",
|
|
lineStart: 12,
|
|
lineEnd: 20,
|
|
}),
|
|
).toBe("https://home-git.example.com:60443/team/repo/src/branch/master/src/index.ts#L12-L20");
|
|
});
|
|
|
|
it("canonicalizes the github.com SSH-alias host to the web host", () => {
|
|
expect(
|
|
buildForgeBlobUrl("github", {
|
|
remoteUrl: "ssh://git@ssh.github.com/acme/repo.git",
|
|
branch: "main",
|
|
path: "src/index.ts",
|
|
}),
|
|
).toBe("https://github.com/acme/repo/blob/main/src/index.ts");
|
|
});
|
|
|
|
it("strips leading slashes and encodes path segments", () => {
|
|
expect(
|
|
buildForgeBlobUrl("github", {
|
|
remoteUrl: "https://github.com/acme/repo.git",
|
|
branch: "main",
|
|
path: "/src/a b/c#d.ts",
|
|
}),
|
|
).toBe("https://github.com/acme/repo/blob/main/src/a%20b/c%23d.ts");
|
|
});
|
|
|
|
it("normalizes harmless dot segments in the blob path", () => {
|
|
expect(
|
|
buildForgeBlobUrl("github", {
|
|
remoteUrl: "https://github.com/acme/repo.git",
|
|
branch: "main",
|
|
path: "./src/../index.ts",
|
|
}),
|
|
).toBe("https://github.com/acme/repo/blob/main/index.ts");
|
|
});
|
|
|
|
it("returns null for blob paths that escape above the repo root", () => {
|
|
expect(
|
|
buildForgeBlobUrl("github", {
|
|
remoteUrl: "https://github.com/acme/repo.git",
|
|
branch: "main",
|
|
path: "../outside.ts",
|
|
}),
|
|
).toBeNull();
|
|
});
|
|
|
|
it("returns null when the path is missing", () => {
|
|
expect(
|
|
buildForgeBlobUrl("github", {
|
|
remoteUrl: "https://github.com/acme/repo.git",
|
|
branch: "main",
|
|
path: "",
|
|
}),
|
|
).toBeNull();
|
|
});
|
|
|
|
it("returns null for a forge with no known URL grammar", () => {
|
|
expect(
|
|
buildForgeBlobUrl("bitbucket", {
|
|
remoteUrl: "https://bitbucket.org/acme/repo.git",
|
|
branch: "main",
|
|
path: "src/index.ts",
|
|
}),
|
|
).toBeNull();
|
|
});
|
|
});
|
|
|
|
describe("hasForgeWebUrls", () => {
|
|
it("is true for forges with a known URL grammar", () => {
|
|
for (const forge of ["github", "gitlab", "gitea", "forgejo", "codeberg"]) {
|
|
expect(hasForgeWebUrls(forge)).toBe(true);
|
|
}
|
|
});
|
|
|
|
it("is false for an unknown forge", () => {
|
|
expect(hasForgeWebUrls("bitbucket")).toBe(false);
|
|
});
|
|
});
|