Mohamed BoudraandGitHub
5a30affd7f
* fix(ci): skip unrelated required checks cleanly Matrix jobs had to start no-op runners to preserve interpolated required-check names. Static named jobs let GitHub report genuine skipped conclusions while keeping those names stable. * fix(ci): gate changes to install patching script * fix(ci): route cross-package test contracts narrowly * fix(ci): keep routed contracts merge-blocking * fix(server): exclude nested test utilities from builds * fix(ci): cover app-owned native and browser domains * refactor(ci): align tests with runtime domains Own browser specs, desktop specs, and Electron-only app code by stable directories so PR routing does not depend on filename conventions. Keep desktop integration coverage inside the required desktop check. * fix(ci): keep routing and desktop suites isolated The routing regression must run before dependency installation, and desktop Vitest must not collect Playwright-owned specs. * fix(ci): isolate desktop e2e runtime * perf(test): isolate Playwright workers * perf(test): parallelize Playwright within specs * fix(test): keep Playwright file scheduling * fix(test): share dynamic Metro fixture * fix(test): preserve own-host restart fixtures * fix(ci): preserve routed contracts after rebase * Stabilize Playwright wheel-scroll assertions
46 lines
1.8 KiB
TypeScript
46 lines
1.8 KiB
TypeScript
import { expect, type Page } from "@playwright/test";
|
|
import type { PinnedTabTarget } from "../../../src/workspace-pins/target";
|
|
import { pinnedTargetKey } from "../../../src/workspace-pins/target";
|
|
|
|
// The new-tab dropdown menu items carry no stable web ARIA role for the inline
|
|
// pin toggle (it lives inside a reveal-on-hover slot), so the pins flow is
|
|
// addressed through the test ids the feature assigns per target key — the same
|
|
// escape-hatch convention the sidebar kebab and tab context menus use.
|
|
|
|
function pinToggle(page: Page, target: PinnedTabTarget) {
|
|
return page.getByTestId(`workspace-pin-toggle-${pinnedTargetKey(target)}`);
|
|
}
|
|
|
|
function menuItemFor(page: Page, target: PinnedTabTarget) {
|
|
if (target.kind === "draft") {
|
|
return page.getByTestId("workspace-new-tab-menu-agent");
|
|
}
|
|
return page.getByTestId(`workspace-new-tab-menu-${target.kind}`);
|
|
}
|
|
|
|
export function tabRowPin(page: Page, target: PinnedTabTarget) {
|
|
return page.getByTestId(`workspace-pinned-target-${pinnedTargetKey(target)}`);
|
|
}
|
|
|
|
export async function openNewTabMenu(page: Page): Promise<void> {
|
|
const trigger = page
|
|
.getByTestId("workspace-new-tab-menu-trigger")
|
|
.filter({ visible: true })
|
|
.first();
|
|
await expect(trigger).toBeVisible({ timeout: 10_000 });
|
|
await trigger.click();
|
|
}
|
|
|
|
// The pin toggle is hidden behind reveal-on-hover (opacity + pointerEvents) on
|
|
// desktop web, so the menu item must be hovered before the toggle is clickable.
|
|
export async function togglePinFromMenu(page: Page, target: PinnedTabTarget): Promise<void> {
|
|
await openNewTabMenu(page);
|
|
const item = menuItemFor(page, target);
|
|
await expect(item).toBeVisible({ timeout: 10_000 });
|
|
await item.hover();
|
|
const toggle = pinToggle(page, target);
|
|
await expect(toggle).toBeVisible({ timeout: 10_000 });
|
|
await toggle.click();
|
|
await page.keyboard.press("Escape");
|
|
}
|