Mohamed BoudraandGitHub
5a30affd7f
* fix(ci): skip unrelated required checks cleanly Matrix jobs had to start no-op runners to preserve interpolated required-check names. Static named jobs let GitHub report genuine skipped conclusions while keeping those names stable. * fix(ci): gate changes to install patching script * fix(ci): route cross-package test contracts narrowly * fix(ci): keep routed contracts merge-blocking * fix(server): exclude nested test utilities from builds * fix(ci): cover app-owned native and browser domains * refactor(ci): align tests with runtime domains Own browser specs, desktop specs, and Electron-only app code by stable directories so PR routing does not depend on filename conventions. Keep desktop integration coverage inside the required desktop check. * fix(ci): keep routing and desktop suites isolated The routing regression must run before dependency installation, and desktop Vitest must not collect Playwright-owned specs. * fix(ci): isolate desktop e2e runtime * perf(test): isolate Playwright workers * perf(test): parallelize Playwright within specs * fix(test): keep Playwright file scheduling * fix(test): share dynamic Metro fixture * fix(test): preserve own-host restart fixtures * fix(ci): preserve routed contracts after rebase * Stabilize Playwright wheel-scroll assertions
102 lines
3.2 KiB
TypeScript
102 lines
3.2 KiB
TypeScript
import { expect, test, type Page } from "../../app/e2e/support/fixtures";
|
|
import { gotoAppShell } from "../../app/e2e/support/helpers/app";
|
|
import {
|
|
readRails,
|
|
readSheetHeaderRails,
|
|
readVerticalGap,
|
|
waitForSettledPosition,
|
|
} from "../../app/e2e/support/helpers/sheet-layout";
|
|
import {
|
|
openCompactSkillsIntegrations,
|
|
openSkillSelection,
|
|
openSkillsIntegrations,
|
|
startSkillsSandbox,
|
|
type SkillsSandbox,
|
|
} from "./support/skills-selection";
|
|
|
|
const COMPACT_VIEWPORT = { width: 390, height: 844 };
|
|
const DESKTOP_VIEWPORT = { width: 1280, height: 900 };
|
|
|
|
const sandboxes: SkillsSandbox[] = [];
|
|
|
|
test.afterEach(async () => {
|
|
for (const sandbox of sandboxes.splice(0)) {
|
|
await sandbox.cleanup();
|
|
}
|
|
});
|
|
|
|
async function openChooseSkillsOnPhone(page: Page): Promise<void> {
|
|
sandboxes.push(await startSkillsSandbox(page));
|
|
await gotoAppShell(page);
|
|
await openCompactSkillsIntegrations(page);
|
|
await openSkillSelection(page);
|
|
await waitForSettledPosition(page.getByTestId("skill-selection-sheet"));
|
|
}
|
|
|
|
async function openChooseSkillsOnDesktop(page: Page): Promise<void> {
|
|
sandboxes.push(await startSkillsSandbox(page));
|
|
await gotoAppShell(page);
|
|
await openSkillsIntegrations(page);
|
|
await openSkillSelection(page);
|
|
}
|
|
|
|
function sheetHeaderRails(page: Page) {
|
|
return readSheetHeaderRails(page, "skill-selection-sheet", "Choose skills");
|
|
}
|
|
|
|
function allSkillsCard(page: Page) {
|
|
return page.getByTestId("skill-selection-all-card");
|
|
}
|
|
|
|
function skillListCard(page: Page) {
|
|
return page.getByTestId("skill-selection-list-card");
|
|
}
|
|
|
|
function bundledSkillsLabel(page: Page) {
|
|
return page.getByText("Bundled skills", { exact: true });
|
|
}
|
|
|
|
test.describe("Choose skills sheet on a compact form factor", () => {
|
|
test.use({ viewport: COMPACT_VIEWPORT });
|
|
|
|
test("keeps its cards on the sheet header rails", async ({ page }) => {
|
|
await openChooseSkillsOnPhone(page);
|
|
|
|
const header = await sheetHeaderRails(page);
|
|
|
|
expect(await readRails(allSkillsCard(page))).toEqual(header);
|
|
expect(await readRails(skillListCard(page))).toEqual(header);
|
|
});
|
|
|
|
test("gives the Bundled skills label more room above it than below", async ({ page }) => {
|
|
await openChooseSkillsOnPhone(page);
|
|
|
|
expect({
|
|
aboveLabel: await readVerticalGap(allSkillsCard(page), bundledSkillsLabel(page)),
|
|
belowLabel: await readVerticalGap(bundledSkillsLabel(page), skillListCard(page)),
|
|
}).toEqual({ aboveLabel: 16, belowLabel: 12 });
|
|
});
|
|
});
|
|
|
|
test.describe("Choose skills sheet on a desktop form factor", () => {
|
|
test.use({ viewport: DESKTOP_VIEWPORT });
|
|
|
|
test("keeps its cards on the sheet header rails", async ({ page }) => {
|
|
await openChooseSkillsOnDesktop(page);
|
|
|
|
const header = await sheetHeaderRails(page);
|
|
|
|
expect(await readRails(allSkillsCard(page))).toEqual(header);
|
|
expect(await readRails(skillListCard(page))).toEqual(header);
|
|
});
|
|
|
|
test("gives the Bundled skills label more room above it than below", async ({ page }) => {
|
|
await openChooseSkillsOnDesktop(page);
|
|
|
|
expect({
|
|
aboveLabel: await readVerticalGap(allSkillsCard(page), bundledSkillsLabel(page)),
|
|
belowLabel: await readVerticalGap(bundledSkillsLabel(page), skillListCard(page)),
|
|
}).toEqual({ aboveLabel: 16, belowLabel: 12 });
|
|
});
|
|
});
|