* fix(app): keep timeline history and previews stable Treat persisted timeline replicas as display-only so authoritative pagination always comes from the daemon. Require renewed user intent between older-history pages unless the viewport genuinely remains at the history edge. Model assistant image acquisition as loading, loaded, or failed so recreating a preview URL cannot be rendered as an error. * fix(app): keep file image previews current * fix(app): stabilize history pagination edges * fix(app): recover transient timeline loads * fix(app): retain assistant image previews * Stabilize history pagination lifecycle * Stabilize history settlement and image previews * Retry file images after reconnect * Keep active previews and pagination requests alive * Replace image hook tests with typed ports * Integrate timeline hydration with submission authority * Harden pre-hydration timeline reconciliation * Make rewind E2E use real scroll intent * Preserve live timeline state through hydration * Keep mounted image attachments retained * Protect preview persistence and lifecycle hydration * Preserve idless live assistant continuations * Preserve timeline rows across delayed hydration * test(app): cover real assistant image files * Preserve assistant tool ordering during hydration
293 lines
11 KiB
TypeScript
293 lines
11 KiB
TypeScript
import type { Locator } from "@playwright/test";
|
|
import { expect, test, type Page } from "./fixtures";
|
|
import { openAgentRoute, seedMockAgentWorkspace } from "./helpers/mock-agent";
|
|
import { installDaemonWebSocketGate } from "./helpers/daemon-websocket-gate";
|
|
import { scrollChatAwayFromBottom } from "./helpers/agent-bottom-anchor";
|
|
import {
|
|
composerLocator,
|
|
expectComposerDraft,
|
|
expectComposerVisible,
|
|
fillComposerDraft,
|
|
submitMessage,
|
|
} from "./helpers/composer";
|
|
|
|
// UI plumbing contract against the dev mock provider. Real-provider behavior is tested in `daemon-e2e/*-rewind.real.e2e.test.ts`.
|
|
|
|
async function expectUserMessageCount(page: Page, expected: number): Promise<void> {
|
|
await expect(page.getByTestId("user-message")).toHaveCount(expected);
|
|
}
|
|
|
|
function userMessage(page: Page, text: string): Locator {
|
|
return page.getByTestId("user-message").filter({ hasText: text });
|
|
}
|
|
|
|
async function expectUserMessageVisible(page: Page, text: string): Promise<void> {
|
|
await expect(userMessage(page, text)).toBeVisible();
|
|
}
|
|
|
|
async function rewriteCachedMessageAsLegacyRow(page: Page, prompt: string): Promise<void> {
|
|
await expect
|
|
.poll(() =>
|
|
page.evaluate((messageText) => {
|
|
const raw = localStorage.getItem("@paseo:replica-cache");
|
|
if (!raw) return false;
|
|
const cache = JSON.parse(raw) as {
|
|
hosts?: Array<{ timeline?: { items?: Array<Record<string, unknown>> } | null }>;
|
|
};
|
|
for (const host of cache.hosts ?? []) {
|
|
for (const item of host.timeline?.items ?? []) {
|
|
if (item.kind === "user_message" && item.text === messageText && item.messageId) {
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
return false;
|
|
}, prompt),
|
|
)
|
|
.toBe(true);
|
|
|
|
await page.evaluate((messageText) => {
|
|
const key = "@paseo:replica-cache";
|
|
const raw = localStorage.getItem(key);
|
|
if (!raw) throw new Error("Replica cache was not persisted");
|
|
const cache = JSON.parse(raw) as {
|
|
hosts?: Array<{ timeline?: { items?: Array<Record<string, unknown>> } | null }>;
|
|
};
|
|
const cachedMessage = cache.hosts
|
|
?.flatMap((host) => host.timeline?.items ?? [])
|
|
.find((item) => item.kind === "user_message" && item.text === messageText);
|
|
if (!cachedMessage) throw new Error("Cached user message was not found");
|
|
delete cachedMessage.messageId;
|
|
localStorage.setItem(key, JSON.stringify(cache));
|
|
}, prompt);
|
|
}
|
|
|
|
async function waitForCurrentSubmissionExcludedFromCache(
|
|
page: Page,
|
|
prompt: string,
|
|
): Promise<void> {
|
|
await expect
|
|
.poll(() =>
|
|
page.evaluate((messageText) => {
|
|
const raw = localStorage.getItem("@paseo:replica-cache");
|
|
if (!raw) return false;
|
|
const cache = JSON.parse(raw) as {
|
|
hosts?: Array<{ timeline?: { items?: Array<Record<string, unknown>> } | null }>;
|
|
};
|
|
return !cache.hosts
|
|
?.flatMap((host) => host.timeline?.items ?? [])
|
|
.some(
|
|
(item) =>
|
|
item.kind === "user_message" &&
|
|
item.text === messageText &&
|
|
typeof item.clientMessageId === "string" &&
|
|
item.messageId === undefined,
|
|
);
|
|
}, prompt),
|
|
)
|
|
.toBe(true);
|
|
}
|
|
|
|
async function waitForCachedMessageWithoutProviderId(page: Page, prompt: string): Promise<void> {
|
|
await expect
|
|
.poll(() =>
|
|
page.evaluate((messageText) => {
|
|
const raw = localStorage.getItem("@paseo:replica-cache");
|
|
if (!raw) return false;
|
|
const cache = JSON.parse(raw) as {
|
|
hosts?: Array<{ timeline?: { items?: Array<Record<string, unknown>> } | null }>;
|
|
};
|
|
return cache.hosts
|
|
?.flatMap((host) => host.timeline?.items ?? [])
|
|
.some(
|
|
(item) =>
|
|
item.kind === "user_message" &&
|
|
item.text === messageText &&
|
|
item.messageId === undefined,
|
|
);
|
|
}, prompt),
|
|
)
|
|
.toBe(true);
|
|
}
|
|
|
|
async function expectPendingSubmissionNotRestoredAfterReload(page: Page): Promise<void> {
|
|
const prompt = "Keep this cached submission pending.";
|
|
const gate = await installDaemonWebSocketGate(page);
|
|
const session = await seedMockAgentWorkspace({
|
|
repoPrefix: "rewind-current-cache-e2e-",
|
|
title: "Current cache submission e2e",
|
|
});
|
|
|
|
try {
|
|
await openAgentRoute(page, session);
|
|
await expectComposerVisible(page);
|
|
gate.holdNextClientRequest("send_agent_message_request");
|
|
await submitMessage(page, prompt);
|
|
await gate.waitForHeldClientRequest();
|
|
await waitForCurrentSubmissionExcludedFromCache(page, prompt);
|
|
await gate.drop();
|
|
await page.reload();
|
|
|
|
await expect(userMessage(page, prompt)).toHaveCount(0);
|
|
} finally {
|
|
gate.restore();
|
|
await session.cleanup();
|
|
}
|
|
}
|
|
|
|
test.describe("Rewind sheet", () => {
|
|
test("does not restore a local-only submission from the display cache", async ({ page }) => {
|
|
await expectPendingSubmissionNotRestoredAfterReload(page);
|
|
});
|
|
|
|
test("does not invent rewind identity for an ID-less cached message", async ({ page }) => {
|
|
const prompt = "Restore this rewind identity from the legacy cache.";
|
|
const gate = await installDaemonWebSocketGate(page);
|
|
const session = await seedMockAgentWorkspace({
|
|
repoPrefix: "rewind-cache-upgrade-e2e-",
|
|
title: "Rewind cache upgrade e2e",
|
|
initialPrompt: prompt,
|
|
});
|
|
let heldTimelineRequest = false;
|
|
|
|
try {
|
|
await openAgentRoute(page, session);
|
|
await expectUserMessageVisible(page, prompt);
|
|
await rewriteCachedMessageAsLegacyRow(page, prompt);
|
|
gate.holdNextClientRequest("fetch_agent_timeline_request");
|
|
await page.reload();
|
|
await gate.waitForHeldClientRequest();
|
|
heldTimelineRequest = true;
|
|
|
|
const restoredMessage = userMessage(page, prompt);
|
|
await expect(restoredMessage).toBeVisible();
|
|
await restoredMessage.hover();
|
|
await expect(restoredMessage.getByTestId("rewind-menu-trigger")).toHaveCount(0);
|
|
await waitForCachedMessageWithoutProviderId(page, prompt);
|
|
} finally {
|
|
if (heldTimelineRequest) gate.releaseHeldClientRequest();
|
|
gate.restore();
|
|
await session.cleanup();
|
|
}
|
|
});
|
|
|
|
test("rewinds from a user message sheet option", async ({ page }) => {
|
|
const firstPrompt = "emit 1 coalesced agent stream updates for first rewind turn.";
|
|
const secondPrompt = "Prepare deleted rewind turn assistant content.";
|
|
const replacementPrompt = "emit 1 coalesced agent stream updates for replacement rewind turn.";
|
|
const session = await seedMockAgentWorkspace({
|
|
repoPrefix: "rewind-e2e-",
|
|
title: "Rewind e2e",
|
|
initialPrompt: firstPrompt,
|
|
});
|
|
|
|
try {
|
|
await openAgentRoute(page, session);
|
|
await expectComposerVisible(page);
|
|
|
|
await expectUserMessageVisible(page, firstPrompt);
|
|
await expectUserMessageCount(page, 1);
|
|
await submitMessage(page, secondPrompt);
|
|
await expectUserMessageVisible(page, secondPrompt);
|
|
await expect(page.getByText("Cycle 1", { exact: true })).toBeVisible();
|
|
await expectUserMessageCount(page, 2);
|
|
|
|
await scrollChatAwayFromBottom(page, {
|
|
deltaY: -900,
|
|
minDistanceFromBottom: 300,
|
|
});
|
|
await userMessage(page, firstPrompt).hover();
|
|
await page.getByTestId("rewind-menu-trigger").first().click();
|
|
const rewindSheet = page.getByTestId("rewind-menu-content");
|
|
await expect(rewindSheet).toBeVisible();
|
|
await expect(
|
|
rewindSheet.getByText("This action cannot be undone", { exact: true }),
|
|
).toBeVisible();
|
|
await page.getByTestId("rewind-menu-conversation").click();
|
|
|
|
await expect(page.getByTestId("rewind-menu-content")).toHaveCount(0);
|
|
await expect(userMessage(page, secondPrompt)).toHaveCount(0);
|
|
await expect(page.getByText("Cycle 1", { exact: true })).toHaveCount(0);
|
|
await expectUserMessageCount(page, 1);
|
|
await expectComposerDraft(page, firstPrompt);
|
|
|
|
await submitMessage(page, replacementPrompt);
|
|
await expectUserMessageVisible(page, replacementPrompt);
|
|
await expect(userMessage(page, secondPrompt)).toHaveCount(0);
|
|
await expect(page.getByText("Cycle 1", { exact: true })).toHaveCount(0);
|
|
await expectUserMessageCount(page, 2);
|
|
|
|
await fillComposerDraft(page, "");
|
|
await composerLocator(page).evaluate((element) => element.blur());
|
|
await userMessage(page, replacementPrompt).hover();
|
|
await page.getByTestId("rewind-menu-trigger").last().click();
|
|
await expect(page.getByTestId("rewind-menu-content")).toBeVisible();
|
|
await page.getByTestId("rewind-menu-files").click();
|
|
await expect(page.getByTestId("rewind-menu-content")).toHaveCount(0);
|
|
await expectComposerDraft(page, "");
|
|
await expectUserMessageCount(page, 2);
|
|
|
|
const preservedDraft = "Keep this human draft after rewind.";
|
|
await fillComposerDraft(page, preservedDraft);
|
|
await composerLocator(page).evaluate((element) => element.blur());
|
|
await userMessage(page, replacementPrompt).hover();
|
|
await page.getByTestId("rewind-menu-trigger").last().click();
|
|
await expect(page.getByTestId("rewind-menu-content")).toBeVisible();
|
|
await page.getByTestId("rewind-menu-files").click();
|
|
await expect(page.getByTestId("rewind-menu-content")).toHaveCount(0);
|
|
await expectComposerDraft(page, preservedDraft);
|
|
await expectUserMessageCount(page, 2);
|
|
|
|
await fillComposerDraft(page, "");
|
|
await composerLocator(page).evaluate((element) => element.blur());
|
|
await userMessage(page, replacementPrompt).hover();
|
|
await page.getByTestId("rewind-menu-trigger").last().click();
|
|
await expect(page.getByTestId("rewind-menu-content")).toBeVisible();
|
|
await page.getByTestId("rewind-menu-both").click();
|
|
await expect(page.getByTestId("rewind-menu-content")).toHaveCount(0);
|
|
await expectComposerDraft(page, replacementPrompt);
|
|
await expectUserMessageCount(page, 1);
|
|
} finally {
|
|
await session.cleanup();
|
|
}
|
|
});
|
|
|
|
test("surfaces rewind failures without crashing the page", async ({ page }) => {
|
|
const firstPrompt = "emit 1 coalesced agent stream updates for failed rewind turn.";
|
|
const rewindError = "No file checkpoint found for message rewind-failure-e2e.";
|
|
const session = await seedMockAgentWorkspace({
|
|
repoPrefix: "rewind-failure-e2e-",
|
|
title: "Rewind failure e2e",
|
|
initialPrompt: firstPrompt,
|
|
featureValues: {
|
|
mockRewindError: rewindError,
|
|
},
|
|
});
|
|
|
|
try {
|
|
await openAgentRoute(page, session);
|
|
await expectComposerVisible(page);
|
|
|
|
await expectUserMessageVisible(page, firstPrompt);
|
|
|
|
await userMessage(page, firstPrompt).hover();
|
|
await page.getByTestId("rewind-menu-trigger").first().click();
|
|
const rewindSheet = page.getByTestId("rewind-menu-content");
|
|
await expect(rewindSheet).toBeVisible();
|
|
await expect(
|
|
rewindSheet.getByText("This action cannot be undone", { exact: true }),
|
|
).toBeVisible();
|
|
await page.getByTestId("rewind-menu-conversation").click();
|
|
|
|
await expect(page.getByTestId("app-toast-message")).toHaveText(rewindError);
|
|
await expect(page.getByText("Uncaught Error")).toHaveCount(0);
|
|
|
|
await userMessage(page, firstPrompt).hover();
|
|
await page.getByTestId("rewind-menu-trigger").first().click();
|
|
await expect(page.getByTestId("rewind-menu-content")).toBeVisible();
|
|
} finally {
|
|
await session.cleanup();
|
|
}
|
|
});
|
|
});
|