refactor: simplify ask settings UI

tests/settings-list.test.ts

@@ -0,0 +1,137 @@
+import assert from "node:assert/strict";
+import test from "node:test";
+import { visibleWidth } from "@mariozechner/pi-tui";
+import type { AskConfig } from "../src/config/schema.ts";
+import { AskSettingsList } from "../src/ui/settings-list.ts";
+
+const savedConfig: AskConfig = {
+	behaviour: {
+		autoSubmitWhenAnsweredWithoutNotes: false,
+		confirmDismissWhenDirty: true,
+		doublePressReviewShortcuts: true,
+		showFooterHints: true,
+	},
+	keymaps: {
+		cancel: "esc",
+		dismiss: "ctrl+c",
+		toggle: "space",
+		confirm: "enter",
+		optionNote: "n",
+		questionNote: "shift+n",
+	},
+};
+
+function plainTheme() {
+	return {
+		bg(_color: string, text: string) {
+			return text;
+		},
+		fg(_color: string, text: string) {
+			return text;
+		},
+	};
+}
+
+function createList(
+	options: {
+		onClose?: () => void;
+		onSave?: (config: AskConfig) => Promise<AskConfig>;
+	} = {}
+) {
+	const onClose =
+		options.onClose ??
+		(() => {
+			// test callback intentionally unused
+		});
+	return new AskSettingsList(plainTheme(), {
+		configPath: "/tmp/eko24ive-pi-ask.json",
+		notice: undefined,
+		onClose,
+		onSave: options.onSave ?? ((config) => Promise.resolve(config)),
+		savedConfig,
+		tui: {
+			requestRender() {
+				// no-op in tests
+			},
+		},
+	});
+}
+
+test("settings list renders behaviour settings and config path", () => {
+	const list = createList();
+	const text = list.render(72).join("\n");
+
+	assert(text.includes("╭"));
+	assert(text.includes("Ask Settings"));
+	assert(text.includes("Auto-submit when answered without notes"));
+	assert(text.includes("[off]"));
+	assert(text.includes("Confirm dismiss when dirty"));
+	assert(text.includes("on"));
+	assert(
+		text.includes("Edit this config file to change customizable ask keymaps:")
+	);
+	assert(text.includes("/tmp/eko24ive-pi-ask.json"));
+	assert(text.includes("Esc to close"));
+	assert.equal(text.includes("Esc to cancel"), false);
+	assert.equal(text.includes("Keymaps"), false);
+	assert.equal(text.includes("Ctrl+S"), false);
+	assert.equal(text.includes("Saved"), false);
+});
+
+test("settings list stays within narrow render width", () => {
+	const list = createList();
+	const lines = list.render(28);
+
+	assert(lines.every((line) => visibleWidth(line) <= 28));
+	const text = lines.join("\n");
+	assert(text.includes("/tmp/eko24ive-pi-ask"));
+	assert(text.includes("n"));
+});
+
+test("settings list saves behaviour changes immediately without success feedback", async () => {
+	let saved: AskConfig | undefined;
+	const list = createList({
+		onSave: (config) => {
+			saved = config;
+			return Promise.resolve(config);
+		},
+	});
+
+	list.handleInput(" ");
+	await new Promise((resolve) => setImmediate(resolve));
+
+	const text = list.render(72).join("\n");
+	assert.equal(saved?.behaviour.autoSubmitWhenAnsweredWithoutNotes, true);
+	assert.equal(saved?.behaviour.confirmDismissWhenDirty, true);
+	assert.equal(saved?.behaviour.doublePressReviewShortcuts, true);
+	assert.equal(saved?.behaviour.showFooterHints, true);
+	assert.equal(text.includes("Saved"), false);
+});
+
+test("settings list shows save failures and reverts the toggle", async () => {
+	const list = createList({
+		onSave: () => Promise.reject(new Error("disk nope")),
+	});
+
+	list.handleInput(" ");
+	await new Promise((resolve) => setImmediate(resolve));
+
+	const text = list.render(72).join("\n");
+	assert(text.includes("disk nope"));
+	assert(text.includes("Auto-submit when answered without notes"));
+	assert(text.includes("[off]"));
+});
+
+test("settings list closes with escape, ctrl-c, question mark, and dispose idempotently", () => {
+	let closed = 0;
+	const list = createList({
+		onClose: () => {
+			closed += 1;
+		},
+	});
+
+	list.handleInput("?");
+	list.handleInput("\u0003");
+	list.dispose();
+	assert.equal(closed, 1);
+});