fix(app): retire the docked explorer sidebar

Upgrading to 0.5.0-beta.1 left the old docked explorer sidebar showing
next to the new explorer pane, with no way to dismiss it.

The sidebar rendered off the persisted `desktop.fileExplorerOpen` flag.
#3287 rerouted the explorer toggle to the workspace-layout explorer pane,
so nothing on a wide layout ever wrote that flag false again, and no
migration cleared it. Assistant directory links and review attachments
could still set it. On Windows and Linux the sidebar's close button was
suppressed because the OS window controls own the top-right corner, so
there was no affordance at all.

The explorer is now one surface picked from two facts — is the layout
compact, and can the platform render split panes:

  compact                -> slide-over overlay (panel store)
  non-compact + splits   -> dedicated right pane (layout store)
  non-compact, no splits -> ordinary tabs in the focused pane

`workspace-tabs/explorer-surface.ts` owns that choice and every entry
point routes through it, so the toggle, Ctrl+E, Ctrl+., directory links,
review attachments and side file opens can no longer disagree about where
the explorer lives.

Pane splits stay gated on `isWeb`: they depend on dnd-kit and DOM-backed
accessibility helpers. Native tablets are non-compact without splits, so
they get explorer tabs rather than a second pane — deliberately trading
side-by-side agent and Changes for a surface that only renders what the
single-column tab row can actually reach.

Ctrl+. is handled by the workspace screen rather than the app shell. The
pathname alone cannot identify the active workspace: desktop cold-starts
at "/" and restores the remembered workspace from route params, so a key
derived from the pathname is null exactly when a workspace is mounted,
and the explorer reads as permanently closed.

`desktop.fileExplorerOpen` and `explorerWidth` are dropped by a migration
to panel-state v15 but stay declared in the persisted schema. That schema
is a strict object and the validated storage deletes the whole entry when
parsing fails, so removing the keys outright would wipe every upgrading
user's sidebar width, expanded paths and diff-collapse state.

packages/app/src/utils/desktop-sidebar-toggle.test.ts

@@ -2,48 +2,50 @@ import { describe, expect, it, vi } from "vitest";
 
 import { toggleDesktopSidebarsWithCheckoutIntent } from "./desktop-sidebar-toggle";
 
+function harness(state: { isAgentListOpen: boolean; isExplorerOpen: boolean }) {
+  const openAgentList = vi.fn();
+  const closeAgentList = vi.fn();
+  const toggleExplorer = vi.fn();
+  const handled = toggleDesktopSidebarsWithCheckoutIntent({
+    ...state,
+    openAgentList,
+    closeAgentList,
+    toggleExplorer,
+  });
+  return { handled, openAgentList, closeAgentList, toggleExplorer };
+}
+
 describe("toggleDesktopSidebarsWithCheckoutIntent", () => {
-  it("closes both sidebars when either desktop sidebar is open", () => {
-    const openAgentList = vi.fn();
-    const closeAgentList = vi.fn();
-    const closeFileExplorer = vi.fn();
-    const toggleFocusedFileExplorer = vi.fn(() => true);
+  it("closes only what is open when either side is showing", () => {
+    const result = harness({ isAgentListOpen: true, isExplorerOpen: false });
 
-    const handled = toggleDesktopSidebarsWithCheckoutIntent({
-      isAgentListOpen: true,
-      isFileExplorerOpen: false,
-      openAgentList,
-      closeAgentList,
-      closeFileExplorer,
-      toggleFocusedFileExplorer,
-    });
-
-    expect(handled).toBe(true);
-    expect(closeAgentList).toHaveBeenCalledTimes(1);
-    expect(closeFileExplorer).toHaveBeenCalledTimes(1);
-    expect(openAgentList).not.toHaveBeenCalled();
-    expect(toggleFocusedFileExplorer).not.toHaveBeenCalled();
+    expect(result.handled).toBe(true);
+    expect(result.closeAgentList).toHaveBeenCalledTimes(1);
+    expect(result.openAgentList).not.toHaveBeenCalled();
+    // The explorer is already closed; toggling it would reopen it.
+    expect(result.toggleExplorer).not.toHaveBeenCalled();
   });
 
-  it("opens the right sidebar only through the focused checkout-aware handler", () => {
-    const openAgentList = vi.fn();
-    const closeAgentList = vi.fn();
-    const closeFileExplorer = vi.fn();
-    const toggleFocusedFileExplorer = vi.fn(() => false);
+  it("closes the explorer when it is the only side showing", () => {
+    const result = harness({ isAgentListOpen: false, isExplorerOpen: true });
 
-    const handled = toggleDesktopSidebarsWithCheckoutIntent({
-      isAgentListOpen: false,
-      isFileExplorerOpen: false,
-      openAgentList,
-      closeAgentList,
-      closeFileExplorer,
-      toggleFocusedFileExplorer,
-    });
+    expect(result.toggleExplorer).toHaveBeenCalledTimes(1);
+    expect(result.closeAgentList).not.toHaveBeenCalled();
+    expect(result.openAgentList).not.toHaveBeenCalled();
+  });
 
-    expect(handled).toBe(true);
-    expect(openAgentList).toHaveBeenCalledTimes(1);
-    expect(toggleFocusedFileExplorer).toHaveBeenCalledTimes(1);
-    expect(closeAgentList).not.toHaveBeenCalled();
-    expect(closeFileExplorer).not.toHaveBeenCalled();
+  it("closes both when both are showing", () => {
+    const result = harness({ isAgentListOpen: true, isExplorerOpen: true });
+
+    expect(result.closeAgentList).toHaveBeenCalledTimes(1);
+    expect(result.toggleExplorer).toHaveBeenCalledTimes(1);
+  });
+
+  it("opens both when nothing is showing", () => {
+    const result = harness({ isAgentListOpen: false, isExplorerOpen: false });
+
+    expect(result.openAgentList).toHaveBeenCalledTimes(1);
+    expect(result.toggleExplorer).toHaveBeenCalledTimes(1);
+    expect(result.closeAgentList).not.toHaveBeenCalled();
   });
 });

packages/app/src/utils/desktop-sidebar-toggle.ts

@@ -1,20 +1,29 @@
 interface DesktopSidebarToggleInput {
   isAgentListOpen: boolean;
-  isFileExplorerOpen: boolean;
+  isExplorerOpen: boolean;
   openAgentList: () => void;
   closeAgentList: () => void;
-  closeFileExplorer: () => void;
-  toggleFocusedFileExplorer: () => boolean;
+  toggleExplorer: () => void;
 }
 
+/**
+ * "Toggle both sidebars" collapses the workspace to just its content when
+ * anything is showing, and restores both when nothing is. The explorer only
+ * exposes a toggle, so each side is nudged only when it is on the wrong side
+ * of the intent.
+ */
 export function toggleDesktopSidebarsWithCheckoutIntent(input: DesktopSidebarToggleInput): boolean {
-  if (input.isAgentListOpen || input.isFileExplorerOpen) {
-    input.closeAgentList();
-    input.closeFileExplorer();
-    return true;
-  }
+  const shouldOpen = !input.isAgentListOpen && !input.isExplorerOpen;
 
-  input.openAgentList();
-  input.toggleFocusedFileExplorer();
+  if (input.isAgentListOpen !== shouldOpen) {
+    if (shouldOpen) {
+      input.openAgentList();
+    } else {
+      input.closeAgentList();
+    }
+  }
+  if (input.isExplorerOpen !== shouldOpen) {
+    input.toggleExplorer();
+  }
   return true;
 }