jb/paseo
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

fix(server): suppress browser popups from ACP probes

Browse Source 
Pass NO_BROWSER=true when probing ACP agents for models, modes, and
persisted sessions. Gemini CLI's ACP newSession handler calls refreshAuth
inline and will open a Google OAuth URL in the browser when no valid
cached token is present — every snapshot warm-up triggered this on
navigation. Real agent sessions still use their own launchContext.env,
so interactive auth continues to work when actually starting an agent.
This commit is contained in:
Mohamed Boudra
2026-04-18 11:10:34 +07:00
parent 59d9b2ebdd
commit 82f97e942d
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/server/agent/providers/acp-agent.ts
+8 -3
View File
@@ -107,6 +107,11 @@ const ACP_CLIENT_CAPABILITIES: ACPClientCapabilities = {
const COPILOT_AUTOPILOT_MODE = "https://agentclientprotocol.com/protocol/session-modes#autopilot";
// Suppress interactive auth side-effects (e.g. Gemini CLI opening a Google
// sign-in URL in the browser) when probing an ACP agent for models/modes.
// NO_BROWSER is honored by Gemini CLI; other ACP agents ignore it.
const PROBE_ENV: Record<string, string> = { NO_BROWSER: "true" };
type ACPAgentClientOptions = {
provider: string;
logger: Logger;
@@ -391,7 +396,7 @@ export class ACPAgentClient implements AgentClient {
async listModels(options?: ListModelsOptions): Promise<AgentModelDefinition[]> {
const cwd = options?.cwd ?? process.cwd();
const probe = await this.spawnProcess(undefined);
const probe = await this.spawnProcess(PROBE_ENV);
try {
const response = await probe.connection.newSession({
cwd,
@@ -411,7 +416,7 @@ export class ACPAgentClient implements AgentClient {
async listModes(options?: ListModesOptions): Promise<AgentMode[]> {
const cwd = options?.cwd ?? process.cwd();
const probe = await this.spawnProcess(undefined);
const probe = await this.spawnProcess(PROBE_ENV);
try {
const response = await probe.connection.newSession({
cwd,
@@ -432,7 +437,7 @@ export class ACPAgentClient implements AgentClient {
async listPersistedAgents(
options?: ListPersistedAgentsOptions,
): Promise<PersistedAgentDescriptor[]> {
const probe = await this.spawnProcess(undefined);
const probe = await this.spawnProcess(PROBE_ENV);
try {
if (!probe.initialize.agentCapabilities?.sessionCapabilities?.list) {
return [];