fix(server): bypass Copilot ACP prompts in autopilot (#206)

* fix(server): bypass Copilot ACP prompts in autopilot

* Delete lessons.md

---------

Co-authored-by: Paseo Bot <paseo-bot@users.noreply.github.com>
This commit is contained in:
thatdaveguy1
2026-04-07 10:28:12 +08:00
committed by GitHub
co-authored by Paseo Bot
parent 102ef06c30
commit d888c8f126
2 changed files with 70 additions and 0 deletions
@@ -747,4 +747,55 @@ describe("ACPAgentSession", () => {
});
expect((session as any).activeForegroundTurnId).toBeNull();
});
test("auto-approves Copilot ACP permissions in autopilot mode without emitting prompt events", async () => {
const session = new ACPAgentSession(
{
provider: "copilot",
cwd: "/tmp/paseo-acp-test",
modeId: "https://agentclientprotocol.com/protocol/session-modes#autopilot",
},
{
provider: "copilot",
logger: createTestLogger(),
defaultCommand: ["copilot", "--acp"],
defaultModes: [],
capabilities: {
supportsStreaming: true,
supportsSessionPersistence: true,
supportsDynamicModes: true,
supportsMcpServers: true,
supportsReasoningStream: true,
supportsToolInvocations: true,
},
},
);
const events: Array<{ type: string }> = [];
session.subscribe((event) => {
events.push(event as { type: string });
});
const response = await session.requestPermission({
toolCall: {
toolCallId: "tool-1",
title: "Edit file",
kind: "edit",
status: "pending",
} as any,
options: [
{ optionId: "allow-once", name: "Allow Once", kind: "allow_once" },
{ optionId: "reject-once", name: "Reject Once", kind: "reject_once" },
],
} as any);
expect(response).toEqual({
outcome: {
outcome: "selected",
optionId: "allow-once",
},
});
expect(session.getPendingPermissions()).toEqual([]);
expect(events.find((event) => event.type === "permission_requested")).toBeUndefined();
});
});
@@ -107,6 +107,9 @@ const ACP_CLIENT_CAPABILITIES: ACPClientCapabilities = {
terminal: true,
};
const COPILOT_AUTOPILOT_MODE =
"https://agentclientprotocol.com/protocol/session-modes#autopilot";
type ACPAgentClientOptions = {
provider: string;
logger: Logger;
@@ -1084,6 +1087,18 @@ export class ACPAgentSession implements AgentSession, ACPClient {
async requestPermission(
params: RequestPermissionRequest,
): Promise<RequestPermissionResponse> {
if (shouldAutoApprovePermissionRequest(this.provider, this.currentMode)) {
const selectedOption = selectPermissionOption(params.options, { behavior: "allow" });
return selectedOption
? {
outcome: {
outcome: "selected",
optionId: selectedOption.optionId,
},
}
: { outcome: { outcome: "cancelled" } };
}
const requestId = randomUUID();
let toolSnapshot =
this.toolCalls.get(params.toolCall.toolCallId) ??
@@ -1939,6 +1954,10 @@ function mapPermissionRequest(
};
}
function shouldAutoApprovePermissionRequest(provider: string, currentMode: string | null): boolean {
return provider === "copilot" && currentMode === COPILOT_AUTOPILOT_MODE;
}
function selectPermissionOption(
options: PermissionOption[],
response: AgentPermissionResponse,