jb/paseo
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

chore: record orchestrator tool call re-review

Browse Source
This commit is contained in:
Mohamed Boudra
2025-12-21 18:44:10 +00:00
parent 79d9ff6887
commit dd81774d84
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plan.md
+8 -1
View File
@@ -641,7 +641,14 @@ interface ToolCallSheetData {
5. ✅ TypeScript typecheck passes
**Note**: Could not test clicking tool badge in orchestrator view as `session.messages` is empty (no messages aggregated from sessions). However, fix is verified correct - `ToolCall` uses same `useToolCallSheet` hook that works in agent stream view.
- [ ] agent=codex **Review**: Re-review after orchestrator tool call sheet fix.
- [x] agent=codex **Review**: Re-review after orchestrator tool call sheet fix.
- Confirm the provider placement and types.
- Check for any remaining unwrapped `ToolCall` usages.
- **Done (2025-12-21 18:43)**: Reviewed `ToolCallSheetProvider` integration; `ToolCall` is only rendered under providers in agent and orchestrator views (`agent-stream-view.tsx`, `orchestrator-messages-view.tsx`). No additional unwrapped usages or type issues found.
- [ ] **Test**: Populate orchestrator messages with real tool calls and verify bottom sheet.
- Trigger a real orchestrator tool call (e.g., MCP create_agent) so `session.messages` is non-empty.
- Tap the tool badge in `/orchestrator` and ensure the bottom sheet opens with correct details.
- Confirm no context errors and that args/results render correctly.