test(agent-manager): add e2e tests for mode-switch update propagation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-22 14:12:53 +00:00
parent 907074a454
commit f5b66f4745
1 changed files with 174 additions and 0 deletions
@@ -0,0 +1,174 @@
+import { describe, test, expect, beforeAll, afterAll } from "vitest";
+import { createDaemonTestContext, type DaemonTestContext } from "../test-utils/index.js";
+import { DaemonClient } from "../test-utils/daemon-client.js";
+import type { SessionOutboundMessage } from "../messages.js";
+
+type AgentUpdateMessage = Extract<SessionOutboundMessage, { type: "agent_update" }>;
+type AgentUpdatePayload = AgentUpdateMessage["payload"];
+type AgentUpsertPayload = Extract<AgentUpdatePayload, { kind: "upsert" }>;
+
+function sleep(ms: number): Promise<void> {
+  return new Promise((r) => setTimeout(r, ms));
+}
+
+function collectAgentUpdates(client: DaemonClient): {
+  updates: AgentUpdatePayload[];
+  unsub: () => void;
+} {
+  const updates: AgentUpdatePayload[] = [];
+  const unsub = client.on("agent_update", (message) => {
+    if (message.type === "agent_update") {
+      updates.push(message.payload);
+    }
+  });
+  return { updates, unsub };
+}
+
+function lastUpsertFor(updates: AgentUpdatePayload[], agentId: string): AgentUpsertPayload | undefined {
+  return updates
+    .filter((u): u is AgentUpsertPayload => u.kind === "upsert" && u.agent.id === agentId)
+    .at(-1);
+}
+
+describe("mode-switch update propagation", () => {
+  let ctx: DaemonTestContext;
+
+  beforeAll(async () => {
+    ctx = await createDaemonTestContext();
+  }, 30000);
+
+  afterAll(async () => {
+    if (ctx) await ctx.cleanup();
+  }, 30000);
+
+  test("agent_update event arrives with updated currentModeId after setAgentMode", async () => {
+    const { updates, unsub } = collectAgentUpdates(ctx.client);
+
+    const agent = await ctx.client.createAgent({
+      provider: "claude",
+      cwd: "/tmp",
+      modeId: "default",
+    });
+    expect(agent.currentModeId).toBe("default");
+
+    await sleep(300);
+    const beforeCount = updates.length;
+
+    await ctx.client.setAgentMode(agent.id, "bypassPermissions");
+    await sleep(500);
+
+    const modeUpdate = updates
+      .slice(beforeCount)
+      .find(
+        (u): u is AgentUpsertPayload =>
+          u.kind === "upsert" &&
+          u.agent.id === agent.id &&
+          u.agent.currentModeId === "bypassPermissions",
+      );
+
+    expect(modeUpdate).toBeDefined();
+    unsub();
+  });
+
+  test("updatedAt is bumped when mode changes", async () => {
+    const { updates, unsub } = collectAgentUpdates(ctx.client);
+
+    const agent = await ctx.client.createAgent({
+      provider: "claude",
+      cwd: "/tmp",
+      modeId: "default",
+    });
+
+    await sleep(300);
+
+    const updatedAtBefore = lastUpsertFor(updates, agent.id)?.agent.updatedAt;
+
+    await ctx.client.setAgentMode(agent.id, "bypassPermissions");
+    await sleep(500);
+
+    const updatedAtAfter = lastUpsertFor(updates, agent.id)?.agent.updatedAt;
+
+    expect(updatedAtBefore).toBeTruthy();
+    expect(updatedAtAfter).toBeTruthy();
+    expect(updatedAtAfter).not.toBe(updatedAtBefore);
+
+    unsub();
+  });
+
+  test("mode switch is visible in second client bootstrap snapshot", async () => {
+    const agent = await ctx.client.createAgent({
+      provider: "claude",
+      cwd: "/tmp",
+      modeId: "default",
+    });
+    await sleep(200);
+
+    await ctx.client.setAgentMode(agent.id, "plan");
+    await sleep(200);
+
+    const client2 = new DaemonClient({
+      url: `ws://127.0.0.1:${ctx.daemon.port}/ws`,
+    });
+    await client2.connect();
+
+    const bootstrapResult = await client2.fetchAgents({
+      subscribe: { subscriptionId: "bootstrap-test" },
+    });
+
+    const found = bootstrapResult.entries.find((e) => e.agent.id === agent.id);
+    expect(found?.agent.currentModeId).toBe("plan");
+
+    const { updates: client2Updates, unsub } = collectAgentUpdates(client2);
+
+    await ctx.client.setAgentMode(agent.id, "acceptEdits");
+    await sleep(500);
+
+    const modeUpdate = client2Updates.find(
+      (u): u is AgentUpsertPayload =>
+        u.kind === "upsert" &&
+        u.agent.id === agent.id &&
+        u.agent.currentModeId === "acceptEdits",
+    );
+    expect(modeUpdate).toBeDefined();
+
+    unsub();
+    await client2.close();
+  });
+
+  test("rapid mode switches settle to the final value", async () => {
+    const { updates, unsub } = collectAgentUpdates(ctx.client);
+
+    const agent = await ctx.client.createAgent({
+      provider: "claude",
+      cwd: "/tmp",
+      modeId: "default",
+    });
+
+    await ctx.client.setAgentMode(agent.id, "bypassPermissions");
+    await ctx.client.setAgentMode(agent.id, "plan");
+    await ctx.client.setAgentMode(agent.id, "acceptEdits");
+
+    await sleep(500);
+
+    expect(lastUpsertFor(updates, agent.id)?.agent.currentModeId).toBe("acceptEdits");
+
+    unsub();
+  });
+
+  test("mode switch immediately after creation reflects correct mode", async () => {
+    const { updates, unsub } = collectAgentUpdates(ctx.client);
+
+    const agent = await ctx.client.createAgent({
+      provider: "claude",
+      cwd: "/tmp",
+      modeId: "default",
+    });
+    await ctx.client.setAgentMode(agent.id, "bypassPermissions");
+
+    await sleep(500);
+
+    expect(lastUpsertFor(updates, agent.id)?.agent.currentModeId).toBe("bypassPermissions");
+
+    unsub();
+  });
+});