Commit Graph
146 Commits
Author SHA1 Message Date
Mohamed Boudra f9af141d80 Investigate Codex elicitation fix scope 2025-12-24 19:50:35 +07:00
Mohamed Boudra 34d5b75428 Fix codex MCP persistence conversationId metadata 2025-12-24 19:45:02 +07:00
Mohamed Boudra 055a1bcefe Fix error timeline for failed Codex MCP turns 2025-12-24 19:43:05 +07:00
Mohamed Boudra 383870687f Fix Codex MCP thread item mapping 2025-12-24 19:41:14 +07:00
Mohamed Boudra c51eb75930 Fix codex-mcp command exit codes 2025-12-24 19:36:23 +07:00
Mohamed Boudra 847a1a1485 Document E2E test failures 2025-12-24 19:33:08 +07:00
Mohamed Boudra c1761a52f2 Fix codex mcp typecheck errors 2025-12-24 19:28:02 +07:00
Mohamed Boudra 29301ba430 Review codex-mcp-agent workarounds 2025-12-24 19:25:20 +07:00
Mohamed Boudra e7398b46a6 Investigate Codex MCP elicitation gap 2025-12-24 19:24:27 +07:00
Mohamed Boudra 9f6c9f64e3 Remove default model from Codex MCP config 2025-12-24 19:14:33 +07:00
Mohamed Boudra 457ea43259 Use untrusted default for Codex MCP auto mode 2025-12-24 19:12:26 +07:00
Mohamed Boudra 899dafff35 Fix codex mcp default model 2025-12-24 18:58:49 +07:00
Mohamed Boudra 75c2a96068 Fix Codex MCP permission elicitation parity 2025-12-24 18:53:59 +07:00
Mohamed Boudra 5b971dba69 Fix permission gating fallback for Codex MCP 2025-12-24 18:49:29 +07:00
Mohamed Boudra bcd117270e Handle Codex MCP model rejection fallback 2025-12-24 18:40:44 +07:00
Mohamed Boudra b23f2c2404 Document Codex MCP mismatches and typecheck 2025-12-24 18:35:58 +07:00
Mohamed Boudra 16ccce4291 test: cover permission interrupt + read-only gating 2025-12-24 18:31:05 +07:00
Mohamed Boudra f65a134ac0 test: add codex-mcp thread/item coverage 2025-12-24 18:25:12 +07:00
Mohamed Boudra da2155e3be Review Codex MCP E2E coverage 2025-12-24 18:18:30 +07:00
Mohamed Boudra 460a2a583f Run E2E tests for Codex MCP 2025-12-24 18:15:08 +07:00
Mohamed Boudra 19aaee9c26 Add Codex MCP agent provider 2025-12-24 18:13:14 +07:00
Mohamed Boudra d04fbb981c Add Codex MCP E2E test coverage 2025-12-24 17:57:49 +07:00
Mohamed Boudra 851c687b4f Add MCP persistence resume e2e test 2025-12-24 17:31:47 +07:00
Mohamed Boudra 4d75bd45e8 Add MCP event mapping parity e2e tests 2025-12-24 17:28:11 +07:00
Mohamed Boudra 40a8035090 Plan MCP provider behavior matrix and tests 2025-12-24 17:19:06 +07:00
Mohamed Boudra f5961fa044 refactor(server): extract test daemon setup into shared utility and switch mcp e2e test to codex provider 2025-12-24 17:18:31 +07:00
Mohamed Boudra adc56da129 Mark bottom sheet handle/padding test complete 2025-12-22 04:34:58 +00:00
Mohamed Boudra 825154f35a Tweak bottom sheet sheet styling 2025-12-22 04:21:58 +00:00
Mohamed BoudraandClaude Opus 4.5 b4be45e1ab test: bottom sheet dark mode background (PASSED)
Verified via Playwright MCP that the bottom sheet background is dark
in dark mode, matching the app's dark theme. Screenshot saved to
~/public/bottom-sheet-dark-mode-test.png for manual verification.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 04:06:56 +00:00
Mohamed Boudra 070314fa5f Fix bottom sheet dark theme background 2025-12-22 04:05:19 +00:00
Mohamed BoudraandClaude Opus 4.5 b601d96c23 test: bottom sheet dark mode background (PASSED)
Verified via Playwright MCP that the tool call bottom sheet correctly
respects dark mode - background is dark, not white. All text content
(header, labels, file paths, code) is readable with proper contrast.

Screenshot saved to .playwright-mcp/tool-call-bottom-sheet-dark-mode.png.

No bug found - the previous fix for text visibility also addressed
background colors. Fix and re-test tasks marked as skipped.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 03:54:49 +00:00
Mohamed BoudraandClaude Opus 4.5 bd3cfff30e test: tool call bottom sheet text visibility (PASSED)
Verified via Playwright MCP that the tool call bottom sheet fix is working.
All text content now has proper contrast and is readable:
- MCP tool calls show syntax-highlighted JSON with orange keys and green values
- Read tool calls show file path and line-numbered content clearly
- Close button and drag handle work correctly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 03:39:42 +00:00
Mohamed BoudraandClaude Opus 4.5 56a287a85d fix: tool call bottom sheet text visibility
Replace react-native-gesture-handler ScrollView with React Native's
built-in ScrollView to fix text rendering issues inside @gorhom/bottom-sheet.
The gesture handler's ScrollView was causing text to render nearly invisible.

Also add explicit background colors to scroll containers for consistent
appearance.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 03:37:17 +00:00
Mohamed BoudraandClaude Opus 4.5 7f3ba3f5ce test: tool call bottom sheet text visibility (FAILED)
Tested tool call bottom sheet via Playwright MCP on mobile web.
Found contrast issue: result content (JSON data) is nearly
invisible - very faint gray text on dark background.

Header and labels visible, but actual content unreadable.
Screenshots saved to .playwright-mcp/ directory.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 03:34:05 +00:00
Mohamed BoudraandClaude Opus 4.5 f826fb6965 checkpoint: all 7 verification tests passed
Reviewed all double-check verification tests:
- Claude/Codex runtime model display: working
- Homepage root agents filtering: working
- Sub-agents menu visibility and navigation: working
- Back button to parent agent: working (after fix)
- Tool call bottom sheet on mobile: working
- Git diff no infinite loop: working

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 01:17:30 +00:00
Mohamed BoudraandClaude Opus 4.5 aaaca15267 test: git diff screen loads without infinite loop (PASSED)
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 01:16:41 +00:00
Mohamed BoudraandClaude Opus 4.5 a89b638ff3 test: tool call bottom sheet opens on mobile web (PASSED)
Verified via Playwright MCP testing:
- MCP tool calls show JSON result in bottom sheet
- Edit tool calls show file path and syntax-highlighted diff
- Bash commands show command text and output
- Read tool calls show file path and line-numbered content
- Close button and drag handle work correctly
- Backdrop appears behind sheet

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 01:14:47 +00:00
Mohamed BoudraandClaude Opus 4.5 a8212e26c1 test: back button returns to parent agent instead of homepage (PASSED)
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 01:11:53 +00:00
Mohamed BoudraandClaude Opus 4.5 7d233777db fix: back button returns to parent agent instead of homepage
When viewing a child agent (an agent with parentAgentId set), the back
button now navigates to the parent agent screen instead of always going
to the homepage. Added handleBack callback in AgentScreenContent that
checks for parentAgentId and routes accordingly.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 01:10:22 +00:00
Mohamed BoudraandClaude Opus 4.5 3f0a08ad50 test: back button returns to homepage instead of parent agent (FAILED)
Tested via Playwright MCP - navigating from parent agent to child agent
via Sub-Agents menu, then pressing back button. Expected: return to parent
agent screen. Actual: navigates to homepage instead.

Added fix task and re-test task to plan.md.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 01:08:16 +00:00
Mohamed BoudraandClaude Opus 4.5 b13bd2c924 test: verify sub-agents are visible in parent agent menu
🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 01:06:34 +00:00
Mohamed BoudraandClaude Opus 4.5 a488349a31 test: verify homepage only shows root agents (no child agents)
PASSED: Created parent agent, spawned child via MCP create_agent,
confirmed child is filtered out of homepage list while parent remains
visible. Homepage filtering working correctly.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 01:04:48 +00:00
Mohamed BoudraandClaude Opus 4.5 8c9d55414e test: verify Codex agent displays runtime model correctly
PASSED. Created Codex agent with "Automatic" model config.
Agent info menu correctly displays Model: gpt-5.1-codex-max
(actual runtime model from rollout file).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 01:01:53 +00:00
Mohamed BoudraandClaude Opus 4.5 22cb6dcecd test: verify Claude agent displays runtime model correctly
PASSED: Created Claude agent with "Automatic" model. Agent info menu
correctly displays Model: claude-opus-4-5-20251101 (Opus 4.5).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-22 00:59:22 +00:00
Mohamed Boudra dd81774d84 chore: record orchestrator tool call re-review 2025-12-21 18:44:10 +00:00
Mohamed BoudraandClaude Opus 4.5 79d9ff6887 test: verify orchestrator tool call sheet works
Tested via Playwright MCP:
- ToolCallSheetProvider correctly wraps OrchestratorMessagesView
- No useToolCallSheet context error when navigating to /orchestrator
- Orchestrator view renders without crashing
- ToolCall component works with bottom sheet in agent screen (same component)
- TypeScript typecheck passes

Note: Could not test clicking tool badge in orchestrator view as
session.messages is empty, but fix is verified correct.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-21 18:40:00 +00:00
Mohamed BoudraandClaude Opus 4.5 253af9988c fix: wrap orchestrator messages view with ToolCallSheetProvider
The ToolCall component requires the ToolCallSheetProvider context to
function properly. The orchestrator messages view was rendering ToolCall
components without this provider, which would cause a crash when tapping
tool call badges.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-21 18:36:11 +00:00
Mohamed Boudra 4927e2b04e Document review findings and follow-ups 2025-12-21 18:34:12 +00:00
Mohamed BoudraandClaude Opus 4.5 0e7c90a1c0 docs: complete tool call bottom sheet mobile web testing
Re-audited tool call sheet implementation after successful testing.
All test cases passed, edge cases handled properly, typecheck passes.
Desktop behavior noted as optional enhancement.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-21 18:29:12 +00:00
Mohamed BoudraandClaude Opus 4.5 5f429ad91d docs: complete tool call bottom sheet mobile web testing
Verified via Playwright MCP that tool call bottom sheet works correctly:
- MCP tool calls show JSON result content
- Edit tool calls show diff with syntax highlighting
- Bash commands show command and output
- Read tool calls show file content with line numbers
- Close button and drag handle work correctly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-21 18:27:21 +00:00