Mohamed BoudraandGitHub
19a7d26349
* feat(app): let the file panel close its tree rail The file panel's tree rail was permanent on desktop — the changes panel had a folder-tree toggle in its toolbar, the file toolbar had nothing, so the rail was there whether you wanted it or not. The changes panel's private DesktopTreeToggle becomes a shared TreeRailToggle so both toolbars render the same affordance; that also drops the treeToggleStyle prop threaded through ChangesToolbarProps, which recomputed exactly what the component already built internally. The i18n keys move out of workspace.git.diff into workspace.tree, since a shared component reaching into the git namespace would rot. The two rails keep independent flags — the file rail in panel-store, the changes rail in useChangesPreferences — so closing one leaves the other alone. FileTreeToggle wires itself to the store rather than taking a callback: the bar renders several components below FilePanel, where the rail actually lives. Both rails also get narrower (320 -> 260 default, 200 -> 180 minimum). The persist version bump resets treeRailWidth on purpose: nearly every existing install carries the old 320 default, so without the reset the narrower rail would only ever reach new users. Anyone who dragged their rail to a deliberate custom width loses it once. Note that MIN_CONTENT_WIDTH still clamps the rail to `containerWidth - 240`, so in a narrow pane the new default never applies — that floor, not the default, is what sets the width there. * feat(app): make the side panel an empty workspace surface The fixed, hideable side panel keeps supporting context beside an agent without seeding content. Pane-local choices stay local, while implicit supporting opens follow a persisted routing preference. * test(app): exercise side panel policy through its capability boundary The browser rail journey already covers the real tree-toggle behavior. Side-panel policy tests now pass their platform capability through the public boundary instead of replacing a production module. * test(app): expect an empty side panel after upgrade * test(app): expect an empty first split pane * test(app): account for the empty side panel in split retention * feat(app): make workspace panel tabs independent Give explicit New actions fresh tab instances, keep panel state opaque to tab management, preserve File navigation context, and stabilize uncached File transitions. * fix(app): preserve file conflicts during preview refresh Keep the current preview mounted for same-target reads and conversions so the editor retains its conflict observation state. Clear retained previews only when the file target changes.
85 lines
3.2 KiB
TypeScript
85 lines
3.2 KiB
TypeScript
import { expect, type Locator, type Page } from "@playwright/test";
|
|
|
|
export interface SplitPaneGeometry {
|
|
containerWidth: number;
|
|
explorerWidth: number;
|
|
visibleWidth: number;
|
|
separatorCount: number;
|
|
occupiedWidth: number;
|
|
}
|
|
|
|
function splitSeparator(page: Page): Locator {
|
|
return page.getByRole("separator", { name: "" });
|
|
}
|
|
|
|
export async function openExplorerSplit(page: Page): Promise<void> {
|
|
await page.getByRole("button", { name: "Open side panel" }).click();
|
|
await expect(splitSeparator(page)).toHaveCount(1, { timeout: 30_000 });
|
|
}
|
|
|
|
export async function hideExplorerSplit(page: Page): Promise<void> {
|
|
await page.getByRole("button", { name: "Close side panel" }).click();
|
|
await expect(splitSeparator(page)).toHaveCount(0, { timeout: 30_000 });
|
|
}
|
|
|
|
export async function resizeExplorerSplit(page: Page, deltaX: number): Promise<void> {
|
|
const separator = splitSeparator(page);
|
|
await expect(separator).toHaveCount(1);
|
|
const box = await separator.boundingBox();
|
|
expect(box).not.toBeNull();
|
|
if (!box) throw new Error("Split separator has no bounding box");
|
|
await page.mouse.move(box.x + box.width / 2, box.y + box.height / 2);
|
|
await page.mouse.down();
|
|
await page.mouse.move(box.x + box.width / 2 + deltaX, box.y + box.height / 2, { steps: 10 });
|
|
await page.mouse.up();
|
|
}
|
|
|
|
export async function stampExplorerNode(page: Page): Promise<void> {
|
|
await page
|
|
.getByTestId("split-group-child")
|
|
.last()
|
|
.evaluate((node) => {
|
|
Reflect.set(window, "__splitPaneExplorerNode", node);
|
|
node.setAttribute("data-split-pane-identity", "retained");
|
|
});
|
|
}
|
|
|
|
export async function expectExplorerNodeRetained(page: Page): Promise<void> {
|
|
const stampedNode = page.locator('[data-split-pane-identity="retained"]');
|
|
await expect(stampedNode).toHaveCount(1);
|
|
expect(
|
|
await stampedNode.evaluate((node) => Reflect.get(window, "__splitPaneExplorerNode") === node),
|
|
).toBe(true);
|
|
}
|
|
|
|
export async function measureExplorerSplit(page: Page): Promise<SplitPaneGeometry> {
|
|
const explorerChild = page.locator('[data-split-pane-identity="retained"]');
|
|
await expect(explorerChild).toHaveCount(1);
|
|
|
|
return explorerChild.evaluate((explorerNode) => {
|
|
const visibleNode = Array.from(explorerNode.parentElement?.children ?? [])
|
|
.filter(
|
|
(candidate) =>
|
|
candidate !== explorerNode &&
|
|
(candidate as HTMLElement).dataset.testid === "split-group-child",
|
|
)
|
|
.sort(
|
|
(left, right) => right.getBoundingClientRect().width - left.getBoundingClientRect().width,
|
|
)[0];
|
|
if (!(visibleNode instanceof HTMLElement)) throw new Error("Visible split child not found");
|
|
const visible = visibleNode.getBoundingClientRect();
|
|
const explorer = explorerNode.getBoundingClientRect();
|
|
const container = explorerNode.parentElement?.getBoundingClientRect();
|
|
if (!container) throw new Error("Split child has no container");
|
|
const separatorCount =
|
|
explorerNode.parentElement?.querySelectorAll('[role="separator"]').length ?? 0;
|
|
return {
|
|
containerWidth: container.width,
|
|
explorerWidth: explorer.width,
|
|
visibleWidth: visible.width,
|
|
separatorCount,
|
|
occupiedWidth: explorer.width + visible.width,
|
|
};
|
|
});
|
|
}
|