* fix(ci): skip unrelated required checks cleanly Matrix jobs had to start no-op runners to preserve interpolated required-check names. Static named jobs let GitHub report genuine skipped conclusions while keeping those names stable. * fix(ci): gate changes to install patching script * fix(ci): route cross-package test contracts narrowly * fix(ci): keep routed contracts merge-blocking * fix(server): exclude nested test utilities from builds * fix(ci): cover app-owned native and browser domains * refactor(ci): align tests with runtime domains Own browser specs, desktop specs, and Electron-only app code by stable directories so PR routing does not depend on filename conventions. Keep desktop integration coverage inside the required desktop check. * fix(ci): keep routing and desktop suites isolated The routing regression must run before dependency installation, and desktop Vitest must not collect Playwright-owned specs. * fix(ci): isolate desktop e2e runtime * perf(test): isolate Playwright workers * perf(test): parallelize Playwright within specs * fix(test): keep Playwright file scheduling * fix(test): share dynamic Metro fixture * fix(test): preserve own-host restart fixtures * fix(ci): preserve routed contracts after rebase * Stabilize Playwright wheel-scroll assertions
127 lines
4.1 KiB
TypeScript
127 lines
4.1 KiB
TypeScript
import { test } from "../support/fixtures";
|
|
import {
|
|
openPrPane,
|
|
expectPrPaneTitle,
|
|
expectPrPaneState,
|
|
expectPrPaneCheckSummary,
|
|
expectPrPaneActivityCount,
|
|
} from "../support/helpers/pr-pane";
|
|
import { gotoWorkspace } from "../support/helpers/launcher";
|
|
import {
|
|
hasGithubAuth,
|
|
createTempGithubRepo,
|
|
type GhRepoFixture,
|
|
} from "../support/helpers/github-fixtures";
|
|
import {
|
|
connectWorkspaceSetupClient,
|
|
openProjectViaDaemon,
|
|
type WorkspaceSetupDaemonClient,
|
|
} from "../support/helpers/workspace-setup";
|
|
|
|
const GITHUB_AUTH = hasGithubAuth();
|
|
|
|
test.describe("PR pane", () => {
|
|
test.describe.configure({ retries: 1 });
|
|
|
|
let seedClient: WorkspaceSetupDaemonClient;
|
|
let repoFixture: GhRepoFixture;
|
|
const workspaceByTitle = new Map<string, string>();
|
|
|
|
test.beforeAll(async () => {
|
|
if (!GITHUB_AUTH) return;
|
|
|
|
seedClient = await connectWorkspaceSetupClient();
|
|
|
|
repoFixture = await createTempGithubRepo({
|
|
category: "pr-pane",
|
|
prs: [
|
|
{ title: "Review selected start ref", state: "open" },
|
|
{ title: "Merged feature branch", state: "merged" },
|
|
{ title: "Closed without merge", state: "closed" },
|
|
{ title: "Work in progress", state: "draft" },
|
|
{
|
|
title: "PR with mixed checks",
|
|
state: "open",
|
|
checks: [
|
|
{ context: "build-1", state: "success" },
|
|
{ context: "build-2", state: "success" },
|
|
{ context: "deploy", state: "failure" },
|
|
{ context: "security", state: "pending" },
|
|
],
|
|
},
|
|
{ title: "PR with reviews", state: "open", commentCount: 3 },
|
|
{ title: "PR with no checks", state: "open" },
|
|
],
|
|
});
|
|
|
|
for (const pr of repoFixture.prs) {
|
|
const workspace = await openProjectViaDaemon(seedClient, pr.localPath);
|
|
workspaceByTitle.set(pr.title, workspace.id);
|
|
}
|
|
});
|
|
|
|
test.afterAll(async () => {
|
|
await repoFixture?.cleanup().catch(() => undefined);
|
|
await seedClient?.close().catch(() => undefined);
|
|
});
|
|
|
|
test.beforeEach(async () => {
|
|
test.skip(!GITHUB_AUTH, "Requires GitHub authentication (gh auth login)");
|
|
test.setTimeout(60_000);
|
|
});
|
|
|
|
test("renders an open PR with title, state, and repo line", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("Review selected start ref")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneTitle(page, "Review selected start ref");
|
|
await expectPrPaneState(page, "open");
|
|
});
|
|
|
|
test("renders merged state label and icon", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("Merged feature branch")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneState(page, "merged");
|
|
await expectPrPaneTitle(page, "Merged feature branch");
|
|
});
|
|
|
|
test("renders closed state label and icon", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("Closed without merge")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneState(page, "closed");
|
|
await expectPrPaneTitle(page, "Closed without merge");
|
|
});
|
|
|
|
test("renders draft state label and icon", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("Work in progress")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneState(page, "draft");
|
|
await expectPrPaneTitle(page, "Work in progress");
|
|
});
|
|
|
|
test("renders check pills with correct passed/failed/pending counts", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("PR with mixed checks")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneCheckSummary(page, { passed: 2, failed: 1, pending: 1 });
|
|
});
|
|
|
|
test("renders activity rows with correct count", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("PR with reviews")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneActivityCount(page, 3);
|
|
});
|
|
|
|
test("renders gracefully with zero checks", async ({ page }) => {
|
|
await gotoWorkspace(page, workspaceByTitle.get("PR with no checks")!);
|
|
await openPrPane(page);
|
|
|
|
await expectPrPaneCheckSummary(page, { passed: 0, failed: 0, pending: 0 });
|
|
await expectPrPaneTitle(page, "PR with no checks");
|
|
});
|
|
});
|