Update Pi packages to 0.79.9 and align pi-ask with current TUI/RPC behavior. - guard custom ask/settings flows to TUI mode with a clear non-TUI fallback - reset config cache on extension reload so edited settings are picked up - clean up remote ask flow listeners on session shutdown - forward editor focus/invalidation and keep @ file autocomplete explicit - document the non-TUI contract and cover the compatibility fixes with tests
437 lines
10 KiB
TypeScript
437 lines
10 KiB
TypeScript
import assert from "node:assert/strict";
|
|
import test from "node:test";
|
|
import { Editor } from "@earendil-works/pi-tui";
|
|
import { DEFAULT_ASK_CONFIG } from "../src/config/defaults.ts";
|
|
import { getAskConfigStore } from "../src/config/store.ts";
|
|
import { createInitialState } from "../src/state/create.ts";
|
|
import {
|
|
applyNumberShortcut,
|
|
enterQuestionNoteMode,
|
|
} from "../src/state/transitions.ts";
|
|
import { runAskFlow } from "../src/ui/controller.ts";
|
|
import { getInputCommand } from "../src/ui/input.ts";
|
|
|
|
function inputState() {
|
|
let state = createInitialState({
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
});
|
|
state = applyNumberShortcut(state, 2);
|
|
return state;
|
|
}
|
|
|
|
test("empty typing mode uses arrows and tab for navigation", () => {
|
|
const input = inputState();
|
|
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[A", ""), {
|
|
kind: "editMoveOption",
|
|
delta: -1,
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[B", ""), {
|
|
kind: "editMoveOption",
|
|
delta: 1,
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[C", ""), {
|
|
kind: "editMoveTab",
|
|
delta: 1,
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[D", ""), {
|
|
kind: "editMoveTab",
|
|
delta: -1,
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\t", ""), {
|
|
kind: "editMoveTab",
|
|
delta: 1,
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[Z", ""), {
|
|
kind: "editMoveTab",
|
|
delta: -1,
|
|
});
|
|
});
|
|
|
|
test("non-empty typing mode keeps arrows and tab in editor", () => {
|
|
const input = inputState();
|
|
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[A", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[B", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[C", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[D", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\t", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\x1b[Z", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
});
|
|
|
|
test("empty note editing mode uses arrows and tab for navigation", () => {
|
|
const state = enterQuestionNoteMode(
|
|
createInitialState({
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
}),
|
|
"q1"
|
|
);
|
|
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\x1b[A", ""), {
|
|
kind: "editMoveOption",
|
|
delta: -1,
|
|
});
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\x1b[B", ""), {
|
|
kind: "editMoveOption",
|
|
delta: 1,
|
|
});
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\x1b[C", ""), {
|
|
kind: "editMoveTab",
|
|
delta: 1,
|
|
});
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\x1b[D", ""), {
|
|
kind: "editMoveTab",
|
|
delta: -1,
|
|
});
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\t", ""), {
|
|
kind: "editMoveTab",
|
|
delta: 1,
|
|
});
|
|
});
|
|
|
|
test("non-empty note editing mode keeps arrows and tab in editor", () => {
|
|
const state = enterQuestionNoteMode(
|
|
createInitialState({
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
}),
|
|
"q1"
|
|
);
|
|
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\x1b[A", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\x1b[B", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\x1b[C", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\x1b[D", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "\t", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
});
|
|
|
|
test("ctrl+c dismisses the flow from both navigation and editing modes", () => {
|
|
const navigation = createInitialState({
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
});
|
|
const input = inputState();
|
|
const note = enterQuestionNoteMode(navigation, "q1");
|
|
|
|
assert.deepEqual(getInputCommand(navigation, DEFAULT_ASK_CONFIG, "\u0003"), {
|
|
kind: "dismiss",
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "\u0003"), {
|
|
kind: "dismiss",
|
|
});
|
|
assert.deepEqual(getInputCommand(note, DEFAULT_ASK_CONFIG, "\u0003"), {
|
|
kind: "dismiss",
|
|
});
|
|
});
|
|
|
|
test("question mark opens ask settings outside non-empty editors", () => {
|
|
const navigation = createInitialState({
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
});
|
|
const input = inputState();
|
|
|
|
assert.deepEqual(getInputCommand(navigation, DEFAULT_ASK_CONFIG, "?"), {
|
|
kind: "showSettings",
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "?", ""), {
|
|
kind: "showSettings",
|
|
});
|
|
assert.deepEqual(getInputCommand(input, DEFAULT_ASK_CONFIG, "?", "x"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
});
|
|
|
|
test("question type shortcut uses configured main keymap", () => {
|
|
const state = createInitialState({
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
});
|
|
const config = {
|
|
...DEFAULT_ASK_CONFIG,
|
|
keymaps: {
|
|
...DEFAULT_ASK_CONFIG.keymaps,
|
|
main: {
|
|
...DEFAULT_ASK_CONFIG.keymaps.main,
|
|
changeQuestionType: ["ctrl+t"],
|
|
},
|
|
},
|
|
};
|
|
|
|
assert.deepEqual(getInputCommand(state, DEFAULT_ASK_CONFIG, "t"), {
|
|
kind: "changeQuestionType",
|
|
});
|
|
assert.deepEqual(getInputCommand(state, config, "\u0014"), {
|
|
kind: "changeQuestionType",
|
|
});
|
|
});
|
|
|
|
test("note shortcuts use n for option notes and Shift+N for question notes", () => {
|
|
const navigation = createInitialState({
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
});
|
|
|
|
assert.deepEqual(getInputCommand(navigation, DEFAULT_ASK_CONFIG, "n"), {
|
|
kind: "openOptionNote",
|
|
});
|
|
assert.deepEqual(getInputCommand(navigation, DEFAULT_ASK_CONFIG, "N"), {
|
|
kind: "openQuestionNote",
|
|
});
|
|
});
|
|
|
|
test("custom configured editor submit shortcut is used at runtime", () => {
|
|
const input = inputState();
|
|
const config = {
|
|
...DEFAULT_ASK_CONFIG,
|
|
keymaps: {
|
|
...DEFAULT_ASK_CONFIG.keymaps,
|
|
editor: {
|
|
...DEFAULT_ASK_CONFIG.keymaps.editor,
|
|
submit: ["ctrl+k"],
|
|
},
|
|
},
|
|
};
|
|
|
|
assert.deepEqual(getInputCommand(input, config, "\u000b", "answer"), {
|
|
kind: "editSubmit",
|
|
});
|
|
assert.deepEqual(getInputCommand(input, config, "\r", "answer"), {
|
|
kind: "delegateToEditor",
|
|
});
|
|
});
|
|
|
|
test("custom editor submit key controls actual editor submission", async () => {
|
|
const config = {
|
|
...DEFAULT_ASK_CONFIG,
|
|
notifications: {
|
|
...DEFAULT_ASK_CONFIG.notifications,
|
|
enabled: false,
|
|
},
|
|
keymaps: {
|
|
...DEFAULT_ASK_CONFIG.keymaps,
|
|
editor: {
|
|
...DEFAULT_ASK_CONFIG.keymaps.editor,
|
|
submit: ["ctrl+k"],
|
|
},
|
|
},
|
|
};
|
|
getAskConfigStore().setConfig(config);
|
|
let component: { handleInput(data: string): void } | undefined;
|
|
const resultPromise = runAskFlow(
|
|
{
|
|
cwd: process.cwd(),
|
|
mode: "tui",
|
|
ui: {
|
|
custom(callback: (...args: unknown[]) => unknown) {
|
|
return new Promise((resolve) => {
|
|
const tui = {
|
|
requestRender() {
|
|
// Rendering is not needed for this controller input test.
|
|
},
|
|
};
|
|
component = callback(
|
|
tui,
|
|
plainTheme(),
|
|
{},
|
|
resolve
|
|
) as typeof component;
|
|
});
|
|
},
|
|
},
|
|
} as never,
|
|
{
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
}
|
|
);
|
|
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
component?.handleInput("2");
|
|
component?.handleInput("x");
|
|
component?.handleInput("\r");
|
|
component?.handleInput("\u000b");
|
|
component?.handleInput("\r");
|
|
const result = await resultPromise;
|
|
|
|
assert.equal(result.answers.q1?.customText, "x");
|
|
getAskConfigStore().setConfig(DEFAULT_ASK_CONFIG);
|
|
});
|
|
|
|
function plainTheme() {
|
|
return {
|
|
bg(_color: string, text: string) {
|
|
return text;
|
|
},
|
|
fg(_color: string, text: string) {
|
|
return text;
|
|
},
|
|
};
|
|
}
|
|
|
|
test("ask flow forwards focus and invalidation to its editor", async () => {
|
|
getAskConfigStore().setConfig({
|
|
...DEFAULT_ASK_CONFIG,
|
|
notifications: {
|
|
...DEFAULT_ASK_CONFIG.notifications,
|
|
enabled: false,
|
|
},
|
|
});
|
|
const originalInvalidate = Editor.prototype.invalidate;
|
|
let invalidateCalls = 0;
|
|
Editor.prototype.invalidate = function patchedInvalidate(this: Editor) {
|
|
invalidateCalls += 1;
|
|
return originalInvalidate.call(this);
|
|
};
|
|
let component:
|
|
| {
|
|
focused: boolean;
|
|
handleInput(data: string): void;
|
|
invalidate(): void;
|
|
}
|
|
| undefined;
|
|
|
|
try {
|
|
const resultPromise = runAskFlow(
|
|
{
|
|
cwd: process.cwd(),
|
|
mode: "tui",
|
|
ui: {
|
|
custom(callback: (...args: unknown[]) => unknown) {
|
|
return new Promise((resolve) => {
|
|
component = callback(
|
|
{
|
|
requestRender() {
|
|
// Rendering is not needed for this controller test.
|
|
},
|
|
},
|
|
plainTheme(),
|
|
{},
|
|
resolve
|
|
) as typeof component;
|
|
});
|
|
},
|
|
},
|
|
} as never,
|
|
{
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
}
|
|
);
|
|
|
|
await new Promise((resolve) => setImmediate(resolve));
|
|
assert(component);
|
|
component.focused = true;
|
|
assert.equal(component.focused, true);
|
|
component.focused = false;
|
|
assert.equal(component.focused, false);
|
|
component.invalidate();
|
|
assert.equal(invalidateCalls, 1);
|
|
component.handleInput("\x1b");
|
|
const result = await resultPromise;
|
|
assert.equal(result.cancelled, true);
|
|
} finally {
|
|
Editor.prototype.invalidate = originalInvalidate;
|
|
getAskConfigStore().setConfig(DEFAULT_ASK_CONFIG);
|
|
}
|
|
});
|
|
|
|
test("custom configured note shortcuts are used at runtime", () => {
|
|
const navigation = createInitialState({
|
|
questions: [
|
|
{
|
|
id: "q1",
|
|
prompt: "Question?",
|
|
options: [{ value: "a", label: "A" }],
|
|
},
|
|
],
|
|
});
|
|
const config = {
|
|
...DEFAULT_ASK_CONFIG,
|
|
keymaps: {
|
|
...DEFAULT_ASK_CONFIG.keymaps,
|
|
main: {
|
|
...DEFAULT_ASK_CONFIG.keymaps.main,
|
|
optionNote: ["x"],
|
|
questionNote: ["shift+x"],
|
|
},
|
|
},
|
|
};
|
|
|
|
assert.deepEqual(getInputCommand(navigation, config, "x"), {
|
|
kind: "openOptionNote",
|
|
});
|
|
assert.deepEqual(getInputCommand(navigation, config, "X"), {
|
|
kind: "openQuestionNote",
|
|
});
|
|
});
|