fix(app): simplify workspace add-tab labels
Use noun labels in the add-tab menu so creation targets read consistently alongside Changes, Files, and Pull request. Keep verb-oriented labels in shortcut and command surfaces.
This commit is contained in:
@@ -61,7 +61,7 @@ test.describe("Tab creation", () => {
|
||||
await expect(page.getByRole("navigation", { name: "Settings" })).toBeVisible();
|
||||
|
||||
await page.keyboard.press(`${modifier}+t`);
|
||||
await expect(page.getByRole("menuitem", { name: /New agent/ })).toHaveCount(0);
|
||||
await expect(page.getByRole("menuitem", { name: /^Agent/ })).toHaveCount(0);
|
||||
|
||||
await page.goto(workspaceUrl);
|
||||
await assertNewTabMenuTriggerVisible(page);
|
||||
@@ -101,8 +101,8 @@ test.describe("Tab creation", () => {
|
||||
await gotoWorkspace(page, workspace.workspaceId);
|
||||
await openNewTabMenuWithShortcut(page);
|
||||
|
||||
const agent = page.getByRole("menuitem", { name: /New agent/ });
|
||||
const terminal = page.getByRole("menuitem", { name: /New terminal/ });
|
||||
const agent = page.getByRole("menuitem", { name: /^Agent/ });
|
||||
const terminal = page.getByRole("menuitem", { name: /^Terminal/ });
|
||||
const changes = page.getByRole("menuitem", { name: /Changes/ });
|
||||
const files = page.getByRole("menuitem", { name: /Files/ });
|
||||
const shortcutPrefix = process.platform === "darwin" ? /⇧⌘/ : /Ctrl.*Shift/;
|
||||
|
||||
@@ -70,7 +70,7 @@ export async function pressNewTabShortcut(page: Page): Promise<void> {
|
||||
|
||||
export async function openNewTabMenuWithShortcut(page: Page): Promise<void> {
|
||||
await pressNewTabShortcut(page);
|
||||
await expect(page.getByRole("menuitem", { name: /New agent/ })).toBeVisible();
|
||||
await expect(page.getByRole("menuitem", { name: /^Agent/ })).toBeVisible();
|
||||
}
|
||||
|
||||
export async function pressDirectNewTabShortcut(page: Page, key: string): Promise<void> {
|
||||
|
||||
@@ -381,7 +381,7 @@ function WorkspaceNewTabButton({
|
||||
trailing={agentShortcut}
|
||||
onSelect={onCreateAgentTab}
|
||||
>
|
||||
{t("workspace.tabs.actions.newAgent")}
|
||||
{t("workspace.tabs.fallback.agent")}
|
||||
</DropdownMenuItem>
|
||||
<DropdownMenuItem
|
||||
testID="workspace-new-tab-menu-terminal"
|
||||
@@ -390,7 +390,7 @@ function WorkspaceNewTabButton({
|
||||
trailing={terminalShortcut}
|
||||
onSelect={terminalDisabled ? undefined : onCreateTerminal}
|
||||
>
|
||||
{t("workspace.tabs.actions.newTerminal")}
|
||||
{t("workspace.tabs.fallback.terminal")}
|
||||
</DropdownMenuItem>
|
||||
{showCreateBrowserTab ? (
|
||||
<DropdownMenuItem
|
||||
@@ -399,7 +399,7 @@ function WorkspaceNewTabButton({
|
||||
trailing={browserShortcut}
|
||||
onSelect={onCreateBrowser}
|
||||
>
|
||||
{t("workspace.tabs.actions.newBrowser")}
|
||||
{t("workspace.tabs.fallback.browser")}
|
||||
</DropdownMenuItem>
|
||||
) : null}
|
||||
{isGit ? (
|
||||
|
||||
Reference in New Issue
Block a user